[GitHub] [rocketmq-client-python] messense commented on a change in pull request #51: Add transaction message support

[GitBox <gi...@apache.org>]

messense commented on a change in pull request #51: Add transaction message support
URL: https://github.com/apache/rocketmq-client-python/pull/51#discussion_r334500275
 
 

 ##########
 File path: src/PythonWrapper.cpp
 ##########
 @@ -134,6 +123,27 @@ void *PyCreateProducer(const char *groupId) {
     PyEval_InitThreads();  // ensure create GIL, for call Python callback from C.
     return (void *) CreateProducer(groupId);
 }
+
+void *PyCreateTransactionProducer(const char *groupId, PyObject *localTransactionCheckerCallback) {
+    PyEval_InitThreads();
+    CProducer *producer = CreateTransactionProducer(groupId, &PyLocalTransactionCheckerCallback, NULL);
 
 Review comment:
   I can't find `CreateTransactionProducer` implementation in the cpp repository, only the function prototype was found.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services