You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Madhuvanthi Radhakrishnan <mr...@hortonworks.com> on 2017/01/17 23:07:59 UTC

Review Request 55651: AMS log4j rotation properties changes should be visible on ambari-upgrade

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55651/
-----------------------------------------------------------

Review request for Ambari and Sumit Mohanty.


Bugs: AMBARI-19600
    https://issues.apache.org/jira/browse/AMBARI-19600


Repository: ambari


Description
-------

AMS log4j rotation properties changes should be visible on ambari-upgrade


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java d19db3c 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-log4j.xml ab42034 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-log4j.xml 5782e7c 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java 3c5b475 

Diff: https://reviews.apache.org/r/55651/diff/


Testing
-------

Unit tests
Ambari upgrade 2.4 -> 2.5


Thanks,

Madhuvanthi Radhakrishnan


Re: Review Request 55651: AMS log4j rotation properties changes should be visible on ambari-upgrade

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55651/#review162011
-----------------------------------------------------------


Ship it!




Ship It!

- Sumit Mohanty


On Jan. 17, 2017, 11:07 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55651/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2017, 11:07 p.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19600
>     https://issues.apache.org/jira/browse/AMBARI-19600
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> AMS log4j rotation properties changes should be visible on ambari-upgrade
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java d19db3c 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-log4j.xml ab42034 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-log4j.xml 5782e7c 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java 3c5b475 
> 
> Diff: https://reviews.apache.org/r/55651/diff/
> 
> 
> Testing
> -------
> 
> Unit tests
> Ambari upgrade 2.4 -> 2.5
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>