You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/07/26 15:14:03 UTC

[GitHub] [bookkeeper] StevenLuMT commented on a diff in pull request #3192: Fix compaction throttle imprecise

StevenLuMT commented on code in PR #3192:
URL: https://github.com/apache/bookkeeper/pull/3192#discussion_r930092677


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BufferedReadChannel.java:
##########
@@ -61,17 +63,18 @@ public BufferedReadChannel(FileChannel fileChannel, int readCapacity) {
      *         -1 if the given position is greater than or equal to the file's current size.

Review Comment:
   I think @hangc0276 you should update this description for method's return 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org