You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by pm...@apache.org on 2019/05/31 21:04:11 UTC
[samza] branch master updated: processorCount AtomicInt Metrics
fixes
This is an automated email from the ASF dual-hosted git repository.
pmaheshwari pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/samza.git
The following commit(s) were added to refs/heads/master by this push:
new e1a7275 processorCount AtomicInt Metrics fixes
e1a7275 is described below
commit e1a72750abe2735b1bfe128a7531b62d6b7781cc
Author: thunderstumpges <ts...@ntent.com>
AuthorDate: Fri May 31 14:04:03 2019 -0700
processorCount AtomicInt Metrics fixes
Returning the AtomicInteger instances directly for `processorCount` was causing issues with our InfluxDB reporter. I added the `.get()` to match all the others.
Author: thunderstumpges <ts...@ntent.com>
Reviewers: Prateek Maheshwari <pm...@apache.org>
Closes #1058 from thunderstumpges/atomic-int-metrics-fix
---
.../scala/org/apache/samza/metrics/ContainerProcessManagerMetrics.scala | 2 +-
.../main/scala/org/apache/samza/job/yarn/SamzaAppMasterMetrics.scala | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/samza-core/src/main/scala/org/apache/samza/metrics/ContainerProcessManagerMetrics.scala b/samza-core/src/main/scala/org/apache/samza/metrics/ContainerProcessManagerMetrics.scala
index 6d6b1b7..a21668b 100644
--- a/samza-core/src/main/scala/org/apache/samza/metrics/ContainerProcessManagerMetrics.scala
+++ b/samza-core/src/main/scala/org/apache/samza/metrics/ContainerProcessManagerMetrics.scala
@@ -38,7 +38,7 @@ class ContainerProcessManagerMetrics(val config: Config,
val mCompletedContainers = newGauge("completed-containers", () => state.completedProcessors.get())
val mFailedContainers = newGauge("failed-containers", () => state.failedContainers.get())
val mReleasedContainers = newGauge("released-containers", () => state.releasedContainers.get())
- val mContainers = newGauge("container-count", () => state.processorCount)
+ val mContainers = newGauge("container-count", () => state.processorCount.get())
val mRedundantNotifications = newGauge("redundant-notifications", () => state.redundantNotifications.get())
val mJobHealthy = newGauge("job-healthy", () => if (state.jobHealthy.get()) 1 else 0)
val mPreferredHostRequests = newGauge("preferred-host-requests", () => state.preferredHostRequests.get())
diff --git a/samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterMetrics.scala b/samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterMetrics.scala
index 49c8a20..e0b7d18 100644
--- a/samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterMetrics.scala
+++ b/samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterMetrics.scala
@@ -52,7 +52,7 @@ class SamzaAppMasterMetrics(
val mCompletedContainers = newGauge("completed-containers", () => state.completedProcessors.get())
val mFailedContainers = newGauge("failed-containers", () => state.failedContainers.get())
val mReleasedContainers = newGauge("released-containers", () => state.releasedContainers.get())
- val mContainers = newGauge("container-count", () => state.processorCount)
+ val mContainers = newGauge("container-count", () => state.processorCount.get())
val mJobHealthy = newGauge("job-healthy", () => if (state.jobHealthy.get()) 1 else 0)
reporters.values.foreach(_.start)