[GitHub] [flink] TisonKun edited a comment on issue #10185: [FLINK-14762][client] Implement ClusterClientJobClientAdapter

[GitBox <gi...@apache.org>]

TisonKun edited a comment on issue #10185: [FLINK-14762][client] Implement ClusterClientJobClientAdapter
URL: https://github.com/apache/flink/pull/10185#issuecomment-554872452
 
 
   @aljoscha it sounds a bit weird to me. If we move `JobClient` interface to `flink-core` and remains the implementation in `flink-client`, what for `ClusterClient`? Besides, then regards the name of `flink-client`, it means clients implementation but without their interfaces.
   
   Previously I'm thinking of letting `flink-runtime` depends on `flink-client` so that we can test job submission/management via clients instead of exposing similar methods in `MiniCluster` for hacking so. What if we keep client interface in `flink-client` and move the implementation in `flink-runtime`?
   
   Any way we put the interface in module A and the implementation in module B which depends on module A, we have to introduce a dynamic discovery/loading mechanism, shall we?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services