You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "OneSizeFitsQuorum (via GitHub)" <gi...@apache.org> on 2024/12/19 08:00:13 UTC
[PR] Revert "[IOTDB-6353] replace cglib to byte-buddy (#14426)" [iotdb]
OneSizeFitsQuorum opened a new pull request, #14497:
URL: https://github.com/apache/iotdb/pull/14497
Performance degradation was observed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert "[IOTDB-6353] replace cglib to byte-buddy (#14426)" [iotdb]
Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou commented on PR #14497:
URL: https://github.com/apache/iotdb/pull/14497#issuecomment-2553249826
Should we try some newer versions before we do this revert?
https://github.com/raphw/byte-buddy/releases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert "[IOTDB-6353] replace cglib to byte-buddy (#14426)" [iotdb]
Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou commented on PR #14497:
URL: https://github.com/apache/iotdb/pull/14497#issuecomment-2556081572
ok, the latest version of byte-buddy still has the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert "[IOTDB-6353] replace cglib to byte-buddy (#14426)" [iotdb]
Posted by "OneSizeFitsQuorum (via GitHub)" <gi...@apache.org>.
OneSizeFitsQuorum merged PR #14497:
URL: https://github.com/apache/iotdb/pull/14497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert "[IOTDB-6353] replace cglib to byte-buddy (#14426)" [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #14497:
URL: https://github.com/apache/iotdb/pull/14497#issuecomment-2553031938
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14497) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=14497&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=14497&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=14497&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=14497&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=14497&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14497)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert "[IOTDB-6353] replace cglib to byte-buddy (#14426)" [iotdb]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #14497:
URL: https://github.com/apache/iotdb/pull/14497#issuecomment-2553118805
## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/14497?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `91.66667%` with `1 line` in your changes missing coverage. Please review.
> Project coverage is 39.62%. Comparing base [(`55b37e0`)](https://app.codecov.io/gh/apache/iotdb/commit/55b37e0d14a3788a3d0f989e3dde4ed497b84332?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`9b39c01`)](https://app.codecov.io/gh/apache/iotdb/commit/9b39c01b7a717cb44461c0de75fe68bdfe300b78?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 5 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/iotdb/pull/14497?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../client/sync/SyncThriftClientWithErrorHandler.java](https://app.codecov.io/gh/apache/iotdb/pull/14497?src=pr&el=tree&filepath=iotdb-core%2Fnode-commons%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fcommons%2Fclient%2Fsync%2FSyncThriftClientWithErrorHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9ub2RlLWNvbW1vbnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2lvdGRiL2NvbW1vbnMvY2xpZW50L3N5bmMvU3luY1RocmlmdENsaWVudFdpdGhFcnJvckhhbmRsZXIuamF2YQ==) | 91.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/14497?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #14497 +/- ##
============================================
+ Coverage 39.60% 39.62% +0.01%
Complexity 185 185
============================================
Files 4334 4334
Lines 275866 275910 +44
Branches 33533 33531 -2
============================================
+ Hits 109267 109328 +61
+ Misses 166599 166582 -17
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/iotdb/pull/14497?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org