You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/11/10 11:58:19 UTC
[GitHub] [flink] fsk119 opened a new pull request #14017: [FLINK-19859][document] Add document for the upsert-kafka connector
fsk119 opened a new pull request #14017:
URL: https://github.com/apache/flink/pull/14017
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*Added document for upsert-kafka.*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / **docs** / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14017: [FLINK-19859][document] Add document for the upsert-kafka connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14017:
URL: https://github.com/apache/flink/pull/14017#issuecomment-724665676
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88a1f9ed960f7cf504645f3a430542aa9d8e5b77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9404",
"triggerID" : "88a1f9ed960f7cf504645f3a430542aa9d8e5b77",
"triggerType" : "PUSH"
}, {
"hash" : "ec1ba44a2c99309f8120a00beab017210e3c02ab",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9497",
"triggerID" : "ec1ba44a2c99309f8120a00beab017210e3c02ab",
"triggerType" : "PUSH"
}, {
"hash" : "6b9d7baf0cdbd007afef5d280c5297f039bb5d2b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9515",
"triggerID" : "6b9d7baf0cdbd007afef5d280c5297f039bb5d2b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ec1ba44a2c99309f8120a00beab017210e3c02ab Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9497)
* 6b9d7baf0cdbd007afef5d280c5297f039bb5d2b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9515)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14017: [FLINK-19859][document] Add document for the upsert-kafka connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14017:
URL: https://github.com/apache/flink/pull/14017#issuecomment-724665676
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88a1f9ed960f7cf504645f3a430542aa9d8e5b77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9404",
"triggerID" : "88a1f9ed960f7cf504645f3a430542aa9d8e5b77",
"triggerType" : "PUSH"
}, {
"hash" : "ec1ba44a2c99309f8120a00beab017210e3c02ab",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9497",
"triggerID" : "ec1ba44a2c99309f8120a00beab017210e3c02ab",
"triggerType" : "PUSH"
}, {
"hash" : "6b9d7baf0cdbd007afef5d280c5297f039bb5d2b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9515",
"triggerID" : "6b9d7baf0cdbd007afef5d280c5297f039bb5d2b",
"triggerType" : "PUSH"
}, {
"hash" : "7dff1e172e3b99d819cfc1cbc1eedf71bea94626",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9548",
"triggerID" : "7dff1e172e3b99d819cfc1cbc1eedf71bea94626",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6b9d7baf0cdbd007afef5d280c5297f039bb5d2b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9515)
* 7dff1e172e3b99d819cfc1cbc1eedf71bea94626 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9548)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14017: [FLINK-19859][document] Add document for the upsert-kafka connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14017:
URL: https://github.com/apache/flink/pull/14017#issuecomment-724665676
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88a1f9ed960f7cf504645f3a430542aa9d8e5b77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9404",
"triggerID" : "88a1f9ed960f7cf504645f3a430542aa9d8e5b77",
"triggerType" : "PUSH"
}, {
"hash" : "ec1ba44a2c99309f8120a00beab017210e3c02ab",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9497",
"triggerID" : "ec1ba44a2c99309f8120a00beab017210e3c02ab",
"triggerType" : "PUSH"
}, {
"hash" : "6b9d7baf0cdbd007afef5d280c5297f039bb5d2b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9515",
"triggerID" : "6b9d7baf0cdbd007afef5d280c5297f039bb5d2b",
"triggerType" : "PUSH"
}, {
"hash" : "7dff1e172e3b99d819cfc1cbc1eedf71bea94626",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9548",
"triggerID" : "7dff1e172e3b99d819cfc1cbc1eedf71bea94626",
"triggerType" : "PUSH"
}, {
"hash" : "15e57df54d0395ec719f98e5330601f463c3e885",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "15e57df54d0395ec719f98e5330601f463c3e885",
"triggerType" : "PUSH"
}, {
"hash" : "37fd7800a63bdc4d1c9e4cc06a450f1faeebbc18",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9620",
"triggerID" : "37fd7800a63bdc4d1c9e4cc06a450f1faeebbc18",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7dff1e172e3b99d819cfc1cbc1eedf71bea94626 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9548)
* 15e57df54d0395ec719f98e5330601f463c3e885 UNKNOWN
* 37fd7800a63bdc4d1c9e4cc06a450f1faeebbc18 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9620)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14017: [FLINK-19859][document] Add document for the upsert-kafka connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14017:
URL: https://github.com/apache/flink/pull/14017#issuecomment-724665676
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88a1f9ed960f7cf504645f3a430542aa9d8e5b77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9404",
"triggerID" : "88a1f9ed960f7cf504645f3a430542aa9d8e5b77",
"triggerType" : "PUSH"
}, {
"hash" : "ec1ba44a2c99309f8120a00beab017210e3c02ab",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9497",
"triggerID" : "ec1ba44a2c99309f8120a00beab017210e3c02ab",
"triggerType" : "PUSH"
}, {
"hash" : "6b9d7baf0cdbd007afef5d280c5297f039bb5d2b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9515",
"triggerID" : "6b9d7baf0cdbd007afef5d280c5297f039bb5d2b",
"triggerType" : "PUSH"
}, {
"hash" : "7dff1e172e3b99d819cfc1cbc1eedf71bea94626",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9548",
"triggerID" : "7dff1e172e3b99d819cfc1cbc1eedf71bea94626",
"triggerType" : "PUSH"
}, {
"hash" : "15e57df54d0395ec719f98e5330601f463c3e885",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "15e57df54d0395ec719f98e5330601f463c3e885",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7dff1e172e3b99d819cfc1cbc1eedf71bea94626 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9548)
* 15e57df54d0395ec719f98e5330601f463c3e885 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14017: [FLINK-19859][document] Add document for the upsert-kafka connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14017:
URL: https://github.com/apache/flink/pull/14017#issuecomment-724665676
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88a1f9ed960f7cf504645f3a430542aa9d8e5b77",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9404",
"triggerID" : "88a1f9ed960f7cf504645f3a430542aa9d8e5b77",
"triggerType" : "PUSH"
}, {
"hash" : "ec1ba44a2c99309f8120a00beab017210e3c02ab",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ec1ba44a2c99309f8120a00beab017210e3c02ab",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 88a1f9ed960f7cf504645f3a430542aa9d8e5b77 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9404)
* ec1ba44a2c99309f8120a00beab017210e3c02ab UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman commented on pull request #14017: [FLINK-19859][document] Add document for the upsert-kafka connector
Posted by GitBox <gi...@apache.org>.
sjwiesman commented on pull request #14017:
URL: https://github.com/apache/flink/pull/14017#issuecomment-726474622
@fsk119 I just merged in #14036 which adds an autogenerated downloads page for sql connectors. Please rebase your PR and make two changes to your docs:
1) Please add upsert-kafka to the list of connectors to the [downloads list](https://github.com/apache/flink/blob/master/docs/_data/sql-connectors.yml)
2) Replace your dependencies table in upsert-kafka.md with the following liquid tags. This will autogenerate the table based on the above yaml.
```md
{% assign connector = site.data.sql-connectors['upsert-kafka'] %}
{% include sql-connector-download-table.html
connector=connector
%}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14017: [FLINK-19859][document] Add document for the upsert-kafka connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14017:
URL: https://github.com/apache/flink/pull/14017#issuecomment-724665676
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88a1f9ed960f7cf504645f3a430542aa9d8e5b77",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9404",
"triggerID" : "88a1f9ed960f7cf504645f3a430542aa9d8e5b77",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 88a1f9ed960f7cf504645f3a430542aa9d8e5b77 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9404)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong merged pull request #14017: [FLINK-19859][document] Add document for the upsert-kafka connector
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #14017:
URL: https://github.com/apache/flink/pull/14017
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #14017: [FLINK-19859][document] Add document for the upsert-kafka connector
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #14017:
URL: https://github.com/apache/flink/pull/14017#discussion_r521988727
##########
File path: docs/dev/table/connectors/upsert-kafka.md
##########
@@ -43,7 +43,7 @@ To use the connector, add the following Maven dependency to your project:
{% highlight xml %}
<dependency>
<groupId>org.apache.flink</groupId>
- <artifactId>flink-connector-kafka_2.11</artifactId>
+ <artifactId>flink-connector-kafka_{{site.scala_version_suffix}}</artifactId>
Review comment:
`site.scala_version_suffix` already includes the `_` prefix. So it should be `flink-connector-kafka{{site.scala_version_suffix}}`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14017: [FLINK-19859][document] Add document for the upsert-kafka connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14017:
URL: https://github.com/apache/flink/pull/14017#issuecomment-724665676
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88a1f9ed960f7cf504645f3a430542aa9d8e5b77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9404",
"triggerID" : "88a1f9ed960f7cf504645f3a430542aa9d8e5b77",
"triggerType" : "PUSH"
}, {
"hash" : "ec1ba44a2c99309f8120a00beab017210e3c02ab",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9497",
"triggerID" : "ec1ba44a2c99309f8120a00beab017210e3c02ab",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ec1ba44a2c99309f8120a00beab017210e3c02ab Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9497)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14017: [FLINK-19859][document] Add document for the upsert-kafka connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14017:
URL: https://github.com/apache/flink/pull/14017#issuecomment-724665676
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88a1f9ed960f7cf504645f3a430542aa9d8e5b77",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9404",
"triggerID" : "88a1f9ed960f7cf504645f3a430542aa9d8e5b77",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 88a1f9ed960f7cf504645f3a430542aa9d8e5b77 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9404)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14017: [FLINK-19859][document] Add document for the upsert-kafka connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14017:
URL: https://github.com/apache/flink/pull/14017#issuecomment-724665676
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88a1f9ed960f7cf504645f3a430542aa9d8e5b77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9404",
"triggerID" : "88a1f9ed960f7cf504645f3a430542aa9d8e5b77",
"triggerType" : "PUSH"
}, {
"hash" : "ec1ba44a2c99309f8120a00beab017210e3c02ab",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9497",
"triggerID" : "ec1ba44a2c99309f8120a00beab017210e3c02ab",
"triggerType" : "PUSH"
}, {
"hash" : "6b9d7baf0cdbd007afef5d280c5297f039bb5d2b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6b9d7baf0cdbd007afef5d280c5297f039bb5d2b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ec1ba44a2c99309f8120a00beab017210e3c02ab Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9497)
* 6b9d7baf0cdbd007afef5d280c5297f039bb5d2b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #14017: [FLINK-19859][document] Add document for the upsert-kafka connector
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #14017:
URL: https://github.com/apache/flink/pull/14017#discussion_r523979437
##########
File path: docs/dev/table/connectors/upsert-kafka.md
##########
@@ -0,0 +1,204 @@
+---
+title: "Upsert Kafka SQL Connector"
+nav-title: Upsert Kafka
+nav-parent_id: sql-connectors
+nav-pos: 3
+---
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<span class="label label-primary">Scan Source: Unbounded</span>
+<span class="label label-primary">Sink: Streaming Upsert Mode</span>
+
+* This will be replaced by the TOC
+{:toc}
+
+The Upsert Kafka connector allows for reading data from and writing data into Kafka topics in the upsert fashion.
+
+As a source, the upsert-kafka connector produces a changelog stream, where each data record represents
+an update or delete event. More precisely, the value in a data record is interpreted as an UPDATE of
+the last value for the same key, if any (if a corresponding key doesn’t exist yet, the update will
+be considered an INSERT). Using the table analogy, a data record in a changelog stream is interpreted
+as an UPSERT aka INSERT/UPDATE because any existing row with the same key is overwritten. Also, null
+values are interpreted in a special way: a record with a null value represents a “DELETE”.
+
+As a sink, the upsert-kafka connector can consume a changelog stream. It will write INSERT/UPDATE_AFTER
+data as normal Kafka messages value, and write DELETE data as Kafka messages with null values
+(indicate tombstone for the key). Flink will guarantee the message ordering on the primary key by
+partition data on the values of the primary key columns, so the update/deletion messages on the same
+key will fall into the same partition.
+
+Dependencies
+------------
+
+In order to set up the upsert-kafka connector, the following table provide dependency information for
+both projects using a build automation tool (such as Maven or SBT) and SQL Client with SQL JAR bundles.
+
+{% assign connector = site.data.sql-connectors['upsert-kafka'] %}
+{% include sql-connector-download-table.html
+ connector=connector
+%}
+
+Full Example
+----------------
+
+The example below shows how to create and use an Upsert Kafka table:
+
+<div class="codetabs" markdown="1">
+<div data-lang="SQL" markdown="1">
+{% highlight sql %}
+CREATE TABLE pageviews_per_region (
+ region STRING,
+ pv BIGINT,
+ uv BIGINT,
+ PRIMARY KEY region NOT ENFORCED
+) WITH (
+ 'connector' = 'upsert-kafka',
+ 'topic' = 'pageviews_per_region',
+ 'properties.bootstrap.servers' = '...',
+ 'key.format' = 'csv',
Review comment:
```suggestion
'key.format' = 'avro',
```
最好不要用 csv，我记得 csv 在处理单字段的时候是有问题的。
可以本地测试试试这个 example。
##########
File path: docs/dev/table/connectors/upsert-kafka.md
##########
@@ -43,7 +43,7 @@ To use the connector, add the following Maven dependency to your project:
{% highlight xml %}
<dependency>
<groupId>org.apache.flink</groupId>
- <artifactId>flink-connector-kafka_2.11</artifactId>
+ <artifactId>flink-connector-kafka_{{site.scala_version_suffix}}</artifactId>
Review comment:
`site.scala_version_suffix` already includes the `_` prefix. So it should be `flink-connector-kafka{{site.scala_version_suffix}}`.
##########
File path: docs/dev/table/connectors/upsert-kafka.md
##########
@@ -0,0 +1,204 @@
+---
+title: "Upsert Kafka SQL Connector"
+nav-title: Upsert Kafka
+nav-parent_id: sql-connectors
+nav-pos: 3
+---
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<span class="label label-primary">Scan Source: Unbounded</span>
+<span class="label label-primary">Sink: Streaming Upsert Mode</span>
+
+* This will be replaced by the TOC
+{:toc}
+
+The Upsert Kafka connector allows for reading data from and writing data into Kafka topics in the upsert fashion.
+
+As a source, the upsert-kafka connector produces a changelog stream, where each data record represents
+an update or delete event. More precisely, the value in a data record is interpreted as an UPDATE of
+the last value for the same key, if any (if a corresponding key doesn’t exist yet, the update will
+be considered an INSERT). Using the table analogy, a data record in a changelog stream is interpreted
+as an UPSERT aka INSERT/UPDATE because any existing row with the same key is overwritten. Also, null
+values are interpreted in a special way: a record with a null value represents a “DELETE”.
+
+As a sink, the upsert-kafka connector can consume a changelog stream. It will write INSERT/UPDATE_AFTER
+data as normal Kafka messages value, and write DELETE data as Kafka messages with null values
+(indicate tombstone for the key). Flink will guarantee the message ordering on the primary key by
+partition data on the values of the primary key columns, so the update/deletion messages on the same
+key will fall into the same partition.
+
+Dependencies
+------------
+
+In order to set up the upsert-kafka connector, the following table provide dependency information for
+both projects using a build automation tool (such as Maven or SBT) and SQL Client with SQL JAR bundles.
+
+{% assign connector = site.data.sql-connectors['upsert-kafka'] %}
+{% include sql-connector-download-table.html
+ connector=connector
+%}
+
+Full Example
+----------------
+
+The example below shows how to create and use an Upsert Kafka table:
+
+<div class="codetabs" markdown="1">
+<div data-lang="SQL" markdown="1">
+{% highlight sql %}
+CREATE TABLE pageviews_per_region (
+ region STRING,
+ pv BIGINT,
+ uv BIGINT,
+ PRIMARY KEY region NOT ENFORCED
Review comment:
```suggestion
PRIMARY KEY (region) NOT ENFORCED
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fsk119 commented on a change in pull request #14017: [FLINK-19859][document] Add document for the upsert-kafka connector
Posted by GitBox <gi...@apache.org>.
fsk119 commented on a change in pull request #14017:
URL: https://github.com/apache/flink/pull/14017#discussion_r524060554
##########
File path: docs/dev/table/connectors/upsert-kafka.md
##########
@@ -0,0 +1,204 @@
+---
+title: "Upsert Kafka SQL Connector"
+nav-title: Upsert Kafka
+nav-parent_id: sql-connectors
+nav-pos: 3
+---
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<span class="label label-primary">Scan Source: Unbounded</span>
+<span class="label label-primary">Sink: Streaming Upsert Mode</span>
+
+* This will be replaced by the TOC
+{:toc}
+
+The Upsert Kafka connector allows for reading data from and writing data into Kafka topics in the upsert fashion.
+
+As a source, the upsert-kafka connector produces a changelog stream, where each data record represents
+an update or delete event. More precisely, the value in a data record is interpreted as an UPDATE of
+the last value for the same key, if any (if a corresponding key doesn’t exist yet, the update will
+be considered an INSERT). Using the table analogy, a data record in a changelog stream is interpreted
+as an UPSERT aka INSERT/UPDATE because any existing row with the same key is overwritten. Also, null
+values are interpreted in a special way: a record with a null value represents a “DELETE”.
+
+As a sink, the upsert-kafka connector can consume a changelog stream. It will write INSERT/UPDATE_AFTER
+data as normal Kafka messages value, and write DELETE data as Kafka messages with null values
+(indicate tombstone for the key). Flink will guarantee the message ordering on the primary key by
+partition data on the values of the primary key columns, so the update/deletion messages on the same
+key will fall into the same partition.
+
+Dependencies
+------------
+
+In order to set up the upsert-kafka connector, the following table provide dependency information for
+both projects using a build automation tool (such as Maven or SBT) and SQL Client with SQL JAR bundles.
+
+{% assign connector = site.data.sql-connectors['upsert-kafka'] %}
+{% include sql-connector-download-table.html
+ connector=connector
+%}
+
+Full Example
+----------------
+
+The example below shows how to create and use an Upsert Kafka table:
+
+<div class="codetabs" markdown="1">
+<div data-lang="SQL" markdown="1">
+{% highlight sql %}
+CREATE TABLE pageviews_per_region (
+ region STRING,
+ pv BIGINT,
+ uv BIGINT,
+ PRIMARY KEY region NOT ENFORCED
+) WITH (
+ 'connector' = 'upsert-kafka',
+ 'topic' = 'pageviews_per_region',
+ 'properties.bootstrap.servers' = '...',
+ 'key.format' = 'csv',
Review comment:
我会检查下的
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14017: [FLINK-19859][document] Add document for the upsert-kafka connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14017:
URL: https://github.com/apache/flink/pull/14017#issuecomment-724665676
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88a1f9ed960f7cf504645f3a430542aa9d8e5b77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9404",
"triggerID" : "88a1f9ed960f7cf504645f3a430542aa9d8e5b77",
"triggerType" : "PUSH"
}, {
"hash" : "ec1ba44a2c99309f8120a00beab017210e3c02ab",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9497",
"triggerID" : "ec1ba44a2c99309f8120a00beab017210e3c02ab",
"triggerType" : "PUSH"
}, {
"hash" : "6b9d7baf0cdbd007afef5d280c5297f039bb5d2b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9515",
"triggerID" : "6b9d7baf0cdbd007afef5d280c5297f039bb5d2b",
"triggerType" : "PUSH"
}, {
"hash" : "7dff1e172e3b99d819cfc1cbc1eedf71bea94626",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9548",
"triggerID" : "7dff1e172e3b99d819cfc1cbc1eedf71bea94626",
"triggerType" : "PUSH"
}, {
"hash" : "15e57df54d0395ec719f98e5330601f463c3e885",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "15e57df54d0395ec719f98e5330601f463c3e885",
"triggerType" : "PUSH"
}, {
"hash" : "37fd7800a63bdc4d1c9e4cc06a450f1faeebbc18",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "37fd7800a63bdc4d1c9e4cc06a450f1faeebbc18",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7dff1e172e3b99d819cfc1cbc1eedf71bea94626 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9548)
* 15e57df54d0395ec719f98e5330601f463c3e885 UNKNOWN
* 37fd7800a63bdc4d1c9e4cc06a450f1faeebbc18 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14017: [FLINK-19859][document] Add document for the upsert-kafka connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14017:
URL: https://github.com/apache/flink/pull/14017#issuecomment-724665676
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88a1f9ed960f7cf504645f3a430542aa9d8e5b77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9404",
"triggerID" : "88a1f9ed960f7cf504645f3a430542aa9d8e5b77",
"triggerType" : "PUSH"
}, {
"hash" : "ec1ba44a2c99309f8120a00beab017210e3c02ab",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9497",
"triggerID" : "ec1ba44a2c99309f8120a00beab017210e3c02ab",
"triggerType" : "PUSH"
}, {
"hash" : "6b9d7baf0cdbd007afef5d280c5297f039bb5d2b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9515",
"triggerID" : "6b9d7baf0cdbd007afef5d280c5297f039bb5d2b",
"triggerType" : "PUSH"
}, {
"hash" : "7dff1e172e3b99d819cfc1cbc1eedf71bea94626",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9548",
"triggerID" : "7dff1e172e3b99d819cfc1cbc1eedf71bea94626",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7dff1e172e3b99d819cfc1cbc1eedf71bea94626 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9548)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14017: [FLINK-19859][document] Add document for the upsert-kafka connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14017:
URL: https://github.com/apache/flink/pull/14017#issuecomment-724665676
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88a1f9ed960f7cf504645f3a430542aa9d8e5b77",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9404",
"triggerID" : "88a1f9ed960f7cf504645f3a430542aa9d8e5b77",
"triggerType" : "PUSH"
}, {
"hash" : "ec1ba44a2c99309f8120a00beab017210e3c02ab",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9497",
"triggerID" : "ec1ba44a2c99309f8120a00beab017210e3c02ab",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 88a1f9ed960f7cf504645f3a430542aa9d8e5b77 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9404)
* ec1ba44a2c99309f8120a00beab017210e3c02ab Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9497)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14017: [FLINK-19859][document] Add document for the upsert-kafka connector
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14017:
URL: https://github.com/apache/flink/pull/14017#issuecomment-724665676
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88a1f9ed960f7cf504645f3a430542aa9d8e5b77",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "88a1f9ed960f7cf504645f3a430542aa9d8e5b77",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 88a1f9ed960f7cf504645f3a430542aa9d8e5b77 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #14017: [FLINK-19859][document] Add document for the upsert-kafka connector
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #14017:
URL: https://github.com/apache/flink/pull/14017#discussion_r521826505
##########
File path: docs/dev/table/connectors/upsert-kafka.md
##########
@@ -0,0 +1,183 @@
+---
+title: "Apache Upsert Kafka SQL Connector"
Review comment:
"Upsert Kafka SQL Connector".
There is no "Upsert Kafka" in Apache projects...
##########
File path: docs/dev/table/connectors/upsert-kafka.md
##########
@@ -0,0 +1,183 @@
+---
+title: "Apache Upsert Kafka SQL Connector"
+nav-title: Upsert Kafka
+nav-parent_id: sql-connectors
+nav-pos: 2
+---
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<span class="label label-primary">Scan Source: Unbounded</span>
+<span class="label label-primary">Sink: Streaming Upsert Mode</span>
+
+* This will be replaced by the TOC
+{:toc}
+
+The Upsert Kafka connector allows for reading data from and writing data into Kafka topics in the upsert fashion.
+
+More precisely, the value part of the record is interpreted as an "UPDATE" of the last value for the same key.
+If the record doesn't exist yet, it will treat the record as an INSERT message. With the tombstone semantic in kafka,
+it will interpret the record whose value part is null as a DELETE message.
+
+
+Dependencies
+------------
+
+To use the connector, add the following Maven dependency to your project:
+{% highlight xml %}
+<dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-kafka_2.11</artifactId>
Review comment:
```suggestion
<artifactId>flink-connector-kafka_{{site.scala_version_suffix}}</artifactId>
```
##########
File path: docs/dev/table/connectors/upsert-kafka.md
##########
@@ -0,0 +1,183 @@
+---
+title: "Apache Upsert Kafka SQL Connector"
+nav-title: Upsert Kafka
+nav-parent_id: sql-connectors
+nav-pos: 2
+---
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<span class="label label-primary">Scan Source: Unbounded</span>
+<span class="label label-primary">Sink: Streaming Upsert Mode</span>
+
+* This will be replaced by the TOC
+{:toc}
+
+The Upsert Kafka connector allows for reading data from and writing data into Kafka topics in the upsert fashion.
+
+More precisely, the value part of the record is interpreted as an "UPDATE" of the last value for the same key.
+If the record doesn't exist yet, it will treat the record as an INSERT message. With the tombstone semantic in kafka,
+it will interpret the record whose value part is null as a DELETE message.
+
+
+Dependencies
+------------
+
+To use the connector, add the following Maven dependency to your project:
+{% highlight xml %}
+<dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-kafka_2.11</artifactId>
+ <version>1.12-SNAPSHOT</version>
+</dependency>
+{% endhighlight %}
+
+How to create an Upsert Kafka table
+----------------
+
+The example below shows how to create an Upsert Kafka table:
+
+<div class="codetabs" markdown="1">
+<div data-lang="SQL" markdown="1">
+{% highlight sql %}
+CREATE TABLE upsertKafkaTable (
+ user_id BIGINT,
+ item_id BIGINT,
+ category_id BIGINT,
+ behaviour STRING,
+ ts TIMESTAMP(3),
+ PRIMARY KEY (user_id) NOT ENFORCED
+) WITH (
+ 'connector' = 'upsert-kafka',
+ 'topic' = 'user_behaviour',
+ 'properties.bootstrap.servers' = 'localhost:9092',
+ 'key.format' = 'json',
+ 'value.format' = 'json',
+ 'value.fields-include' = 'ALL'
+)
+{% endhighlight %}
+</div>
+</div>
+
+<span class="label label-danger">Attention</span> Make sure to define the primary key in the ddl.
+
+Connector Options
+----------------
+
+<table class="table table-bordered">
+ <thead>
+ <tr>
+ <th class="text-left" style="width: 25%">Option</th>
+ <th class="text-center" style="width: 8%">Required</th>
+ <th class="text-center" style="width: 7%">Default</th>
+ <th class="text-center" style="width: 10%">Type</th>
+ <th class="text-center" style="width: 50%">Description</th>
+ </tr>
+ </thead>
+ <tbody>
+ <tr>
+ <td><h5>connector</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>Specify which connector to use, for the Upsert Kafka use: <code>'upsert-kafka'</code>.</td>
+ </tr>
+ <tr>
+ <td><h5>topic</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>Topic name to read from or write to when the table is used as source or sink.</td>
+ </tr>
+ <tr>
+ <td><h5>properties.bootstrap.servers</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>Comma separated list of Kafka brokers.</td>
+ </tr>
+ <tr>
+ <td><h5>key.format</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>The format used to deserialize and serialize the key part of the Kafka messages that is derived from the primary key.
+ The supported formats are <code>'csv'</code>, <code>'json'</code>, <code>'avro'</code>.
+ Please refer to <a href="{% link dev/table/connectors/formats/index.md %}">Formats</a> page for more details and more format options.
+ </td>
+ </tr>
+ <tr>
+ <td><h5>value.format</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>The format used to deserialize and serialize the value part of the Kafka messages.
+ The supported formats are <code>'csv'</code>, <code>'json'</code>, <code>'avro'</code>.
Review comment:
```suggestion
The supported formats include <code>'csv'</code>, <code>'json'</code>, <code>'avro'</code>.
```
##########
File path: docs/dev/table/connectors/upsert-kafka.md
##########
@@ -0,0 +1,183 @@
+---
+title: "Apache Upsert Kafka SQL Connector"
+nav-title: Upsert Kafka
+nav-parent_id: sql-connectors
+nav-pos: 2
+---
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<span class="label label-primary">Scan Source: Unbounded</span>
+<span class="label label-primary">Sink: Streaming Upsert Mode</span>
+
+* This will be replaced by the TOC
+{:toc}
+
+The Upsert Kafka connector allows for reading data from and writing data into Kafka topics in the upsert fashion.
+
+More precisely, the value part of the record is interpreted as an "UPDATE" of the last value for the same key.
+If the record doesn't exist yet, it will treat the record as an INSERT message. With the tombstone semantic in kafka,
+it will interpret the record whose value part is null as a DELETE message.
+
+
+Dependencies
+------------
+
+To use the connector, add the following Maven dependency to your project:
+{% highlight xml %}
+<dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-kafka_2.11</artifactId>
+ <version>1.12-SNAPSHOT</version>
+</dependency>
+{% endhighlight %}
+
+How to create an Upsert Kafka table
+----------------
+
+The example below shows how to create an Upsert Kafka table:
+
+<div class="codetabs" markdown="1">
+<div data-lang="SQL" markdown="1">
+{% highlight sql %}
+CREATE TABLE upsertKafkaTable (
+ user_id BIGINT,
+ item_id BIGINT,
+ category_id BIGINT,
+ behaviour STRING,
+ ts TIMESTAMP(3),
+ PRIMARY KEY (user_id) NOT ENFORCED
+) WITH (
+ 'connector' = 'upsert-kafka',
+ 'topic' = 'user_behaviour',
+ 'properties.bootstrap.servers' = 'localhost:9092',
+ 'key.format' = 'json',
+ 'value.format' = 'json',
+ 'value.fields-include' = 'ALL'
+)
+{% endhighlight %}
+</div>
+</div>
+
+<span class="label label-danger">Attention</span> Make sure to define the primary key in the ddl.
+
+Connector Options
+----------------
+
+<table class="table table-bordered">
+ <thead>
+ <tr>
+ <th class="text-left" style="width: 25%">Option</th>
+ <th class="text-center" style="width: 8%">Required</th>
+ <th class="text-center" style="width: 7%">Default</th>
+ <th class="text-center" style="width: 10%">Type</th>
+ <th class="text-center" style="width: 50%">Description</th>
+ </tr>
+ </thead>
+ <tbody>
+ <tr>
+ <td><h5>connector</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>Specify which connector to use, for the Upsert Kafka use: <code>'upsert-kafka'</code>.</td>
+ </tr>
+ <tr>
+ <td><h5>topic</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>Topic name to read from or write to when the table is used as source or sink.</td>
+ </tr>
+ <tr>
+ <td><h5>properties.bootstrap.servers</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>Comma separated list of Kafka brokers.</td>
+ </tr>
+ <tr>
+ <td><h5>key.format</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>The format used to deserialize and serialize the key part of the Kafka messages that is derived from the primary key.
+ The supported formats are <code>'csv'</code>, <code>'json'</code>, <code>'avro'</code>.
+ Please refer to <a href="{% link dev/table/connectors/formats/index.md %}">Formats</a> page for more details and more format options.
+ </td>
+ </tr>
+ <tr>
+ <td><h5>value.format</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>The format used to deserialize and serialize the value part of the Kafka messages.
+ The supported formats are <code>'csv'</code>, <code>'json'</code>, <code>'avro'</code>.
+ Please refer to <a href="{% link dev/table/connectors/formats/index.md %}">Formats</a> page for more details and more format options.
+ </td>
+ </tr>
+ <tr>
+ <td><h5>value.fields-include</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;"><code>'ALL'</code></td>
+ <td>String</td>
+ <td>Controls which field should end up in the value as well. Available value:
Review comment:
```suggestion
<td>Controls which fields should end up in the value as well. Available values:
```
##########
File path: docs/dev/table/connectors/upsert-kafka.md
##########
@@ -0,0 +1,183 @@
+---
+title: "Apache Upsert Kafka SQL Connector"
+nav-title: Upsert Kafka
+nav-parent_id: sql-connectors
+nav-pos: 2
+---
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<span class="label label-primary">Scan Source: Unbounded</span>
+<span class="label label-primary">Sink: Streaming Upsert Mode</span>
+
+* This will be replaced by the TOC
+{:toc}
+
+The Upsert Kafka connector allows for reading data from and writing data into Kafka topics in the upsert fashion.
+
+More precisely, the value part of the record is interpreted as an "UPDATE" of the last value for the same key.
+If the record doesn't exist yet, it will treat the record as an INSERT message. With the tombstone semantic in kafka,
+it will interpret the record whose value part is null as a DELETE message.
+
+
+Dependencies
+------------
+
+To use the connector, add the following Maven dependency to your project:
+{% highlight xml %}
+<dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-kafka_2.11</artifactId>
+ <version>1.12-SNAPSHOT</version>
+</dependency>
+{% endhighlight %}
+
+How to create an Upsert Kafka table
+----------------
+
+The example below shows how to create an Upsert Kafka table:
+
+<div class="codetabs" markdown="1">
+<div data-lang="SQL" markdown="1">
+{% highlight sql %}
+CREATE TABLE upsertKafkaTable (
+ user_id BIGINT,
+ item_id BIGINT,
+ category_id BIGINT,
+ behaviour STRING,
+ ts TIMESTAMP(3),
+ PRIMARY KEY (user_id) NOT ENFORCED
+) WITH (
+ 'connector' = 'upsert-kafka',
+ 'topic' = 'user_behaviour',
+ 'properties.bootstrap.servers' = 'localhost:9092',
+ 'key.format' = 'json',
+ 'value.format' = 'json',
+ 'value.fields-include' = 'ALL'
+)
+{% endhighlight %}
+</div>
+</div>
+
+<span class="label label-danger">Attention</span> Make sure to define the primary key in the ddl.
+
+Connector Options
+----------------
+
+<table class="table table-bordered">
+ <thead>
+ <tr>
+ <th class="text-left" style="width: 25%">Option</th>
+ <th class="text-center" style="width: 8%">Required</th>
+ <th class="text-center" style="width: 7%">Default</th>
+ <th class="text-center" style="width: 10%">Type</th>
+ <th class="text-center" style="width: 50%">Description</th>
+ </tr>
+ </thead>
+ <tbody>
+ <tr>
+ <td><h5>connector</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>Specify which connector to use, for the Upsert Kafka use: <code>'upsert-kafka'</code>.</td>
+ </tr>
+ <tr>
+ <td><h5>topic</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>Topic name to read from or write to when the table is used as source or sink.</td>
+ </tr>
+ <tr>
+ <td><h5>properties.bootstrap.servers</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>Comma separated list of Kafka brokers.</td>
+ </tr>
+ <tr>
+ <td><h5>key.format</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>The format used to deserialize and serialize the key part of the Kafka messages that is derived from the primary key.
+ The supported formats are <code>'csv'</code>, <code>'json'</code>, <code>'avro'</code>.
+ Please refer to <a href="{% link dev/table/connectors/formats/index.md %}">Formats</a> page for more details and more format options.
+ </td>
+ </tr>
+ <tr>
+ <td><h5>value.format</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>The format used to deserialize and serialize the value part of the Kafka messages.
+ The supported formats are <code>'csv'</code>, <code>'json'</code>, <code>'avro'</code>.
+ Please refer to <a href="{% link dev/table/connectors/formats/index.md %}">Formats</a> page for more details and more format options.
+ </td>
+ </tr>
+ <tr>
+ <td><h5>value.fields-include</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;"><code>'ALL'</code></td>
+ <td>String</td>
+ <td>Controls which field should end up in the value as well. Available value:
+ <ul>
+ <li><code>ALL</code>: the value part of the record contains all fields of the schema.</li>
+ <li><code>EXCEPT_KEY</code>: the value part of the record doesn't include primary key values.</li>
+ </ul>
+ </td>
+ </tr>
+ <tr>
+ <td><h5>sink.parallelism</h5></td>
+ <td>optional</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>Integer</td>
+ <td>Defines the parallelism of the Upsert kafka sink operator. By default, the parallelism is determined by the framework using the same parallelism of the upstream chained operator.</td>
+ </tr>
+ </tbody>
+</table>
+
+Features
+----------------
+
+### Primary Key Constraints
+
+The Upsert Kafka always works in the upsert fashion and requires to define the primary key in the ddl. With the assumption that records with the same key are ordered,
+the primary key semantic on the changelog source means the materialized changelog is unique on the primary keys. The primary key definition will also control
+which fields should end up in Kafka’s key.
+
+### Changelog Source
+
+When the Upsert Kafka works as the source, it produces the changelog stream from the topic. Generally speaking, the Upsert Kafka requires the topic is <a href="https://kafka.apache.org/documentation/#compaction"><code>'compacted'</code></a>
+and all data with the same key are in the same partition. To keep the data integrity, the Upsert Kafka disallows to specify the reading position, which means Upsert Kafka always uses the `earliest-offset`.
+
+### Changelog Sink
+
+The Upsert Kafka has the ability to keep the records with the same key into the same partition by <code>'HASH'</code> partitioner. At the same time, the upsert-kafka will
+always try their best to not send the UPDATE-BEFORE message to the storage comparing to the kafka with CDC format.
+
+### Consistency Guarantees
+
+By default, an Upsert Kafka sink ingests data with at-least-once guarantees into a Kafka topic if the query is executed with [checkpointing enabled]({% link dev/stream/state/checkpointing.md %}#enabling-and-configuring-checkpointing).
+
+With the at-least-once guarantees, it may get duplicate records but keep the order of the records. When the Upsert Kafka materializes the changelog, the duplicate records will
+not destroy of the final results. Therefore, at-least-once guarantees is enough.
Review comment:
```suggestion
This means, Flink may write duplicate records with the same key into the Kafka topic. But as the connector is working in the upsert mode, the last record on the same key will take effect when reading back as a source. Therefore, the upsert-kafka connector achieves idempotent writes just like the [HBase sink]({{ site.baseurl }}/dev/table/connectors/hbase.html).
```
##########
File path: docs/dev/table/connectors/upsert-kafka.md
##########
@@ -0,0 +1,183 @@
+---
+title: "Apache Upsert Kafka SQL Connector"
+nav-title: Upsert Kafka
+nav-parent_id: sql-connectors
+nav-pos: 2
+---
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<span class="label label-primary">Scan Source: Unbounded</span>
+<span class="label label-primary">Sink: Streaming Upsert Mode</span>
+
+* This will be replaced by the TOC
+{:toc}
+
+The Upsert Kafka connector allows for reading data from and writing data into Kafka topics in the upsert fashion.
+
+More precisely, the value part of the record is interpreted as an "UPDATE" of the last value for the same key.
+If the record doesn't exist yet, it will treat the record as an INSERT message. With the tombstone semantic in kafka,
+it will interpret the record whose value part is null as a DELETE message.
+
+
+Dependencies
+------------
+
+To use the connector, add the following Maven dependency to your project:
+{% highlight xml %}
+<dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-kafka_2.11</artifactId>
+ <version>1.12-SNAPSHOT</version>
+</dependency>
+{% endhighlight %}
+
+How to create an Upsert Kafka table
+----------------
+
+The example below shows how to create an Upsert Kafka table:
+
+<div class="codetabs" markdown="1">
+<div data-lang="SQL" markdown="1">
+{% highlight sql %}
+CREATE TABLE upsertKafkaTable (
+ user_id BIGINT,
+ item_id BIGINT,
+ category_id BIGINT,
+ behaviour STRING,
+ ts TIMESTAMP(3),
+ PRIMARY KEY (user_id) NOT ENFORCED
+) WITH (
+ 'connector' = 'upsert-kafka',
+ 'topic' = 'user_behaviour',
+ 'properties.bootstrap.servers' = 'localhost:9092',
+ 'key.format' = 'json',
+ 'value.format' = 'json',
+ 'value.fields-include' = 'ALL'
+)
+{% endhighlight %}
+</div>
+</div>
+
+<span class="label label-danger">Attention</span> Make sure to define the primary key in the ddl.
+
+Connector Options
+----------------
+
+<table class="table table-bordered">
+ <thead>
+ <tr>
+ <th class="text-left" style="width: 25%">Option</th>
+ <th class="text-center" style="width: 8%">Required</th>
+ <th class="text-center" style="width: 7%">Default</th>
+ <th class="text-center" style="width: 10%">Type</th>
+ <th class="text-center" style="width: 50%">Description</th>
+ </tr>
+ </thead>
+ <tbody>
+ <tr>
+ <td><h5>connector</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>Specify which connector to use, for the Upsert Kafka use: <code>'upsert-kafka'</code>.</td>
+ </tr>
+ <tr>
+ <td><h5>topic</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>Topic name to read from or write to when the table is used as source or sink.</td>
+ </tr>
+ <tr>
+ <td><h5>properties.bootstrap.servers</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>Comma separated list of Kafka brokers.</td>
+ </tr>
+ <tr>
+ <td><h5>key.format</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>The format used to deserialize and serialize the key part of the Kafka messages that is derived from the primary key.
+ The supported formats are <code>'csv'</code>, <code>'json'</code>, <code>'avro'</code>.
+ Please refer to <a href="{% link dev/table/connectors/formats/index.md %}">Formats</a> page for more details and more format options.
+ </td>
+ </tr>
+ <tr>
+ <td><h5>value.format</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>The format used to deserialize and serialize the value part of the Kafka messages.
+ The supported formats are <code>'csv'</code>, <code>'json'</code>, <code>'avro'</code>.
+ Please refer to <a href="{% link dev/table/connectors/formats/index.md %}">Formats</a> page for more details and more format options.
+ </td>
+ </tr>
+ <tr>
+ <td><h5>value.fields-include</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;"><code>'ALL'</code></td>
+ <td>String</td>
+ <td>Controls which field should end up in the value as well. Available value:
+ <ul>
+ <li><code>ALL</code>: the value part of the record contains all fields of the schema.</li>
+ <li><code>EXCEPT_KEY</code>: the value part of the record doesn't include primary key values.</li>
+ </ul>
+ </td>
+ </tr>
+ <tr>
+ <td><h5>sink.parallelism</h5></td>
+ <td>optional</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>Integer</td>
+ <td>Defines the parallelism of the Upsert kafka sink operator. By default, the parallelism is determined by the framework using the same parallelism of the upstream chained operator.</td>
Review comment:
```suggestion
<td>Defines the parallelism of the upsert-kafka sink operator. By default, the parallelism is determined by the framework using the same parallelism of the upstream chained operator.</td>
```
##########
File path: docs/dev/table/connectors/upsert-kafka.md
##########
@@ -0,0 +1,183 @@
+---
+title: "Apache Upsert Kafka SQL Connector"
+nav-title: Upsert Kafka
+nav-parent_id: sql-connectors
+nav-pos: 2
+---
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<span class="label label-primary">Scan Source: Unbounded</span>
+<span class="label label-primary">Sink: Streaming Upsert Mode</span>
+
+* This will be replaced by the TOC
+{:toc}
+
+The Upsert Kafka connector allows for reading data from and writing data into Kafka topics in the upsert fashion.
+
+More precisely, the value part of the record is interpreted as an "UPDATE" of the last value for the same key.
+If the record doesn't exist yet, it will treat the record as an INSERT message. With the tombstone semantic in kafka,
+it will interpret the record whose value part is null as a DELETE message.
Review comment:
The Upsert Kafka connector allows for reading data from and writing data into Kafka topics in the upsert fashion.
As a source, the upsert-kafka connector produces a changelog stream, where each data record represents an update or delete event. More precisely, the value in a data record is interpreted as an UPDATE of the last value for the same key, if any (if a corresponding key doesn’t exist yet, the update will be considered an INSERT). Using the table analogy, a data record in a changelog stream is interpreted as an UPSERT aka INSERT/UPDATE because any existing row with the same key is overwritten. Also, null values are interpreted in a special way: a record with a null value represents a “DELETE”.
As a sink, the upsert-kafka connector can consume a changelog stream. It will write INSERT/UPDATE_AFTER data as normal Kafka messages value, and write DELETE data as Kafka messages with null values (indicate tombstone for the key). Flink will guarantee the message ordering on the primary key by partition data on the values of the primary key columns, so the update/deletion messages on the same key will fall into the same partition.
##########
File path: docs/dev/table/connectors/upsert-kafka.md
##########
@@ -0,0 +1,183 @@
+---
+title: "Apache Upsert Kafka SQL Connector"
+nav-title: Upsert Kafka
+nav-parent_id: sql-connectors
+nav-pos: 2
+---
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<span class="label label-primary">Scan Source: Unbounded</span>
+<span class="label label-primary">Sink: Streaming Upsert Mode</span>
+
+* This will be replaced by the TOC
+{:toc}
+
+The Upsert Kafka connector allows for reading data from and writing data into Kafka topics in the upsert fashion.
+
+More precisely, the value part of the record is interpreted as an "UPDATE" of the last value for the same key.
+If the record doesn't exist yet, it will treat the record as an INSERT message. With the tombstone semantic in kafka,
+it will interpret the record whose value part is null as a DELETE message.
+
+
+Dependencies
+------------
+
+To use the connector, add the following Maven dependency to your project:
+{% highlight xml %}
+<dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-kafka_2.11</artifactId>
+ <version>1.12-SNAPSHOT</version>
+</dependency>
+{% endhighlight %}
+
+How to create an Upsert Kafka table
+----------------
+
+The example below shows how to create an Upsert Kafka table:
+
+<div class="codetabs" markdown="1">
+<div data-lang="SQL" markdown="1">
+{% highlight sql %}
+CREATE TABLE upsertKafkaTable (
+ user_id BIGINT,
+ item_id BIGINT,
+ category_id BIGINT,
+ behaviour STRING,
+ ts TIMESTAMP(3),
+ PRIMARY KEY (user_id) NOT ENFORCED
+) WITH (
+ 'connector' = 'upsert-kafka',
+ 'topic' = 'user_behaviour',
+ 'properties.bootstrap.servers' = 'localhost:9092',
+ 'key.format' = 'json',
+ 'value.format' = 'json',
+ 'value.fields-include' = 'ALL'
Review comment:
We don't need this as this is the default value.
##########
File path: docs/dev/table/connectors/upsert-kafka.md
##########
@@ -0,0 +1,183 @@
+---
+title: "Apache Upsert Kafka SQL Connector"
+nav-title: Upsert Kafka
+nav-parent_id: sql-connectors
+nav-pos: 2
+---
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<span class="label label-primary">Scan Source: Unbounded</span>
+<span class="label label-primary">Sink: Streaming Upsert Mode</span>
+
+* This will be replaced by the TOC
+{:toc}
+
+The Upsert Kafka connector allows for reading data from and writing data into Kafka topics in the upsert fashion.
+
+More precisely, the value part of the record is interpreted as an "UPDATE" of the last value for the same key.
+If the record doesn't exist yet, it will treat the record as an INSERT message. With the tombstone semantic in kafka,
+it will interpret the record whose value part is null as a DELETE message.
+
+
+Dependencies
+------------
+
+To use the connector, add the following Maven dependency to your project:
+{% highlight xml %}
+<dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-kafka_2.11</artifactId>
+ <version>1.12-SNAPSHOT</version>
+</dependency>
+{% endhighlight %}
+
+How to create an Upsert Kafka table
+----------------
+
+The example below shows how to create an Upsert Kafka table:
+
+<div class="codetabs" markdown="1">
+<div data-lang="SQL" markdown="1">
+{% highlight sql %}
+CREATE TABLE upsertKafkaTable (
+ user_id BIGINT,
+ item_id BIGINT,
+ category_id BIGINT,
+ behaviour STRING,
+ ts TIMESTAMP(3),
+ PRIMARY KEY (user_id) NOT ENFORCED
+) WITH (
+ 'connector' = 'upsert-kafka',
+ 'topic' = 'user_behaviour',
+ 'properties.bootstrap.servers' = 'localhost:9092',
+ 'key.format' = 'json',
+ 'value.format' = 'json',
+ 'value.fields-include' = 'ALL'
+)
+{% endhighlight %}
+</div>
+</div>
+
+<span class="label label-danger">Attention</span> Make sure to define the primary key in the ddl.
+
+Connector Options
+----------------
+
+<table class="table table-bordered">
+ <thead>
+ <tr>
+ <th class="text-left" style="width: 25%">Option</th>
+ <th class="text-center" style="width: 8%">Required</th>
+ <th class="text-center" style="width: 7%">Default</th>
+ <th class="text-center" style="width: 10%">Type</th>
+ <th class="text-center" style="width: 50%">Description</th>
+ </tr>
+ </thead>
+ <tbody>
+ <tr>
+ <td><h5>connector</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>Specify which connector to use, for the Upsert Kafka use: <code>'upsert-kafka'</code>.</td>
+ </tr>
+ <tr>
+ <td><h5>topic</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>Topic name to read from or write to when the table is used as source or sink.</td>
+ </tr>
+ <tr>
+ <td><h5>properties.bootstrap.servers</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>Comma separated list of Kafka brokers.</td>
+ </tr>
+ <tr>
+ <td><h5>key.format</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>The format used to deserialize and serialize the key part of the Kafka messages that is derived from the primary key.
+ The supported formats are <code>'csv'</code>, <code>'json'</code>, <code>'avro'</code>.
Review comment:
```suggestion
The supported formats include <code>'csv'</code>, <code>'json'</code>, <code>'avro'</code>.
```
##########
File path: docs/dev/table/connectors/upsert-kafka.md
##########
@@ -0,0 +1,183 @@
+---
+title: "Apache Upsert Kafka SQL Connector"
+nav-title: Upsert Kafka
+nav-parent_id: sql-connectors
+nav-pos: 2
+---
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<span class="label label-primary">Scan Source: Unbounded</span>
+<span class="label label-primary">Sink: Streaming Upsert Mode</span>
+
+* This will be replaced by the TOC
+{:toc}
+
+The Upsert Kafka connector allows for reading data from and writing data into Kafka topics in the upsert fashion.
+
+More precisely, the value part of the record is interpreted as an "UPDATE" of the last value for the same key.
+If the record doesn't exist yet, it will treat the record as an INSERT message. With the tombstone semantic in kafka,
+it will interpret the record whose value part is null as a DELETE message.
+
+
+Dependencies
+------------
+
+To use the connector, add the following Maven dependency to your project:
+{% highlight xml %}
+<dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-kafka_2.11</artifactId>
+ <version>1.12-SNAPSHOT</version>
+</dependency>
+{% endhighlight %}
+
+How to create an Upsert Kafka table
+----------------
+
+The example below shows how to create an Upsert Kafka table:
+
+<div class="codetabs" markdown="1">
+<div data-lang="SQL" markdown="1">
+{% highlight sql %}
+CREATE TABLE upsertKafkaTable (
+ user_id BIGINT,
+ item_id BIGINT,
+ category_id BIGINT,
+ behaviour STRING,
+ ts TIMESTAMP(3),
+ PRIMARY KEY (user_id) NOT ENFORCED
+) WITH (
+ 'connector' = 'upsert-kafka',
+ 'topic' = 'user_behaviour',
+ 'properties.bootstrap.servers' = 'localhost:9092',
+ 'key.format' = 'json',
+ 'value.format' = 'json',
+ 'value.fields-include' = 'ALL'
+)
Review comment:
Please add a more concreate example for how to insert an aggregation result into this upsert kafka table, and how to read from the upsert kafka table.
You can learn examples in [FLIP-149](https://cwiki.apache.org/confluence/display/FLINK/FLIP-149%3A+Introduce+the+upsert-kafka+Connector#FLIP149:IntroducetheupsertkafkaConnector-Examples) and [this doc](https://docs.ksqldb.io/en/latest/tutorials/examples/).
##########
File path: docs/dev/table/connectors/upsert-kafka.md
##########
@@ -0,0 +1,183 @@
+---
+title: "Apache Upsert Kafka SQL Connector"
+nav-title: Upsert Kafka
+nav-parent_id: sql-connectors
+nav-pos: 2
+---
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<span class="label label-primary">Scan Source: Unbounded</span>
+<span class="label label-primary">Sink: Streaming Upsert Mode</span>
+
+* This will be replaced by the TOC
+{:toc}
+
+The Upsert Kafka connector allows for reading data from and writing data into Kafka topics in the upsert fashion.
+
+More precisely, the value part of the record is interpreted as an "UPDATE" of the last value for the same key.
+If the record doesn't exist yet, it will treat the record as an INSERT message. With the tombstone semantic in kafka,
+it will interpret the record whose value part is null as a DELETE message.
+
+
+Dependencies
+------------
+
+To use the connector, add the following Maven dependency to your project:
+{% highlight xml %}
+<dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-kafka_2.11</artifactId>
+ <version>1.12-SNAPSHOT</version>
+</dependency>
+{% endhighlight %}
+
+How to create an Upsert Kafka table
+----------------
+
+The example below shows how to create an Upsert Kafka table:
+
+<div class="codetabs" markdown="1">
+<div data-lang="SQL" markdown="1">
+{% highlight sql %}
+CREATE TABLE upsertKafkaTable (
+ user_id BIGINT,
+ item_id BIGINT,
+ category_id BIGINT,
+ behaviour STRING,
+ ts TIMESTAMP(3),
+ PRIMARY KEY (user_id) NOT ENFORCED
+) WITH (
+ 'connector' = 'upsert-kafka',
+ 'topic' = 'user_behaviour',
+ 'properties.bootstrap.servers' = 'localhost:9092',
+ 'key.format' = 'json',
+ 'value.format' = 'json',
+ 'value.fields-include' = 'ALL'
+)
+{% endhighlight %}
+</div>
+</div>
+
+<span class="label label-danger">Attention</span> Make sure to define the primary key in the ddl.
+
+Connector Options
+----------------
+
+<table class="table table-bordered">
+ <thead>
+ <tr>
+ <th class="text-left" style="width: 25%">Option</th>
+ <th class="text-center" style="width: 8%">Required</th>
+ <th class="text-center" style="width: 7%">Default</th>
+ <th class="text-center" style="width: 10%">Type</th>
+ <th class="text-center" style="width: 50%">Description</th>
+ </tr>
+ </thead>
+ <tbody>
+ <tr>
+ <td><h5>connector</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>Specify which connector to use, for the Upsert Kafka use: <code>'upsert-kafka'</code>.</td>
+ </tr>
+ <tr>
+ <td><h5>topic</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>Topic name to read from or write to when the table is used as source or sink.</td>
+ </tr>
+ <tr>
+ <td><h5>properties.bootstrap.servers</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>Comma separated list of Kafka brokers.</td>
+ </tr>
+ <tr>
+ <td><h5>key.format</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>The format used to deserialize and serialize the key part of the Kafka messages that is derived from the primary key.
+ The supported formats are <code>'csv'</code>, <code>'json'</code>, <code>'avro'</code>.
+ Please refer to <a href="{% link dev/table/connectors/formats/index.md %}">Formats</a> page for more details and more format options.
+ </td>
+ </tr>
+ <tr>
+ <td><h5>value.format</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>The format used to deserialize and serialize the value part of the Kafka messages.
+ The supported formats are <code>'csv'</code>, <code>'json'</code>, <code>'avro'</code>.
+ Please refer to <a href="{% link dev/table/connectors/formats/index.md %}">Formats</a> page for more details and more format options.
+ </td>
+ </tr>
+ <tr>
+ <td><h5>value.fields-include</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;"><code>'ALL'</code></td>
+ <td>String</td>
+ <td>Controls which field should end up in the value as well. Available value:
+ <ul>
+ <li><code>ALL</code>: the value part of the record contains all fields of the schema.</li>
+ <li><code>EXCEPT_KEY</code>: the value part of the record doesn't include primary key values.</li>
Review comment:
```suggestion
<li><code>EXCEPT_KEY</code>: the value part of the record contains all fields of the schema except the key fields.</li>
```
##########
File path: docs/dev/table/connectors/upsert-kafka.md
##########
@@ -0,0 +1,183 @@
+---
+title: "Apache Upsert Kafka SQL Connector"
+nav-title: Upsert Kafka
+nav-parent_id: sql-connectors
+nav-pos: 2
+---
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<span class="label label-primary">Scan Source: Unbounded</span>
+<span class="label label-primary">Sink: Streaming Upsert Mode</span>
+
+* This will be replaced by the TOC
+{:toc}
+
+The Upsert Kafka connector allows for reading data from and writing data into Kafka topics in the upsert fashion.
+
+More precisely, the value part of the record is interpreted as an "UPDATE" of the last value for the same key.
+If the record doesn't exist yet, it will treat the record as an INSERT message. With the tombstone semantic in kafka,
+it will interpret the record whose value part is null as a DELETE message.
+
+
+Dependencies
+------------
+
+To use the connector, add the following Maven dependency to your project:
+{% highlight xml %}
+<dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-kafka_2.11</artifactId>
+ <version>1.12-SNAPSHOT</version>
+</dependency>
+{% endhighlight %}
+
+How to create an Upsert Kafka table
+----------------
+
+The example below shows how to create an Upsert Kafka table:
+
+<div class="codetabs" markdown="1">
+<div data-lang="SQL" markdown="1">
+{% highlight sql %}
+CREATE TABLE upsertKafkaTable (
+ user_id BIGINT,
+ item_id BIGINT,
+ category_id BIGINT,
+ behaviour STRING,
+ ts TIMESTAMP(3),
+ PRIMARY KEY (user_id) NOT ENFORCED
+) WITH (
+ 'connector' = 'upsert-kafka',
+ 'topic' = 'user_behaviour',
+ 'properties.bootstrap.servers' = 'localhost:9092',
+ 'key.format' = 'json',
+ 'value.format' = 'json',
+ 'value.fields-include' = 'ALL'
+)
+{% endhighlight %}
+</div>
+</div>
+
+<span class="label label-danger">Attention</span> Make sure to define the primary key in the ddl.
+
+Connector Options
+----------------
+
+<table class="table table-bordered">
+ <thead>
+ <tr>
+ <th class="text-left" style="width: 25%">Option</th>
+ <th class="text-center" style="width: 8%">Required</th>
+ <th class="text-center" style="width: 7%">Default</th>
+ <th class="text-center" style="width: 10%">Type</th>
+ <th class="text-center" style="width: 50%">Description</th>
+ </tr>
+ </thead>
+ <tbody>
+ <tr>
+ <td><h5>connector</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>Specify which connector to use, for the Upsert Kafka use: <code>'upsert-kafka'</code>.</td>
+ </tr>
+ <tr>
+ <td><h5>topic</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>Topic name to read from or write to when the table is used as source or sink.</td>
Review comment:
```suggestion
<td>The Kafka topic name to read from and write to.</td>
```
##########
File path: docs/dev/table/connectors/upsert-kafka.md
##########
@@ -0,0 +1,183 @@
+---
+title: "Apache Upsert Kafka SQL Connector"
+nav-title: Upsert Kafka
+nav-parent_id: sql-connectors
+nav-pos: 2
+---
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<span class="label label-primary">Scan Source: Unbounded</span>
+<span class="label label-primary">Sink: Streaming Upsert Mode</span>
+
+* This will be replaced by the TOC
+{:toc}
+
+The Upsert Kafka connector allows for reading data from and writing data into Kafka topics in the upsert fashion.
+
+More precisely, the value part of the record is interpreted as an "UPDATE" of the last value for the same key.
+If the record doesn't exist yet, it will treat the record as an INSERT message. With the tombstone semantic in kafka,
+it will interpret the record whose value part is null as a DELETE message.
+
+
+Dependencies
+------------
+
+To use the connector, add the following Maven dependency to your project:
+{% highlight xml %}
+<dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-kafka_2.11</artifactId>
+ <version>1.12-SNAPSHOT</version>
+</dependency>
+{% endhighlight %}
+
+How to create an Upsert Kafka table
+----------------
+
+The example below shows how to create an Upsert Kafka table:
+
+<div class="codetabs" markdown="1">
+<div data-lang="SQL" markdown="1">
+{% highlight sql %}
+CREATE TABLE upsertKafkaTable (
+ user_id BIGINT,
+ item_id BIGINT,
+ category_id BIGINT,
+ behaviour STRING,
+ ts TIMESTAMP(3),
+ PRIMARY KEY (user_id) NOT ENFORCED
+) WITH (
+ 'connector' = 'upsert-kafka',
+ 'topic' = 'user_behaviour',
+ 'properties.bootstrap.servers' = 'localhost:9092',
+ 'key.format' = 'json',
+ 'value.format' = 'json',
+ 'value.fields-include' = 'ALL'
+)
+{% endhighlight %}
+</div>
+</div>
+
+<span class="label label-danger">Attention</span> Make sure to define the primary key in the ddl.
+
+Connector Options
+----------------
+
+<table class="table table-bordered">
+ <thead>
+ <tr>
+ <th class="text-left" style="width: 25%">Option</th>
+ <th class="text-center" style="width: 8%">Required</th>
+ <th class="text-center" style="width: 7%">Default</th>
+ <th class="text-center" style="width: 10%">Type</th>
+ <th class="text-center" style="width: 50%">Description</th>
+ </tr>
+ </thead>
+ <tbody>
+ <tr>
+ <td><h5>connector</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>Specify which connector to use, for the Upsert Kafka use: <code>'upsert-kafka'</code>.</td>
+ </tr>
+ <tr>
+ <td><h5>topic</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>Topic name to read from or write to when the table is used as source or sink.</td>
+ </tr>
+ <tr>
+ <td><h5>properties.bootstrap.servers</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>Comma separated list of Kafka brokers.</td>
+ </tr>
+ <tr>
+ <td><h5>key.format</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>The format used to deserialize and serialize the key part of the Kafka messages that is derived from the primary key.
Review comment:
```suggestion
<td>The format used to deserialize and serialize the key part of the Kafka messages. The key part fields are specified by the PRIMARY KEY syntax.
```
##########
File path: docs/dev/table/connectors/upsert-kafka.md
##########
@@ -0,0 +1,183 @@
+---
+title: "Apache Upsert Kafka SQL Connector"
+nav-title: Upsert Kafka
+nav-parent_id: sql-connectors
+nav-pos: 2
+---
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<span class="label label-primary">Scan Source: Unbounded</span>
+<span class="label label-primary">Sink: Streaming Upsert Mode</span>
+
+* This will be replaced by the TOC
+{:toc}
+
+The Upsert Kafka connector allows for reading data from and writing data into Kafka topics in the upsert fashion.
+
+More precisely, the value part of the record is interpreted as an "UPDATE" of the last value for the same key.
+If the record doesn't exist yet, it will treat the record as an INSERT message. With the tombstone semantic in kafka,
+it will interpret the record whose value part is null as a DELETE message.
+
+
+Dependencies
+------------
+
+To use the connector, add the following Maven dependency to your project:
+{% highlight xml %}
+<dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-kafka_2.11</artifactId>
+ <version>1.12-SNAPSHOT</version>
+</dependency>
+{% endhighlight %}
+
+How to create an Upsert Kafka table
+----------------
+
+The example below shows how to create an Upsert Kafka table:
+
+<div class="codetabs" markdown="1">
+<div data-lang="SQL" markdown="1">
+{% highlight sql %}
+CREATE TABLE upsertKafkaTable (
+ user_id BIGINT,
+ item_id BIGINT,
+ category_id BIGINT,
+ behaviour STRING,
+ ts TIMESTAMP(3),
+ PRIMARY KEY (user_id) NOT ENFORCED
+) WITH (
+ 'connector' = 'upsert-kafka',
+ 'topic' = 'user_behaviour',
+ 'properties.bootstrap.servers' = 'localhost:9092',
+ 'key.format' = 'json',
+ 'value.format' = 'json',
+ 'value.fields-include' = 'ALL'
+)
+{% endhighlight %}
+</div>
+</div>
+
+<span class="label label-danger">Attention</span> Make sure to define the primary key in the ddl.
+
+Connector Options
+----------------
+
+<table class="table table-bordered">
+ <thead>
+ <tr>
+ <th class="text-left" style="width: 25%">Option</th>
+ <th class="text-center" style="width: 8%">Required</th>
+ <th class="text-center" style="width: 7%">Default</th>
+ <th class="text-center" style="width: 10%">Type</th>
+ <th class="text-center" style="width: 50%">Description</th>
+ </tr>
+ </thead>
+ <tbody>
+ <tr>
+ <td><h5>connector</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>Specify which connector to use, for the Upsert Kafka use: <code>'upsert-kafka'</code>.</td>
+ </tr>
+ <tr>
+ <td><h5>topic</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>Topic name to read from or write to when the table is used as source or sink.</td>
+ </tr>
+ <tr>
+ <td><h5>properties.bootstrap.servers</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>Comma separated list of Kafka brokers.</td>
+ </tr>
+ <tr>
+ <td><h5>key.format</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>The format used to deserialize and serialize the key part of the Kafka messages that is derived from the primary key.
+ The supported formats are <code>'csv'</code>, <code>'json'</code>, <code>'avro'</code>.
+ Please refer to <a href="{% link dev/table/connectors/formats/index.md %}">Formats</a> page for more details and more format options.
+ </td>
+ </tr>
+ <tr>
+ <td><h5>value.format</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>The format used to deserialize and serialize the value part of the Kafka messages.
+ The supported formats are <code>'csv'</code>, <code>'json'</code>, <code>'avro'</code>.
+ Please refer to <a href="{% link dev/table/connectors/formats/index.md %}">Formats</a> page for more details and more format options.
+ </td>
+ </tr>
+ <tr>
+ <td><h5>value.fields-include</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;"><code>'ALL'</code></td>
+ <td>String</td>
+ <td>Controls which field should end up in the value as well. Available value:
+ <ul>
+ <li><code>ALL</code>: the value part of the record contains all fields of the schema.</li>
Review comment:
```suggestion
<li><code>ALL</code>: the value part of the record contains all fields of the schema, even if they are part of the key.</li>
```
##########
File path: docs/dev/table/connectors/upsert-kafka.md
##########
@@ -0,0 +1,183 @@
+---
+title: "Apache Upsert Kafka SQL Connector"
+nav-title: Upsert Kafka
+nav-parent_id: sql-connectors
+nav-pos: 2
+---
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<span class="label label-primary">Scan Source: Unbounded</span>
+<span class="label label-primary">Sink: Streaming Upsert Mode</span>
+
+* This will be replaced by the TOC
+{:toc}
+
+The Upsert Kafka connector allows for reading data from and writing data into Kafka topics in the upsert fashion.
+
+More precisely, the value part of the record is interpreted as an "UPDATE" of the last value for the same key.
+If the record doesn't exist yet, it will treat the record as an INSERT message. With the tombstone semantic in kafka,
+it will interpret the record whose value part is null as a DELETE message.
+
+
+Dependencies
+------------
+
+To use the connector, add the following Maven dependency to your project:
+{% highlight xml %}
+<dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-kafka_2.11</artifactId>
+ <version>1.12-SNAPSHOT</version>
+</dependency>
+{% endhighlight %}
Review comment:
```
In order to setup the upsert-kafka connector, the following table provide dependency information for both projects using a build automation tool (such as Maven or SBT) and SQL Client with SQL JAR bundles.
| Kafka Version | Maven dependency | SQL Client JAR |
| :------------------ | :-------------------------------------------------------- | :----------------------|
| universal | `flink-connector-kafka{{site.scala_version_suffix}}` | {% if site.is_stable %} [Download](https://repo.maven.apache.org/maven2/org/apache/flink/flink-sql-connector-kafka{{site.scala_version_suffix}}/{{site.version}}/flink-sql-connector-kafka{{site.scala_version_suffix}}-{{site.version}}.jar) {% else %} Only available for [stable releases]({{ site.stable_baseurl }}/dev/table/connectors/upsert-kafka.html) {% endif %}|
```
1. add SQL CLI JAR
2. use variables instead of hard code the version.
##########
File path: docs/dev/table/connectors/upsert-kafka.md
##########
@@ -0,0 +1,183 @@
+---
+title: "Apache Upsert Kafka SQL Connector"
+nav-title: Upsert Kafka
+nav-parent_id: sql-connectors
+nav-pos: 2
+---
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<span class="label label-primary">Scan Source: Unbounded</span>
+<span class="label label-primary">Sink: Streaming Upsert Mode</span>
+
+* This will be replaced by the TOC
+{:toc}
+
+The Upsert Kafka connector allows for reading data from and writing data into Kafka topics in the upsert fashion.
+
+More precisely, the value part of the record is interpreted as an "UPDATE" of the last value for the same key.
+If the record doesn't exist yet, it will treat the record as an INSERT message. With the tombstone semantic in kafka,
+it will interpret the record whose value part is null as a DELETE message.
+
+
+Dependencies
+------------
+
+To use the connector, add the following Maven dependency to your project:
+{% highlight xml %}
+<dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-kafka_2.11</artifactId>
+ <version>1.12-SNAPSHOT</version>
+</dependency>
+{% endhighlight %}
+
+How to create an Upsert Kafka table
+----------------
+
+The example below shows how to create an Upsert Kafka table:
+
+<div class="codetabs" markdown="1">
+<div data-lang="SQL" markdown="1">
+{% highlight sql %}
+CREATE TABLE upsertKafkaTable (
+ user_id BIGINT,
+ item_id BIGINT,
+ category_id BIGINT,
+ behaviour STRING,
+ ts TIMESTAMP(3),
+ PRIMARY KEY (user_id) NOT ENFORCED
+) WITH (
+ 'connector' = 'upsert-kafka',
+ 'topic' = 'user_behaviour',
+ 'properties.bootstrap.servers' = 'localhost:9092',
+ 'key.format' = 'json',
+ 'value.format' = 'json',
+ 'value.fields-include' = 'ALL'
+)
+{% endhighlight %}
+</div>
+</div>
+
+<span class="label label-danger">Attention</span> Make sure to define the primary key in the ddl.
+
+Connector Options
+----------------
+
+<table class="table table-bordered">
+ <thead>
+ <tr>
+ <th class="text-left" style="width: 25%">Option</th>
+ <th class="text-center" style="width: 8%">Required</th>
+ <th class="text-center" style="width: 7%">Default</th>
+ <th class="text-center" style="width: 10%">Type</th>
+ <th class="text-center" style="width: 50%">Description</th>
+ </tr>
+ </thead>
+ <tbody>
+ <tr>
+ <td><h5>connector</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>Specify which connector to use, for the Upsert Kafka use: <code>'upsert-kafka'</code>.</td>
+ </tr>
+ <tr>
+ <td><h5>topic</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>Topic name to read from or write to when the table is used as source or sink.</td>
+ </tr>
+ <tr>
+ <td><h5>properties.bootstrap.servers</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>Comma separated list of Kafka brokers.</td>
+ </tr>
+ <tr>
+ <td><h5>key.format</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>The format used to deserialize and serialize the key part of the Kafka messages that is derived from the primary key.
+ The supported formats are <code>'csv'</code>, <code>'json'</code>, <code>'avro'</code>.
+ Please refer to <a href="{% link dev/table/connectors/formats/index.md %}">Formats</a> page for more details and more format options.
+ </td>
+ </tr>
+ <tr>
+ <td><h5>value.format</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>The format used to deserialize and serialize the value part of the Kafka messages.
+ The supported formats are <code>'csv'</code>, <code>'json'</code>, <code>'avro'</code>.
+ Please refer to <a href="{% link dev/table/connectors/formats/index.md %}">Formats</a> page for more details and more format options.
+ </td>
+ </tr>
+ <tr>
+ <td><h5>value.fields-include</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;"><code>'ALL'</code></td>
+ <td>String</td>
+ <td>Controls which field should end up in the value as well. Available value:
+ <ul>
+ <li><code>ALL</code>: the value part of the record contains all fields of the schema.</li>
+ <li><code>EXCEPT_KEY</code>: the value part of the record doesn't include primary key values.</li>
+ </ul>
+ </td>
+ </tr>
+ <tr>
+ <td><h5>sink.parallelism</h5></td>
+ <td>optional</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>Integer</td>
+ <td>Defines the parallelism of the Upsert kafka sink operator. By default, the parallelism is determined by the framework using the same parallelism of the upstream chained operator.</td>
+ </tr>
+ </tbody>
+</table>
+
+Features
+----------------
+
+### Primary Key Constraints
+
+The Upsert Kafka always works in the upsert fashion and requires to define the primary key in the ddl. With the assumption that records with the same key are ordered,
Review comment:
```suggestion
The Upsert Kafka always works in the upsert fashion and requires to define the primary key in the DDL. With the assumption that records with the same key should be ordered in the same partition,
```
##########
File path: docs/dev/table/connectors/upsert-kafka.md
##########
@@ -0,0 +1,183 @@
+---
+title: "Apache Upsert Kafka SQL Connector"
+nav-title: Upsert Kafka
+nav-parent_id: sql-connectors
+nav-pos: 2
+---
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<span class="label label-primary">Scan Source: Unbounded</span>
+<span class="label label-primary">Sink: Streaming Upsert Mode</span>
+
+* This will be replaced by the TOC
+{:toc}
+
+The Upsert Kafka connector allows for reading data from and writing data into Kafka topics in the upsert fashion.
+
+More precisely, the value part of the record is interpreted as an "UPDATE" of the last value for the same key.
+If the record doesn't exist yet, it will treat the record as an INSERT message. With the tombstone semantic in kafka,
+it will interpret the record whose value part is null as a DELETE message.
+
+
+Dependencies
+------------
+
+To use the connector, add the following Maven dependency to your project:
+{% highlight xml %}
+<dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-kafka_2.11</artifactId>
+ <version>1.12-SNAPSHOT</version>
+</dependency>
+{% endhighlight %}
+
+How to create an Upsert Kafka table
+----------------
+
+The example below shows how to create an Upsert Kafka table:
+
+<div class="codetabs" markdown="1">
+<div data-lang="SQL" markdown="1">
+{% highlight sql %}
+CREATE TABLE upsertKafkaTable (
+ user_id BIGINT,
+ item_id BIGINT,
+ category_id BIGINT,
+ behaviour STRING,
+ ts TIMESTAMP(3),
+ PRIMARY KEY (user_id) NOT ENFORCED
+) WITH (
+ 'connector' = 'upsert-kafka',
+ 'topic' = 'user_behaviour',
+ 'properties.bootstrap.servers' = 'localhost:9092',
+ 'key.format' = 'json',
+ 'value.format' = 'json',
+ 'value.fields-include' = 'ALL'
+)
+{% endhighlight %}
+</div>
+</div>
+
+<span class="label label-danger">Attention</span> Make sure to define the primary key in the ddl.
+
+Connector Options
+----------------
+
+<table class="table table-bordered">
+ <thead>
+ <tr>
+ <th class="text-left" style="width: 25%">Option</th>
+ <th class="text-center" style="width: 8%">Required</th>
+ <th class="text-center" style="width: 7%">Default</th>
+ <th class="text-center" style="width: 10%">Type</th>
+ <th class="text-center" style="width: 50%">Description</th>
+ </tr>
+ </thead>
+ <tbody>
+ <tr>
+ <td><h5>connector</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>Specify which connector to use, for the Upsert Kafka use: <code>'upsert-kafka'</code>.</td>
+ </tr>
+ <tr>
+ <td><h5>topic</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>Topic name to read from or write to when the table is used as source or sink.</td>
+ </tr>
+ <tr>
+ <td><h5>properties.bootstrap.servers</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>Comma separated list of Kafka brokers.</td>
+ </tr>
+ <tr>
+ <td><h5>key.format</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>The format used to deserialize and serialize the key part of the Kafka messages that is derived from the primary key.
+ The supported formats are <code>'csv'</code>, <code>'json'</code>, <code>'avro'</code>.
+ Please refer to <a href="{% link dev/table/connectors/formats/index.md %}">Formats</a> page for more details and more format options.
+ </td>
+ </tr>
+ <tr>
+ <td><h5>value.format</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>The format used to deserialize and serialize the value part of the Kafka messages.
+ The supported formats are <code>'csv'</code>, <code>'json'</code>, <code>'avro'</code>.
+ Please refer to <a href="{% link dev/table/connectors/formats/index.md %}">Formats</a> page for more details and more format options.
+ </td>
+ </tr>
+ <tr>
+ <td><h5>value.fields-include</h5></td>
+ <td>required</td>
+ <td style="word-wrap: break-word;"><code>'ALL'</code></td>
+ <td>String</td>
+ <td>Controls which field should end up in the value as well. Available value:
+ <ul>
+ <li><code>ALL</code>: the value part of the record contains all fields of the schema.</li>
+ <li><code>EXCEPT_KEY</code>: the value part of the record doesn't include primary key values.</li>
+ </ul>
+ </td>
+ </tr>
+ <tr>
+ <td><h5>sink.parallelism</h5></td>
+ <td>optional</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>Integer</td>
+ <td>Defines the parallelism of the Upsert kafka sink operator. By default, the parallelism is determined by the framework using the same parallelism of the upstream chained operator.</td>
+ </tr>
+ </tbody>
+</table>
+
+Features
+----------------
+
+### Primary Key Constraints
+
+The Upsert Kafka always works in the upsert fashion and requires to define the primary key in the ddl. With the assumption that records with the same key are ordered,
+the primary key semantic on the changelog source means the materialized changelog is unique on the primary keys. The primary key definition will also control
+which fields should end up in Kafka’s key.
+
+### Changelog Source
+
+When the Upsert Kafka works as the source, it produces the changelog stream from the topic. Generally speaking, the Upsert Kafka requires the topic is <a href="https://kafka.apache.org/documentation/#compaction"><code>'compacted'</code></a>
+and all data with the same key are in the same partition. To keep the data integrity, the Upsert Kafka disallows to specify the reading position, which means Upsert Kafka always uses the `earliest-offset`.
+
+### Changelog Sink
+
+The Upsert Kafka has the ability to keep the records with the same key into the same partition by <code>'HASH'</code> partitioner. At the same time, the upsert-kafka will
+always try their best to not send the UPDATE-BEFORE message to the storage comparing to the kafka with CDC format.
Review comment:
We have moved these part to the top.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14017: [FLINK-19859][document] Add document for the upsert-kafka connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14017:
URL: https://github.com/apache/flink/pull/14017#issuecomment-724665676
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88a1f9ed960f7cf504645f3a430542aa9d8e5b77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9404",
"triggerID" : "88a1f9ed960f7cf504645f3a430542aa9d8e5b77",
"triggerType" : "PUSH"
}, {
"hash" : "ec1ba44a2c99309f8120a00beab017210e3c02ab",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9497",
"triggerID" : "ec1ba44a2c99309f8120a00beab017210e3c02ab",
"triggerType" : "PUSH"
}, {
"hash" : "6b9d7baf0cdbd007afef5d280c5297f039bb5d2b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9515",
"triggerID" : "6b9d7baf0cdbd007afef5d280c5297f039bb5d2b",
"triggerType" : "PUSH"
}, {
"hash" : "7dff1e172e3b99d819cfc1cbc1eedf71bea94626",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9548",
"triggerID" : "7dff1e172e3b99d819cfc1cbc1eedf71bea94626",
"triggerType" : "PUSH"
}, {
"hash" : "15e57df54d0395ec719f98e5330601f463c3e885",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "15e57df54d0395ec719f98e5330601f463c3e885",
"triggerType" : "PUSH"
}, {
"hash" : "37fd7800a63bdc4d1c9e4cc06a450f1faeebbc18",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9620",
"triggerID" : "37fd7800a63bdc4d1c9e4cc06a450f1faeebbc18",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 15e57df54d0395ec719f98e5330601f463c3e885 UNKNOWN
* 37fd7800a63bdc4d1c9e4cc06a450f1faeebbc18 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9620)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14017: [FLINK-19859][document] Add document for the upsert-kafka connector
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14017:
URL: https://github.com/apache/flink/pull/14017#issuecomment-724657835
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 88a1f9ed960f7cf504645f3a430542aa9d8e5b77 (Tue Nov 10 12:01:19 UTC 2020)
**Warnings:**
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-19859).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14017: [FLINK-19859][document] Add document for the upsert-kafka connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14017:
URL: https://github.com/apache/flink/pull/14017#issuecomment-724665676
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88a1f9ed960f7cf504645f3a430542aa9d8e5b77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9404",
"triggerID" : "88a1f9ed960f7cf504645f3a430542aa9d8e5b77",
"triggerType" : "PUSH"
}, {
"hash" : "ec1ba44a2c99309f8120a00beab017210e3c02ab",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9497",
"triggerID" : "ec1ba44a2c99309f8120a00beab017210e3c02ab",
"triggerType" : "PUSH"
}, {
"hash" : "6b9d7baf0cdbd007afef5d280c5297f039bb5d2b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9515",
"triggerID" : "6b9d7baf0cdbd007afef5d280c5297f039bb5d2b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6b9d7baf0cdbd007afef5d280c5297f039bb5d2b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9515)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14017: [FLINK-19859][document] Add document for the upsert-kafka connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14017:
URL: https://github.com/apache/flink/pull/14017#issuecomment-724665676
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88a1f9ed960f7cf504645f3a430542aa9d8e5b77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9404",
"triggerID" : "88a1f9ed960f7cf504645f3a430542aa9d8e5b77",
"triggerType" : "PUSH"
}, {
"hash" : "ec1ba44a2c99309f8120a00beab017210e3c02ab",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9497",
"triggerID" : "ec1ba44a2c99309f8120a00beab017210e3c02ab",
"triggerType" : "PUSH"
}, {
"hash" : "6b9d7baf0cdbd007afef5d280c5297f039bb5d2b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9515",
"triggerID" : "6b9d7baf0cdbd007afef5d280c5297f039bb5d2b",
"triggerType" : "PUSH"
}, {
"hash" : "7dff1e172e3b99d819cfc1cbc1eedf71bea94626",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7dff1e172e3b99d819cfc1cbc1eedf71bea94626",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6b9d7baf0cdbd007afef5d280c5297f039bb5d2b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9515)
* 7dff1e172e3b99d819cfc1cbc1eedf71bea94626 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org