You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "Yingyi Bu (Code Review)" <do...@asterixdb.incubator.apache.org> on 2016/06/03 18:17:52 UTC
Change in asterixdb[master]: ASTERIXDB-1189: add a test case to verify the fix.
Yingyi Bu has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/904
Change subject: ASTERIXDB-1189: add a test case to verify the fix.
......................................................................
ASTERIXDB-1189: add a test case to verify the fix.
Change-Id: If16017dbf6cb4e80d86c6ded359cee81dde6c67c
---
A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/null-missing/spatial-intersect/spatial-intersect.1.query.sqlpp
A asterixdb/asterix-app/src/test/resources/runtimets/results/null-missing/spatial-intersect/spatial-intersect.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
3 files changed, 34 insertions(+), 0 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/04/904/1
diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/null-missing/spatial-intersect/spatial-intersect.1.query.sqlpp b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/null-missing/spatial-intersect/spatial-intersect.1.query.sqlpp
new file mode 100644
index 0000000..3be21de
--- /dev/null
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/null-missing/spatial-intersect/spatial-intersect.1.query.sqlpp
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+{
+ 'null1': "spatial-intersect"(null, "create-rectangle"("create-point"(30.0,70.0), "create-point"(40.0,80.0))),
+ 'null2': "spatial-intersect"("create-rectangle"("create-point"(30.0,70.0), "create-point"(40.0,80.0)), null),
+ 'missing1': "spatial-intersect"(missing, "create-rectangle"("create-point"(30.0,70.0), "create-point"(40.0,80.0))),
+ 'missing2': "spatial-intersect"("create-rectangle"("create-point"(30.0,70.0), "create-point"(40.0,80.0)), missing),
+ 'missing2': "spatial-intersect"(missing, null),
+ 'missing2': "spatial-intersect"(null, missing),
+ 'missing2': "spatial-intersect"(missing, missing)
+};
diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/results/null-missing/spatial-intersect/spatial-intersect.1.adm b/asterixdb/asterix-app/src/test/resources/runtimets/results/null-missing/spatial-intersect/spatial-intersect.1.adm
new file mode 100644
index 0000000..d9f875f
--- /dev/null
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/results/null-missing/spatial-intersect/spatial-intersect.1.adm
@@ -0,0 +1 @@
+{ "null1": null, "null2": null }
diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
index 3080027..569e011 100644
--- a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
@@ -3624,6 +3624,11 @@
</compilation-unit>
</test-case>
<test-case FilePath="null-missing">
+ <compilation-unit name="spatial-intersect">
+ <output-dir compare="Text">spatial-intersect</output-dir>
+ </compilation-unit>
+ </test-case>
+ <test-case FilePath="null-missing">
<compilation-unit name="substr">
<output-dir compare="Text">substr</output-dir>
</compilation-unit>
--
To view, visit https://asterix-gerrit.ics.uci.edu/904
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If16017dbf6cb4e80d86c6ded359cee81dde6c67c
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <bu...@gmail.com>
Change in asterixdb[master]: ASTERIXDB-1189: add a test case to verify the fix.
Posted by "Jianfeng Jia (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jianfeng Jia has posted comments on this change.
Change subject: ASTERIXDB-1189: add a test case to verify the fix.
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://asterix-gerrit.ics.uci.edu/904
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If16017dbf6cb4e80d86c6ded359cee81dde6c67c
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <bu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Jianfeng Jia <ji...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1189: add a test case to verify the fix.
Posted by "Yingyi Bu (Code Review)" <do...@asterixdb.incubator.apache.org>.
Yingyi Bu has posted comments on this change.
Change subject: ASTERIXDB-1189: add a test case to verify the fix.
......................................................................
Patch Set 1: -Code-Review
--
To view, visit https://asterix-gerrit.ics.uci.edu/904
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If16017dbf6cb4e80d86c6ded359cee81dde6c67c
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <bu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Jianfeng Jia <ji...@gmail.com>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1189: add a test case to verify the fix.
Posted by "Yingyi Bu (Code Review)" <do...@asterixdb.incubator.apache.org>.
Yingyi Bu has submitted this change and it was merged.
Change subject: ASTERIXDB-1189: add a test case to verify the fix.
......................................................................
ASTERIXDB-1189: add a test case to verify the fix.
Change-Id: If16017dbf6cb4e80d86c6ded359cee81dde6c67c
Reviewed-on: https://asterix-gerrit.ics.uci.edu/904
Reviewed-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Jianfeng Jia <ji...@gmail.com>
---
A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/null-missing/spatial-intersect/spatial-intersect.1.query.sqlpp
A asterixdb/asterix-app/src/test/resources/runtimets/results/null-missing/spatial-intersect/spatial-intersect.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
3 files changed, 34 insertions(+), 0 deletions(-)
Approvals:
Jianfeng Jia: Looks good to me, approved
Jenkins: Looks good to me, but someone else must approve; Verified
diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/null-missing/spatial-intersect/spatial-intersect.1.query.sqlpp b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/null-missing/spatial-intersect/spatial-intersect.1.query.sqlpp
new file mode 100644
index 0000000..3be21de
--- /dev/null
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/null-missing/spatial-intersect/spatial-intersect.1.query.sqlpp
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+{
+ 'null1': "spatial-intersect"(null, "create-rectangle"("create-point"(30.0,70.0), "create-point"(40.0,80.0))),
+ 'null2': "spatial-intersect"("create-rectangle"("create-point"(30.0,70.0), "create-point"(40.0,80.0)), null),
+ 'missing1': "spatial-intersect"(missing, "create-rectangle"("create-point"(30.0,70.0), "create-point"(40.0,80.0))),
+ 'missing2': "spatial-intersect"("create-rectangle"("create-point"(30.0,70.0), "create-point"(40.0,80.0)), missing),
+ 'missing2': "spatial-intersect"(missing, null),
+ 'missing2': "spatial-intersect"(null, missing),
+ 'missing2': "spatial-intersect"(missing, missing)
+};
diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/results/null-missing/spatial-intersect/spatial-intersect.1.adm b/asterixdb/asterix-app/src/test/resources/runtimets/results/null-missing/spatial-intersect/spatial-intersect.1.adm
new file mode 100644
index 0000000..d9f875f
--- /dev/null
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/results/null-missing/spatial-intersect/spatial-intersect.1.adm
@@ -0,0 +1 @@
+{ "null1": null, "null2": null }
diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
index 3080027..569e011 100644
--- a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
@@ -3624,6 +3624,11 @@
</compilation-unit>
</test-case>
<test-case FilePath="null-missing">
+ <compilation-unit name="spatial-intersect">
+ <output-dir compare="Text">spatial-intersect</output-dir>
+ </compilation-unit>
+ </test-case>
+ <test-case FilePath="null-missing">
<compilation-unit name="substr">
<output-dir compare="Text">substr</output-dir>
</compilation-unit>
--
To view, visit https://asterix-gerrit.ics.uci.edu/904
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If16017dbf6cb4e80d86c6ded359cee81dde6c67c
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <bu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Jianfeng Jia <ji...@gmail.com>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Change in asterixdb[master]: ASTERIXDB-1189: add a test case to verify the fix.
Posted by "Yingyi Bu (Code Review)" <do...@asterixdb.incubator.apache.org>.
Yingyi Bu has posted comments on this change.
Change subject: ASTERIXDB-1189: add a test case to verify the fix.
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://asterix-gerrit.ics.uci.edu/904
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If16017dbf6cb4e80d86c6ded359cee81dde6c67c
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <bu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Jianfeng Jia <ji...@gmail.com>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1189: add a test case to verify the fix.
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1189: add a test case to verify the fix.
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1577/
--
To view, visit https://asterix-gerrit.ics.uci.edu/904
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If16017dbf6cb4e80d86c6ded359cee81dde6c67c
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <bu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No