[GitHub] [spark] gaborgsomogyi commented on a change in pull request #24627: [SPARK-27748][SS] Kafka consumer/producer password/token redaction.

[GitBox <gi...@apache.org>]

gaborgsomogyi commented on a change in pull request #24627: [SPARK-27748][SS] Kafka consumer/producer password/token redaction.
URL: https://github.com/apache/spark/pull/24627#discussion_r284754193
 
 

 ##########
 File path: external/kafka-0-10-token-provider/src/main/scala/org/apache/spark/kafka010/KafkaTokenUtil.scala
 ##########
 @@ -193,7 +194,7 @@ private[spark] object KafkaTokenUtil extends Logging {
       | debug=${isGlobalKrbDebugEnabled()}
       | useTicketCache=true
       | serviceName="${clusterConf.kerberosServiceName}";
-      """.stripMargin.replace("\n", "")
+      """.stripMargin.replace("\n", "").trim
 
 Review comment:
   This is unrelated fix. There were additional spaces at the end of the generated string. This change removes it. Worth to mention the code works both way but thought it's just ugly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org