You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Mike Kienenberger (JIRA)" <de...@myfaces.apache.org> on 2013/08/30 14:09:52 UTC

[jira] [Comment Edited] (MYFACES-3768) FacesMessage Severity ordinal values are not consistent with Mojarra RI

    [ https://issues.apache.org/jira/browse/MYFACES-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13754625#comment-13754625 ] 

Mike Kienenberger edited comment on MYFACES-3768 at 8/30/13 12:08 PM:
----------------------------------------------------------------------

While it would be nice to be consistent with Mojarra, it is not a necessity as you should not be using hard-coded ordinal values.

Second, we cannot change this on a minor point release as this will break existing applications.   An app server container which upgraded to a version of Myfaces with different ordinal values would break all existing applications.

I'm going to change the affects-version to 2.2, and increase the priority to blocker since, if this is changed, the change should be made before the first 2.2 release.    If someone else feels that we should simply leave the ordinal values as they are, please change this to wont-fix as I don't feel strongly about fixing it.

                
      was (Author: mkienenb):
    While it would be nice to be consistent with Mojarra, it is not a necessity as you should not be using hard-coded ordinal values.

Second, we cannot change this on a minor point release as this will break existing applications.   An app server container which upgraded to a version of Myfaces with different ordinal values would break all existing applications.

I'm going to change the fix-version to 2.2, and increase the priority to blocker since, if this is changed, the change should be made before the first 2.2 release.    If someone else feels that we should simply leave the ordinal values as they are, please change this to wont-fix as I don't feel strongly about fixing it.

                  
> FacesMessage Severity ordinal values are not consistent with Mojarra RI
> -----------------------------------------------------------------------
>
>                 Key: MYFACES-3768
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3768
>             Project: MyFaces Core
>          Issue Type: Improvement
>    Affects Versions: 2.2.0
>            Reporter: John Yeary
>            Priority: Blocker
>
> The ordinal values for the Severity levels in Mojarra use values starting from 0 while MyFaces uses values starting from 1. This results in inconsistent behavior between implementations. I suggest aligning the values starting with 0 since this is consistent with general programming expectations.
> Mojarra
>  
> INFO(0), WARN(1), ERROR(2), and FATAL(3)
> MyFaces
> INFO(1), WARN(2), ERROR(3), and FATAL(4)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira