You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2022/04/06 01:08:36 UTC
[GitHub] [phoenix-connectors] chrajeshbabu opened a new pull request, #73: PHOENIX-6683 Surround the OR filters with parentheses while convertin…
chrajeshbabu opened a new pull request, #73:
URL: https://github.com/apache/phoenix-connectors/pull/73
…g spark filters to phoenix expessions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] chrajeshbabu merged pull request #73: PHOENIX-6683 Surround the OR filters with parentheses while convertin…
Posted by GitBox <gi...@apache.org>.
chrajeshbabu merged PR #73:
URL: https://github.com/apache/phoenix-connectors/pull/73
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] stoty commented on pull request #73: PHOENIX-6683 Surround the OR filters with parentheses while convertin…
Posted by GitBox <gi...@apache.org>.
stoty commented on PR #73:
URL: https://github.com/apache/phoenix-connectors/pull/73#issuecomment-1089724285
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 5m 24s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 34m 27s | master passed |
| +1 :green_heart: | compile | 1m 39s | master passed |
| +1 :green_heart: | checkstyle | 0m 12s | master passed |
| +1 :green_heart: | javadoc | 0m 21s | master passed |
| +1 :green_heart: | scaladoc | 1m 8s | master passed |
| +0 :ok: | spotbugs | 2m 36s | phoenix-spark-base in master has 40 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 19m 19s | the patch passed |
| +1 :green_heart: | compile | 1m 40s | the patch passed |
| +1 :green_heart: | javac | 1m 40s | the patch passed |
| +1 :green_heart: | scalac | 1m 40s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 13s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 21s | the patch passed |
| +1 :green_heart: | scaladoc | 1m 4s | the patch passed |
| +1 :green_heart: | spotbugs | 2m 24s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 47m 17s | phoenix-spark-base in the patch failed. |
| -1 :x: | asflicense | 0m 11s | The patch generated 2 ASF License warnings. |
| | | 118m 59s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-73/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix-connectors/pull/73 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile scalac scaladoc |
| uname | Linux bde5fc1c7773 4.15.0-169-generic #177-Ubuntu SMP Thu Feb 3 10:50:38 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-connectors-personality.sh |
| git revision | master / 0d7b3c4 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-73/1/artifact/yetus-general-check/output/patch-unit-phoenix-spark-base.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-73/1/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-73/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 1676 (vs. ulimit of 30000) |
| modules | C: phoenix-spark-base U: phoenix-spark-base |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-73/1/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] chrajeshbabu commented on pull request #73: PHOENIX-6683 Surround the OR filters with parentheses while convertin…
Posted by GitBox <gi...@apache.org>.
chrajeshbabu commented on PR #73:
URL: https://github.com/apache/phoenix-connectors/pull/73#issuecomment-1090085553
> Please add the same fixes for the Spark3 connector.
Sure will do that Istvan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] stoty commented on pull request #73: PHOENIX-6683 Surround the OR filters with parentheses while convertin…
Posted by GitBox <gi...@apache.org>.
stoty commented on PR #73:
URL: https://github.com/apache/phoenix-connectors/pull/73#issuecomment-1089894057
I haven't looked into the logic closely.
Do we process the parentheses correctly ?
i.e.
Make sure that we do not turn
(a and b or c) into (a and (b or c))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] chrajeshbabu commented on pull request #73: PHOENIX-6683 Surround the OR filters with parentheses while convertin…
Posted by GitBox <gi...@apache.org>.
chrajeshbabu commented on PR #73:
URL: https://github.com/apache/phoenix-connectors/pull/73#issuecomment-1090085221
> I haven't looked into the logic closely. Do we process the parentheses correctly ?
>
> i.e. Make sure that we do not turn
>
> (a and b or c) into (a and (b or c))
Yes this is not happening and AND is getting precedence. Just added another test case to ensure that..
45336 [main] DEBUG org.apache.phoenix.execute.BaseQueryPlan - Iterator for table N000001 ready: resultIterators=ResultIterators [name=PARALLEL,id=5337088f-cf25-3568-ad24-630b5fd8c07f,scans=[[{"loadColumnFamiliesOnDemand":true,"filter":"**((\"ENTITY_INSTANCE_ID\" = 40 AND \"CASE_MATCH_TYPE\" = 'M') OR NOT (\"CANCELLATION_FLAG\" = 'Y'))"**,"startRow":"","stopRow":"","batch":-1,"cacheBlocks":true,"totalColumns":3,"maxResultSize":-1,"families":{"0":["\\x00\\x00\\x00\\x00","\\x80\\x0B","\\x80\\x0C"]},"caching":2147483647,"maxVersions":1,"timeRange":[0,9223372036854775807]}]]], index=0]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org