[GitHub] [arrow-datafusion] Jefffrey commented on a diff in pull request #5153: Ambiguity check for where selection

["Jefffrey (via GitHub)" <gi...@apache.org>]

Jefffrey commented on code in PR #5153:
URL: https://github.com/apache/arrow-datafusion/pull/5153#discussion_r1097850070


##########
datafusion/sql/tests/integration_test.rs:
##########
@@ -527,6 +527,16 @@ fn join_with_ambiguous_column() {
     quick_test(sql, expected);
 }
 
+#[test]
+fn where_selection_with_ambiguous_column() {
+    let sql = "SELECT * FROM person a, person b WHERE id = id + 1";
+    let err = logical_plan(sql).expect_err("query should have failed");
+    assert_eq!(
+        "Internal(\"column reference id is ambiguous\")",

Review Comment:
   no problem, fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org