You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2026/09/30 00:43:34 UTC
[PR] [fix][broker] Align entry filter policy checks for non-persistent topics [pulsar]
lhotari opened a new pull request, #26774:
URL: https://github.com/apache/pulsar/pull/26774
### Motivation
The topic-level entry filter endpoints in `PersistentTopics` check the `ENTRY_FILTERS` topic policy operation (`READ` for get, `WRITE` for set and remove) before handling the request. The `NonPersistentTopics` overrides of these endpoints skip that check, so the same operations are handled differently depending on the topic domain.
### Modifications
- In `NonPersistentTopics`, run `validateTopicPolicyOperationAsync` with `PolicyName.ENTRY_FILTERS` before the get (`READ`), set (`WRITE`) and remove (`WRITE`) entry filter operations, matching `PersistentTopics`.
- Parameterize the entry filter tests in `TopicAuthZTest` to cover both `persistent` and `non-persistent` topics, and also check the get operation with `applied=true`.
With this change, a caller that is not permitted the `ENTRY_FILTERS` policy operation receives `403 Not Authorized` for these non-persistent topic endpoints, as it already does for persistent topics.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change added tests and can be verified as follows:
- `TopicAuthZTest.testGetEntryFilter`, `testSetEntryFilter` and `testRemoveEntryFilter` now run for both `persistent` and `non-persistent` topics.
### Does this pull request potentially affect one of the following parts:
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [x] The REST endpoints: non-persistent topic entry filter endpoints now check the `ENTRY_FILTERS` topic policy operation
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][broker] Align entry filter policy checks for non-persistent topics [pulsar]
Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece merged PR #26774:
URL: https://github.com/apache/pulsar/pull/26774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org