You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/10/12 16:09:00 UTC
[jira] [Work logged] (ARTEMIS-3525) Empty Auto created queues
should be removed right away
[ https://issues.apache.org/jira/browse/ARTEMIS-3525?focusedWorklogId=664150&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-664150 ]
ASF GitHub Bot logged work on ARTEMIS-3525:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Oct/21 16:08
Start Date: 12/Oct/21 16:08
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on a change in pull request #3791:
URL: https://github.com/apache/activemq-artemis/pull/3791#discussion_r727290971
##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
##########
@@ -1855,12 +1857,16 @@ private static boolean queueWasUsed(Queue queue) {
/** To be used by the AddressQueueReaper.
* It is also exposed for tests through PostOfficeTestAccessor */
- void reapAddresses() {
+ void reapAddresses(boolean initialCheck) {
getLocalQueues().forEach(queue -> {
- if (!queue.isInternalQueue() && QueueManagerImpl.isAutoDelete(queue) && QueueManagerImpl.consumerCountCheck(queue) && QueueManagerImpl.delayCheck(queue) && QueueManagerImpl.messageCountCheck(queue) && queueWasUsed(queue)) {
- if (queue.isSwept()) {
+ if (!queue.isInternalQueue() && QueueManagerImpl.isAutoDelete(queue) && QueueManagerImpl.consumerCountCheck(queue) && QueueManagerImpl.delayCheck(queue) && QueueManagerImpl.messageCountCheck(queue) && (queueWasUsed(queue) || initialCheck)) {
Review comment:
doing my own review here, I should ignore the delayCheck upon restart
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 664150)
Remaining Estimate: 0h
Time Spent: 10m
> Empty Auto created queues should be removed right away
> ------------------------------------------------------
>
> Key: ARTEMIS-3525
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3525
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Clebert Suconic
> Priority: Major
> Fix For: 2.20.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> this is a borderline between a bug and an improvement.
> The broker should check for empty auto-created queues upon restart. Empty auto-created queues should be removed right away.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)