[GitHub] [spark] stczwd commented on a change in pull request #35653: [SPARK-38318][SQL] Skip view cyclic reference check if view is stored as logical plan

[GitBox <gi...@apache.org>]

stczwd commented on a change in pull request #35653:
URL: https://github.com/apache/spark/pull/35653#discussion_r816400053



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala
##########
@@ -614,7 +614,11 @@ object ViewHelper extends SQLConfHelper with Logging {
     }.getOrElse(false)
     if (replace && uncache) {
       logDebug(s"Try to uncache ${name.quotedString} before replacing.")
-      checkCyclicViewReference(analyzedPlan, Seq(name), name)

Review comment:
       > We don't support recursive view for view created by SQL DDL, but we DO support this for view created by dataset API.
   
   Ah, I see, thanks for the explanation.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org