You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2022/08/14 13:01:23 UTC
[GitHub] [thrift] TianMaiChengGhostRidder opened a new pull request, #2641: Update thrift_socket_transport.erl
TianMaiChengGhostRidder opened a new pull request, #2641:
URL: https://github.com/apache/thrift/pull/2641
如果传送的数据量大的时候就会报错。
<!-- Explain the changes in the pull request below: -->
<!-- We recommend you review the checklist/tips before submitting a pull request. -->
- [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [ ] Did you squash your changes to a single commit? (not required, but preferred)
- [ ] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] TianMaiChengGhostRidder commented on pull request #2641: Update thrift_socket_transport.erl
Posted by GitBox <gi...@apache.org>.
TianMaiChengGhostRidder commented on PR #2641:
URL: https://github.com/apache/thrift/pull/2641#issuecomment-1227966249
The error is marked in the above picture. Please note that it is not my error, but the Erlang library error. You can modify it according to my screenshot. This is machine translated English. It is estimated that the semantics are a bit wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] TianMaiChengGhostRidder commented on pull request #2641: Update thrift_socket_transport.erl
Posted by GitBox <gi...@apache.org>.
TianMaiChengGhostRidder commented on PR #2641:
URL: https://github.com/apache/thrift/pull/2641#issuecomment-1230093410
I have pointed out the mistake
Why is the master branch of Erlang library not updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] TianMaiChengGhostRidder commented on pull request #2641: Update thrift_socket_transport.erl
Posted by GitBox <gi...@apache.org>.
TianMaiChengGhostRidder commented on PR #2641:
URL: https://github.com/apache/thrift/pull/2641#issuecomment-1214371390
如果传送的数据量很小，不会出错。如果传送的数量大的时候就会出错。
代码修改后，传送大量数据就不会出错了。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2641: Update thrift_socket_transport.erl
Posted by GitBox <gi...@apache.org>.
Jens-G commented on PR #2641:
URL: https://github.com/apache/thrift/pull/2641#issuecomment-1221521086
Can we have that in english please? Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2641: Update thrift_socket_transport.erl
Posted by GitBox <gi...@apache.org>.
Jens-G commented on PR #2641:
URL: https://github.com/apache/thrift/pull/2641#issuecomment-1227748478
May I ask what error you get specifically?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G merged pull request #2641: Update thrift_socket_transport.erl
Posted by GitBox <gi...@apache.org>.
Jens-G merged PR #2641:
URL: https://github.com/apache/thrift/pull/2641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] TianMaiChengGhostRidder commented on pull request #2641: Update thrift_socket_transport.erl
Posted by GitBox <gi...@apache.org>.
TianMaiChengGhostRidder commented on PR #2641:
URL: https://github.com/apache/thrift/pull/2641#issuecomment-1226845856
If we transmit a large amount of data, we will make an error. It should be modified to the following code:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2641: Update thrift_socket_transport.erl
Posted by GitBox <gi...@apache.org>.
Jens-G commented on PR #2641:
URL: https://github.com/apache/thrift/pull/2641#issuecomment-1230965934
> Why is the master branch of Erlang library not updated
Because nobody did it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G closed pull request #2641: Update thrift_socket_transport.erl
Posted by GitBox <gi...@apache.org>.
Jens-G closed pull request #2641: Update thrift_socket_transport.erl
URL: https://github.com/apache/thrift/pull/2641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org