You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/09/01 14:35:08 UTC

[GitHub] [lucene] msokolov opened a new pull request #274: LUCENE-10082: add detail to schema inconsistency error messages

msokolov opened a new pull request #274:
URL: https://github.com/apache/lucene/pull/274


   Adds details about which indexing "feature" was inconsistent to the exception thrown when IndexingChain discovers inconsistent field types.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] msokolov closed pull request #274: LUCENE-10082: add detail to schema inconsistency error messages

Posted by GitBox <gi...@apache.org>.
msokolov closed pull request #274:
URL: https://github.com/apache/lucene/pull/274


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] msokolov commented on pull request #274: LUCENE-10082: add detail to schema inconsistency error messages

Posted by GitBox <gi...@apache.org>.
msokolov commented on pull request #274:
URL: https://github.com/apache/lucene/pull/274#issuecomment-910885711


   I pushed from command line after simplifying the `assertSame` API.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] jpountz commented on pull request #274: LUCENE-10082: add detail to schema inconsistency error messages

Posted by GitBox <gi...@apache.org>.
jpountz commented on pull request #274:
URL: https://github.com/apache/lucene/pull/274#issuecomment-915171475


   Indexing rate and GC/JIT times look stable. :+1:


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] msokolov commented on pull request #274: LUCENE-10082: add detail to schema inconsistency error messages

Posted by GitBox <gi...@apache.org>.
msokolov commented on pull request #274:
URL: https://github.com/apache/lucene/pull/274#issuecomment-915314874


   Yes, looks OK. Note I also did add some overloads to avoid autoboxing, so I
   think mostly we didn't add any. May not have been needed.
   
   On Wed, Sep 8, 2021 at 7:59 AM Adrien Grand ***@***.***>
   wrote:
   
   > Indexing rate and GC/JIT times look stable. 👍
   >
   > —
   > You are receiving this because you modified the open/close state.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/lucene/pull/274#issuecomment-915171475>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAHHUQP74236VPUVLS3PG5LUA5F2DANCNFSM5DGUIEFA>
   > .
   > Triage notifications on the go with GitHub Mobile for iOS
   > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
   > or Android
   > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
   >
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] jpountz commented on a change in pull request #274: LUCENE-10082: add detail to schema inconsistency error messages

Posted by GitBox <gi...@apache.org>.
jpountz commented on a change in pull request #274:
URL: https://github.com/apache/lucene/pull/274#discussion_r700374187



##########
File path: lucene/core/src/java/org/apache/lucene/index/IndexingChain.java
##########
@@ -1336,9 +1336,21 @@ public void recycleIntBlocks(int[][] blocks, int offset, int length) {
       this.name = name;
     }
 
-    private void assertSame(boolean same) {
+    private void assertSame(String label, boolean same, Object expected, Object given) {

Review comment:
       It looks like we don't even need `same` and could compute it by doing `Objects.equals(expected, given)`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] jpountz commented on pull request #274: LUCENE-10082: add detail to schema inconsistency error messages

Posted by GitBox <gi...@apache.org>.
jpountz commented on pull request #274:
URL: https://github.com/apache/lucene/pull/274#issuecomment-911267974


   Let's watch nightly benchmarks over the next few days in case this additional autoboxing causes any slowdown.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] msokolov commented on a change in pull request #274: LUCENE-10082: add detail to schema inconsistency error messages

Posted by GitBox <gi...@apache.org>.
msokolov commented on a change in pull request #274:
URL: https://github.com/apache/lucene/pull/274#discussion_r700482986



##########
File path: lucene/core/src/java/org/apache/lucene/index/IndexingChain.java
##########
@@ -1336,9 +1336,21 @@ public void recycleIntBlocks(int[][] blocks, int offset, int length) {
       this.name = name;
     }
 
-    private void assertSame(boolean same) {
+    private void assertSame(String label, boolean same, Object expected, Object given) {

Review comment:
       That's true - I guess I was trying to avoid autoboxing, calling equals() on the objects, but maybe `Objects.equals()` handles that in a nice way for primitives?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org