[jira] [Commented] (OOZIE-926) handling of global configuration is not correct

["Alejandro Abdelnur (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422710#comment-13422710 ] 

Alejandro Abdelnur commented on OOZIE-926:
------------------------------------------

It seems a better approach, to do this would be:

{code}
if (!ACTION XML has job-tracker)
  if (GLOBAL XML has job-tracker)
    add GLOBAL XML job-tracker to ACTION XML
  else 
    FAIL
if (!ACTION XML has name-node)
  if (GLOBAL XML has name-node)
    add GLOBAL XML name-node to ACTION XML
  else 
    FAIL
if (GLOBAL XML has job-xml elements)
  prepend job-xml elements from GLOBAL XML to ACTION XML and discard duplicates
if (GLOBAL XML has configuration)
  prepend configuration from GLOBAL XML to ACTION XML configuration and discard duplicates (by property name)
{code}

All this logic should be done not using indexes of the elements as comments will change all index positions.



                
> handling of global configuration is not correct
> -----------------------------------------------
>
>                 Key: OOZIE-926
>                 URL: https://issues.apache.org/jira/browse/OOZIE-926
>             Project: Oozie
>          Issue Type: Bug
>          Components: workflow
>    Affects Versions: trunk
>            Reporter: Alejandro Abdelnur
>            Priority: Blocker
>             Fix For: trunk
>
>
> Global configuration should have <job-xml> elements (0..unbound)
> The current logic augments the actions JDOM elements at parsing time in the handleGlobals() method.
> This method is not handling the case of more than 1 <job-xml> in the action.
> If there are comments in the WF XML the indexes will be off.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira