You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/10/25 10:04:26 UTC

[GitHub] [calcite] cndaimin opened a new pull request #1531: [CALCITE-3447]Fix `equals` and `hashcode` methods of class `MutableScan`

cndaimin opened a new pull request #1531: [CALCITE-3447]Fix `equals` and `hashcode` methods of class `MutableScan`
URL: https://github.com/apache/calcite/pull/1531
 
 
   Code segment here depends on `hashcode` and `equals` methods of class `MutableRel`:
   
   https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/plan/SubstitutionVisitor.java#L492-L502 
   
   However the implementations of class `MutableScan` delegates to class `TableScan`, which directly relies on implementations of class `Object`. This leads to a situation that two `MutableScan` on the exactly same table will not be considered as equivalent.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services