You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@orc.apache.org by do...@apache.org on 2023/01/07 04:50:42 UTC

[orc] branch branch-1.8 updated: ORC-1345: Use `makeBom` and skip snapshot check in GitHub Action `publish_snapshot` job

This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch branch-1.8
in repository https://gitbox.apache.org/repos/asf/orc.git


The following commit(s) were added to refs/heads/branch-1.8 by this push:
     new aa1b0f0f4 ORC-1345: Use `makeBom` and skip snapshot check in GitHub Action `publish_snapshot` job
aa1b0f0f4 is described below

commit aa1b0f0f42b8e75daec1b0b4f5aba25baa4a306a
Author: Dongjoon Hyun <do...@apache.org>
AuthorDate: Fri Jan 6 20:44:52 2023 -0800

    ORC-1345: Use `makeBom` and skip snapshot check in GitHub Action `publish_snapshot` job
    
    ### What changes were proposed in this pull request?
    
    This PR aims to improve GitHub Action `publish_snapshot` job by using `makeBom` and skipping checking snapshot versions. In addition, the download transfer progress is also disabled to reduce the log size.
    
    ### Why are the changes needed?
    
    `publish_snapshot` is always generating new set of snapshot files.
    
    ### How was this patch tested?
    
    Manual review. This should be verified after merging.
    
    https://github.com/apache/orc/blob/eee67e192017ee78fa89061ffc8a013c0daf14c7/.github/workflows/publish_snapshot.yml#L3-L6
    
    Closes #1355 from dongjoon-hyun/ORC-1345.
    
    Authored-by: Dongjoon Hyun <do...@apache.org>
    Signed-off-by: Dongjoon Hyun <do...@apache.org>
    (cherry picked from commit 93b76cbc297b230e1950d21d4edf4b305b0e9255)
    Signed-off-by: Dongjoon Hyun <do...@apache.org>
---
 .github/workflows/publish_snapshot.yml | 2 +-
 java/pom.xml                           | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/publish_snapshot.yml b/.github/workflows/publish_snapshot.yml
index 1aaadec79..a7570492a 100644
--- a/.github/workflows/publish_snapshot.yml
+++ b/.github/workflows/publish_snapshot.yml
@@ -23,4 +23,4 @@ jobs:
       run: |
         cd java
         echo "<settings><servers><server><id>apache.snapshots.https</id><username>$ASF_USERNAME</username><password>$ASF_PASSWORD</password></server></servers></settings>" > settings.xml
-        ./mvnw --settings settings.xml -DskipTests deploy
+        ./mvnw --settings settings.xml -nsu -ntp -DskipTests deploy
diff --git a/java/pom.xml b/java/pom.xml
index ce0db6235..ca9da2161 100644
--- a/java/pom.xml
+++ b/java/pom.xml
@@ -273,7 +273,7 @@
           <execution>
             <phase>package</phase>
             <goals>
-              <goal>makeAggregateBom</goal>
+              <goal>makeBom</goal>
             </goals>
           </execution>
         </executions>