You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "walterddr (via GitHub)" <gi...@apache.org> on 2023/09/25 17:26:15 UTC
[GitHub] [pinot] walterddr opened a new issue, #11677: [multistage] MV validator issues
walterddr opened a new issue, #11677:
URL: https://github.com/apache/pinot/issues/11677
several MV validator issues are found
---
exception is not thrown
---
```
explain plan for
select MAXMV(a.mv) from a join b on a.id = b.id limit 10
```
returns
```
Execution Plan
LogicalSort(fetch=[10])
PinotLogicalSortExchange(distribution=[hash], collation=[[]], isSortOnSender=[false], isSortOnReceiver=[false])
LogicalAggregate(group=[{}], agg#0=[MAXMV($0)])
PinotLogicalExchange(distribution=[hash])
LogicalAggregate(group=[{}], agg#0=[MAXMV($1)])
LogicalJoin(condition=[=($0, $2)], joinType=[inner])
PinotLogicalExchange(distribution=[hash[0]])
LogicalProject(id=[$6], mv=[$7])
LogicalTableScan(table=[[a]])
PinotLogicalExchange(distribution=[hash[0]])
LogicalProject(id=[$6])
LogicalTableScan(table=[[b]])
```
but it should failed on MAXMV($1) aggregate b/c it is not supported
---
wrong exception is thrown NO.1
---
```
explain plan for
select MAX(arrayToMv(a.mv)) from a join b on a.id = b.id limit 10
```
seems to throw the exception:
```
Function 'ArrayToMv' is not supported in PROJECT Leaf Stage
org.apache.pinot.query.planner.validation.ArrayToMvValidationVisitor.visitProject(ArrayToMvValidationVisitor.java:99)
org.apache.pinot.query.planner.validation.ArrayToMvValidationVisitor.visitProject(ArrayToMvValidationVisitor.java:43)
org.apache.pinot.query.planner.plannode.ProjectNode.visit(ProjectNode.java:54)
org.apache.pinot.query.planner.validation.ArrayToMvValidationVisitor.lambda$visitMailboxSend$3(ArrayToMvValidationVisitor.java:72)
```
but it is not suppose to be after PROJECT pushdown:
```
Execution Plan
LogicalSort(fetch=[10])
PinotLogicalSortExchange(distribution=[hash], collation=[[]], isSortOnSender=[false], isSortOnReceiver=[false])
LogicalAggregate(group=[{}], agg#0=[MAX($0)])
PinotLogicalExchange(distribution=[hash])
LogicalAggregate(group=[{}], agg#0=[MAX($1)])
LogicalJoin(condition=[=($0, $2)], joinType=[inner])
PinotLogicalExchange(distribution=[hash[0]])
LogicalProject(id=[$6], $f0=[ARRAYTOMV($7)])
LogicalTableScan(table=[[a]])
PinotLogicalExchange(distribution=[hash[0]])
LogicalProject(id=[$6])
LogicalTableScan(table=[[b]])
```
---
wrong exception is thrown NO.2
---
```
explain plan for
select /*+ joinOptions(join_strategy = 'dynamic_broadcast') */
MAX(arrayToMv(a.label_ids))
from github_2 a
where a.id IN (select id FROM github_events b)
```
generates the following plan
```
LogicalAggregate(group=[{}], agg#0=[MAX($0)])
PinotLogicalExchange(distribution=[hash])
LogicalAggregate(group=[{}], agg#0=[MAX($1)])
PinotLogicalExchange(distribution=[hash[0]])
LogicalJoin(condition=[=($0, $8)], joinType=[semi])
LogicalProject(id=[$6], $f0=[ARRAYTOMV($7)])
LogicalTableScan(table=[[a]])
PinotLogicalExchange(distribution=[broadcast], relExchangeType=[PIPELINE_BREAKER])
LogicalTableScan(table=[[b]])
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] [multistage][bug] MV validator issues on new engine [pinot]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #11677:
URL: https://github.com/apache/pinot/issues/11677#issuecomment-5723097206
This issue has been automatically marked as stale because it has not had any activity in the last 150 days. It will be closed in 30 days if no further activity occurs. If this issue is still relevant, please leave a comment to keep it open. Thank you for your contributions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] [multistage][bug] MV validator issues on new engine [pinot]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #11677: [multistage][bug] MV validator issues on new engine
URL: https://github.com/apache/pinot/issues/11677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] [multistage][bug] MV validator issues on new engine [pinot]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #11677:
URL: https://github.com/apache/pinot/issues/11677#issuecomment-6280340544
This issue has been closed because it has been inactive for 180 days. If you believe this issue is still relevant, please feel free to reopen it or create a new issue. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org