You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wink.apache.org by "Gerhard Petracek (JIRA)" <ji...@apache.org> on 2013/07/13 22:13:55 UTC

[jira] [Closed] (WINK-114) Cache parsed Accept header content where possible

     [ https://issues.apache.org/jira/browse/WINK-114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gerhard Petracek closed WINK-114.
---------------------------------

    
> Cache parsed Accept header content where possible
> -------------------------------------------------
>
>                 Key: WINK-114
>                 URL: https://issues.apache.org/jira/browse/WINK-114
>             Project: Wink
>          Issue Type: Improvement
>          Components: Common
>    Affects Versions: 0.1
>            Reporter: Nick Gallardo
>            Assignee: Michael Elman
>             Fix For: 1.0
>
>         Attachments: WINK-114-generic.patch, WINK-114-generic-sync2.patch, WINK-114-generic-sync.patch, WINK-114.patch, WINK-114-ThreadLocal.patch, WINK-114-use-pattern.patch
>
>
> AcceptHeaderDelete.fromString() is called for every invocation.  This drives calls to string splits and some regex tools that start to show up in profiles as taking up a notable amount of time.  Since the content for the Accept headers will remain within a fairly bounded set, we can cache the parsed content and improve performance.
> Here's a patch with a simple solution.  Really I think there's a better way to do this.  Presumably, there are other headers where the same thing applies.  We can handle those on an individual basis or we can come up with something more generic that can be used by all HeaderDelegates.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira