You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/03/11 13:00:10 UTC
[GitHub] [lucene-solr] rmuir commented on issue #1338: LUCENE-9271: Move
BufferedIndexInput to the ByteBuffer API
rmuir commented on issue #1338: LUCENE-9271: Move BufferedIndexInput to the ByteBuffer API
URL: https://github.com/apache/lucene-solr/pull/1338#issuecomment-597617523
If we are replacing the `byte[]` with `ByteBuffer` here, can we try to add some safety at the same time? Can the actual buffer be `private final` and only passed to `readInternal()`? Otherwise, subclasses should only be able to see a read-only view (`.asReadOnlyBuffer`). The little bit of safety should be free, and since we are changing the API anyway, we might as well try to do it now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org