[GitHub] [fineract] galovics commented on a diff in pull request #3206: FINERACT-1926: Fineract Asset Externalization - events

["galovics (via GitHub)" <gi...@apache.org>]

galovics commented on code in PR #3206:
URL: https://github.com/apache/fineract/pull/3206#discussion_r1219181469


##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/service/serialization/mapper/loan/LoanAccountDataMapper.java:
##########
@@ -24,13 +24,17 @@
 import org.mapstruct.Mapper;
 import org.mapstruct.Mapping;
 
-@Mapper(config = AvroMapperConfig.class, uses = { LoanTransactionDataMapper.class })
+@Mapper(config = AvroMapperConfig.class, uses = { LoanTransactionDataMapper.class, LoanChargeDataMapper.class })
 public interface LoanAccountDataMapper {
 
     // TODO: avoid prefix "is" in class attributes; I would recommend to fix this also in the Avro structures
     @Mapping(source = "loanProductLinkedToFloatingRate", target = "isLoanProductLinkedToFloatingRate")
     @Mapping(source = "floatingInterestRate", target = "isFloatingInterestRate")
     @Mapping(source = "topup", target = "isTopup")
     @Mapping(source = "interestRecalculationEnabled", target = "isInterestRecalculationEnabled")
+    @Mapping(target = "externalOwnerId", ignore = true)

Review Comment:
   Yeah, probably it would've been better if we had a nested object in the schema instead of doing a flat schema for the asset owner attributes, that way a single ignore would've been enough.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org