You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2022/03/15 07:32:23 UTC

[GitHub] [hbase] virajjasani commented on a change in pull request #4216: HBASE-26720 ExportSnapshot should validate the source snapshot before copying files

virajjasani commented on a change in pull request #4216:
URL: https://github.com/apache/hbase/pull/4216#discussion_r826652596



##########
File path: hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/snapshot/ExportSnapshot.java
##########
@@ -996,6 +1000,12 @@ public int doWork() throws IOException {
     LOG.debug("outputFs={}, outputRoot={}, skipTmp={}, initialOutputSnapshotDir={}",
       outputFs, outputRoot.toString(), skipTmp, initialOutputSnapshotDir);
 
+    // Verify snapshot source before copying files
+    if (verifySource) {
+      LOG.info("Verify snapshot source.");

Review comment:
       How about adding `srcConf`, `inputFs`, `inputRoot`, `snapshotDir` values in the log as well?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org