You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by GitBox <gi...@apache.org> on 2021/12/14 08:48:59 UTC

[GitHub] [mesos] Lqp1 edited a comment on pull request #415: Explicitely fail content length fetch in case of error

Lqp1 edited a comment on pull request #415:
URL: https://github.com/apache/mesos/pull/415#issuecomment-993308012


   Hello :)
   Thanks for your feedback.
   
   > the file could be modified between the HEAD and the GET.
   Yes, this is why there is a mechanism inside Mesos to adapt the cache following the GET.
   
   To me it's weirder to try to allocate space following a "bad" HEAD request response than failing directly.
   
   I don't think there is a higher risk of breakage with it, but I'd understand you prefer to ignore this PR as it changes how Mesos behaves. We can also make this change more specific by raising in case of 404 and 500 errors for example (which are the most common ones). Just FYI, we are now running this patch in production, without any issue so far.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org