You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Jesús Camacho Rodríguez <jc...@hortonworks.com> on 2016/11/15 23:18:01 UTC
Review Request 53800: HIVE-15211
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53800/
-----------------------------------------------------------
Review request for hive and Ashutosh Chauhan.
Bugs: HIVE-15211
https://issues.apache.org/jira/browse/HIVE-15211
Repository: hive-git
Description
-------
HIVE-15211
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java 97fcd55295a0642b41f2f428606f72c3dba90470
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/JoinCondTypeCheckProcFactory.java 9128d81e59d5b7e074b70572e9c110b29a63908b
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 78011c221dc128085ceba8773be21113bb78ac31
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 8f5542bbe09f11b75248879df41a8e7c5cc54d78
ql/src/test/queries/clientnegative/join45.q PRE-CREATION
ql/src/test/queries/clientpositive/join45.q PRE-CREATION
ql/src/test/results/clientnegative/join45.q.out PRE-CREATION
ql/src/test/results/clientpositive/join45.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/53800/diff/
Testing
-------
Thanks,
Jes�s Camacho Rodr�guez
Re: Review Request 53800: HIVE-15211
Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
> On Nov. 16, 2016, 10:11 p.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java, line 2583
> > <https://reviews.apache.org/r/53800/diff/1/?file=1564771#file1564771line2583>
> >
> > This should check for absence of outer & semi joins. if (joinTree.getNoSemiJoin() && joinTree.getNoOuterJoin && ... )
I actually add those conditions to the post Join conditions and I do not need to catch whether is an outer join or not here. Instead, I catch that in L8095 in SemanticAnalyzer and throw an Exception if it is an outer join over there.
This is also better for the upcoming patch with support for all kind of predicates in the ON clause for outer joins, since I will just have to lift that restriction in SemanticAnalyzer.
> On Nov. 16, 2016, 10:11 p.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java, line 2794
> > <https://reviews.apache.org/r/53800/diff/1/?file=1564771#file1564771line2794>
> >
> > This should also check for absence of outer & semi joins. if (joinTree.getNoSemiJoin() && joinTree.getNoOuterJoin) {...}
As previously.
> On Nov. 16, 2016, 10:11 p.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java, line 2873
> > <https://reviews.apache.org/r/53800/diff/1/?file=1564771#file1564771line2873>
> >
> > this also should check for absence of outer and semi join.
As previously.
> On Nov. 16, 2016, 10:11 p.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java, line 2822
> > <https://reviews.apache.org/r/53800/diff/1/?file=1564771#file1564771line2822>
> >
> > This should also check for absence of outer & semi joins. if (joinTree.getNoSemiJoin() && joinTree.getNoOuterJoin && ... )
As previously.
- Jes�s
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53800/#review155997
-----------------------------------------------------------
On Nov. 15, 2016, 11:18 p.m., Jes�s Camacho Rodr�guez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53800/
> -----------------------------------------------------------
>
> (Updated Nov. 15, 2016, 11:18 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Bugs: HIVE-15211
> https://issues.apache.org/jira/browse/HIVE-15211
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-15211
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java 97fcd55295a0642b41f2f428606f72c3dba90470
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/JoinCondTypeCheckProcFactory.java 9128d81e59d5b7e074b70572e9c110b29a63908b
> ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 78011c221dc128085ceba8773be21113bb78ac31
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 8f5542bbe09f11b75248879df41a8e7c5cc54d78
> ql/src/test/queries/clientnegative/join45.q PRE-CREATION
> ql/src/test/queries/clientpositive/join45.q PRE-CREATION
> ql/src/test/results/clientnegative/join45.q.out PRE-CREATION
> ql/src/test/results/clientpositive/join45.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53800/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jes�s Camacho Rodr�guez
>
>
Re: Review Request 53800: HIVE-15211
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53800/#review155997
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java (line 72)
<https://reviews.apache.org/r/53800/#comment226085>
Don't reuse error code. Use next available.
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java (line 2582)
<https://reviews.apache.org/r/53800/#comment226264>
This should check for absence of outer & semi joins. if (joinTree.getNoSemiJoin() && joinTree.getNoOuterJoin && ... )
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java (line 2792)
<https://reviews.apache.org/r/53800/#comment226263>
This should also check for absence of outer & semi joins. if (joinTree.getNoSemiJoin() && joinTree.getNoOuterJoin) {...}
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java (line 2820)
<https://reviews.apache.org/r/53800/#comment226261>
This should also check for absence of outer & semi joins. if (joinTree.getNoSemiJoin() && joinTree.getNoOuterJoin && ... )
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java (line 2869)
<https://reviews.apache.org/r/53800/#comment226262>
this also should check for absence of outer and semi join.
ql/src/test/queries/clientpositive/join45.q (line 185)
<https://reviews.apache.org/r/53800/#comment226269>
Can you add test for mix of conjunction and disjunction. something like following
SELECT *
FROM t1
RIGHT OUTER JOIN t2 a ON (a.key = t1.key)
JOIN t3 b ON (b.key = a.key or b.value = a.value and t2.c1 = t1.c3)
JOIN t4 on (t4.key = a.key or t2.c1 = t4.c3 and t4.value = a.value)
JOIN t5 on (t5.key = a.key or t2.c1 = t4.c3 and t5.value = 42)
LIMIT 10;
- Ashutosh Chauhan
On Nov. 15, 2016, 11:18 p.m., Jes�s Camacho Rodr�guez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53800/
> -----------------------------------------------------------
>
> (Updated Nov. 15, 2016, 11:18 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Bugs: HIVE-15211
> https://issues.apache.org/jira/browse/HIVE-15211
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-15211
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java 97fcd55295a0642b41f2f428606f72c3dba90470
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/JoinCondTypeCheckProcFactory.java 9128d81e59d5b7e074b70572e9c110b29a63908b
> ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 78011c221dc128085ceba8773be21113bb78ac31
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 8f5542bbe09f11b75248879df41a8e7c5cc54d78
> ql/src/test/queries/clientnegative/join45.q PRE-CREATION
> ql/src/test/queries/clientpositive/join45.q PRE-CREATION
> ql/src/test/results/clientnegative/join45.q.out PRE-CREATION
> ql/src/test/results/clientpositive/join45.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53800/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jes�s Camacho Rodr�guez
>
>
Re: Review Request 53800: HIVE-15211
Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53800/
-----------------------------------------------------------
(Updated Nov. 21, 2016, 12:45 p.m.)
Review request for hive and Ashutosh Chauhan.
Bugs: HIVE-15211
https://issues.apache.org/jira/browse/HIVE-15211
Repository: hive-git
Description
-------
HIVE-15211
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java 97fcd55295a0642b41f2f428606f72c3dba90470
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/JoinCondTypeCheckProcFactory.java 9128d81e59d5b7e074b70572e9c110b29a63908b
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 78011c221dc128085ceba8773be21113bb78ac31
ql/src/java/org/apache/hadoop/hive/ql/parse/QBJoinTree.java a3e95ce4da2de061a7257a1945fe014ae2d160c5
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 7d8b2bd0875dbcbb948e80d9a0e8023137effc54
ql/src/test/queries/clientnegative/join45.q PRE-CREATION
ql/src/test/queries/clientpositive/join45.q PRE-CREATION
ql/src/test/results/clientnegative/join45.q.out PRE-CREATION
ql/src/test/results/clientpositive/join45.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/53800/diff/
Testing
-------
Thanks,
Jes�s Camacho Rodr�guez