You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/01/27 22:18:24 UTC

[jira] [Commented] (KAFKA-3940) Log should check the return value of dir.mkdirs()

    [ https://issues.apache.org/jira/browse/KAFKA-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843581#comment-15843581 ] 

ASF GitHub Bot commented on KAFKA-3940:
---------------------------------------

Github user imandhan closed the pull request at:

    https://github.com/apache/kafka/pull/1787


> Log should check the return value of dir.mkdirs()
> -------------------------------------------------
>
>                 Key: KAFKA-3940
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3940
>             Project: Kafka
>          Issue Type: Bug
>          Components: log
>    Affects Versions: 0.10.0.0
>            Reporter: Jun Rao
>            Assignee: Ishita Mandhan
>              Labels: newbie, reliability
>
> In Log.loadSegments(), we call dir.mkdirs() w/o checking the return value and just assume the directory will exist after the call. However, if the directory can't be created (e.g. due to no space), we will hit NullPointerException in the next statement, which will be confusing.
>    for(file <- dir.listFiles if file.isFile) {



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)