You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Flofler (via GitHub)" <gi...@apache.org> on 2024/02/20 21:31:09 UTC
[PR] Implemented MODE Z for FtpClient [commons-net]
Flofler opened a new pull request, #220:
URL: https://github.com/apache/commons-net/pull/220
I implemented MODE Z for FtpClient to save bandwidth and improve transfer times.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implemented MODE Z for FtpClient [commons-net]
Posted by "Flofler (via GitHub)" <gi...@apache.org>.
Flofler commented on PR #220:
URL: https://github.com/apache/commons-net/pull/220#issuecomment-1959811891
I'm not really sure how to fix that problems of the CodeQL check. I also don't think that this problem has anything to do with my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implemented MODE Z for FtpClient [commons-net]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #220:
URL: https://github.com/apache/commons-net/pull/220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implemented MODE Z for FtpClient [commons-net]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #220:
URL: https://github.com/apache/commons-net/pull/220#issuecomment-1961908657
Hello @Flofler
Would you please rebase on git master? The CodeQL issues should be resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implemented MODE Z for FtpClient [commons-net]
Posted by "Flofler (via GitHub)" <gi...@apache.org>.
Flofler commented on PR #220:
URL: https://github.com/apache/commons-net/pull/220#issuecomment-1961969360
Hi @garydgregory I succesfully rebased on master. You can start the workflows again :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implemented MODE Z for FtpClient [commons-net]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #220:
URL: https://github.com/apache/commons-net/pull/220#issuecomment-1957903576
Hi @Flofler
Thank you for your PR.
You should run 'mvn' by itself to run all build checks before you push to catch all errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implemented MODE Z for FtpClient [commons-net]
Posted by "Flofler (via GitHub)" <gi...@apache.org>.
Flofler commented on PR #220:
URL: https://github.com/apache/commons-net/pull/220#issuecomment-1955159269
I'm not sure if this is your preferred way to implement this with a wrapping socket. Alternatively I could change any code that is using the getInputStream() and getOutputStream() of the Socket. But then any new code that is using the Socket must know that you will have to wrap an Inflater- or DeflaterOutputStream around it.
Another solution would be to hide the Socket inside a wrapper class completely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implemented MODE Z for FtpClient [commons-net]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #220:
URL: https://github.com/apache/commons-net/pull/220#issuecomment-1961962496
## Welcome to [Codecov](https://codecov.io?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :tada:
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implemented MODE Z for FtpClient [commons-net]
Posted by "Flofler (via GitHub)" <gi...@apache.org>.
Flofler commented on PR #220:
URL: https://github.com/apache/commons-net/pull/220#issuecomment-1959056957
Hi @garydgregory
sorry, I didn't know that. This is my first PR. I fixed all issues and ran 'mvn' by myself and it was successful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implemented MODE Z for FtpClient [commons-net]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #220:
URL: https://github.com/apache/commons-net/pull/220#issuecomment-1960059149
Interesting... it does not look directly related, needs investigating...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org