You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/27 02:42:36 UTC
[GitHub] [superset] ktmud commented on a change in pull request #12772: refactor: change Windows new tab shortcut to ctrl + q
ktmud commented on a change in pull request #12772:
URL: https://github.com/apache/superset/pull/12772#discussion_r564985274
##########
File path: superset-frontend/src/SqlLab/components/SqlEditor.jsx
##########
@@ -154,6 +154,18 @@ const defaultProps = {
scheduleQueryWarning: null,
};
+// Detects the user's OS through the browser
+export function detectOS() {
Review comment:
Sorry for jumping in, but why arrow function? I don't remember we are enforcing this style. IMO `function` reads cleaner, especially when used in exports.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org