You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by jerrypeng <gi...@git.apache.org> on 2015/08/11 23:06:17 UTC
[GitHub] storm pull request: [STORM-949] On the topology summary UI page, a...
GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/675
[STORM-949] On the topology summary UI page, added Elapsed time since error column.
Current on the topology summary UI page and tells you the last error and highlights it red if it happened within the last 30 min. However, I think its useful if there was a column that told you the time that has elapsed since the most recent error occurred. I found this useful for monitoring the well being of my storm cluster.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jerrypeng/storm STORM-949
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/675.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #675
----
commit 1f34a9a07d1993e6d043d73c20e95a6c999cf733
Author: Boyang Jerry Peng <je...@yahoo-inc.com>
Date: 2015-08-11T20:16:02Z
[STORM-949] On the topology summary UI page, added Elapsed time since error column.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-949] On the topology summary UI page, a...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/675#discussion_r36807536
--- Diff: storm-core/src/ui/public/templates/topology-page-template.html ---
@@ -313,6 +320,10 @@
</th>
<th class="header">Last error
</th>
+ <th class="header">
--- End diff --
MINOR: Indentation goes wrong.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-949] On the topology summary UI page, a...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/675#issuecomment-130085867
Hi, there's a storm-hive compilation issue.
Your patch modifies html pages, so you don't need to worry about build. :)
I'll take a look when I have some time. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-949] On the topology summary UI page, a...
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/675#issuecomment-130827376
I'm more in favor of putting a time/date here than an elapsed time.
The actual description for STORM-949 is "On the topology summary UI page, last shown error should have the time and date".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-949] On the topology summary UI page, a...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/675#issuecomment-131272147
@jerrypeng
I'm with @knusbaum. PR is a bit different from JIRA title, and I'm also more in favor of putting time/date.
How about gathering consensus about this feature from dev mailing list and reflect feedback?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-949] On the topology summary UI page, a...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/675#issuecomment-132990727
Modified version of UI is what I and @knusbaum , @d2r suggested, and it seems that there're no other opinions now.
Build failure is not related to.
So I'm +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-949] On the topology summary UI page, a...
Posted by jerrypeng <gi...@git.apache.org>.
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/675#issuecomment-130829555
Yes but the exact time and date can be found if you drill down to the component. Having the elapsed time since time I feel like will tell administrators in a finer grain when the error happened
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-949] On the topology summary UI page, a...
Posted by jerrypeng <gi...@git.apache.org>.
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/675#issuecomment-132891659
Just modified the UI to have error time shown as a time and date. If you hover over that time a tooltip will pop up displaying the elapsed time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-949] On the topology summary UI page, a...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/675#discussion_r36807588
--- Diff: storm-core/src/ui/public/templates/topology-page-template.html ---
@@ -244,6 +248,9 @@
<td>
<span id="{{errorLapsedSecs}}" class="errorSpan">{{lastError}}</span>
</td>
+ <td>
--- End diff --
MINOR: Indentation goes wrong.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-949] On the topology summary UI page, a...
Posted by jerrypeng <gi...@git.apache.org>.
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/675#discussion_r36867859
--- Diff: storm-core/src/ui/public/templates/topology-page-template.html ---
@@ -313,6 +320,10 @@
</th>
<th class="header">Last error
</th>
+ <th class="header">
--- End diff --
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-949] On the topology summary UI page, a...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/675#issuecomment-130099776
@jerrypeng
I'd like to see applied screenshot first before taking a detail look. Could you post it to comment?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-949] On the topology summary UI page, a...
Posted by jerrypeng <gi...@git.apache.org>.
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/675#issuecomment-130084456
Not sure why travis is failing again. I just built and ran all tests on my local machine and everything was fine
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-949] On the topology summary UI page, a...
Posted by caofangkun <gi...@git.apache.org>.
Github user caofangkun commented on a diff in the pull request:
https://github.com/apache/storm/pull/675#discussion_r36819256
--- Diff: storm-core/src/ui/public/templates/topology-page-template.html ---
@@ -313,6 +320,10 @@
</th>
<th class="header">Last error
</th>
+ <th class="header">
--- End diff --
@HeartSaVioR
Code style shoud be checked before commit , shall we provide ```.editorconfig ``` with ````git pre-commit hooks``` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-949] On the topology summary UI page, a...
Posted by jerrypeng <gi...@git.apache.org>.
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/675#issuecomment-131150732
@HeartSaVioR can you take a look at my pull request again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-949] On the topology summary UI page, a...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/675
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-949] On the topology summary UI page, a...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/675#discussion_r36807871
--- Diff: storm-core/src/ui/public/templates/topology-page-template.html ---
@@ -226,6 +226,10 @@
</th>
<th class="header">Last error
</th>
+ <th class="header">
--- End diff --
MINOR: Indentation goes wrong.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-949] On the topology summary UI page, a...
Posted by jerrypeng <gi...@git.apache.org>.
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/675#issuecomment-130327785
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-949] On the topology summary UI page, a...
Posted by jerrypeng <gi...@git.apache.org>.
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/675#issuecomment-130347080
fixed the formating issues
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-949] On the topology summary UI page, a...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/675#discussion_r36807960
--- Diff: storm-core/src/ui/public/templates/topology-page-template.html ---
@@ -333,6 +344,9 @@
<td>
<span id="{{errorLapsedSecs}}" class="errorSpan">{{lastError}}</span>
</td>
+ <td>
--- End diff --
MINOR: Indentation goes wrong.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-949] On the topology summary UI page, a...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/675#discussion_r36824315
--- Diff: storm-core/src/ui/public/templates/topology-page-template.html ---
@@ -313,6 +320,10 @@
</th>
<th class="header">Last error
</th>
+ <th class="header">
--- End diff --
@caofangkun
Before that we need to establish code style for Java, HTML, etc. And have formatter file to let users applies it easily.
For example, Jedis uses Eclipse Java formatter which HBase project is using.
https://github.com/xetorthio/jedis/blob/master/hbase-formatter.xml
And ```make format``` formats whole files, so any contributors can run that commands before commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---