You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Gilles (JIRA)" <ji...@apache.org> on 2012/07/16 11:17:35 UTC

[jira] [Created] (MATH-825) public method "laguerre" should be private

Gilles created MATH-825:
---------------------------

             Summary: public method "laguerre" should be private
                 Key: MATH-825
                 URL: https://issues.apache.org/jira/browse/MATH-825
             Project: Commons Math
          Issue Type: Bug
    Affects Versions: 3.0
            Reporter: Gilles
            Priority: Trivial
             Fix For: 4.0


In class "LaguerreSolver" (package "o.a.c.m.analysis.solvers"), the method "laguerre" is public. However, it doesn't make any sense to call it from outside the class (because its argument list does not contain the function whose roots must be computed).
The method should be made private.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MATH-825) public method "laguerre" should be private

Posted by "Gilles (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MATH-825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414969#comment-13414969 ] 

Gilles commented on MATH-825:
-----------------------------

bq. [...] the method should be marked as deprecated [...]

Done in revision 1361956.
                
> public method "laguerre" should be private
> ------------------------------------------
>
>                 Key: MATH-825
>                 URL: https://issues.apache.org/jira/browse/MATH-825
>             Project: Commons Math
>          Issue Type: Bug
>    Affects Versions: 3.0
>            Reporter: Gilles
>            Priority: Trivial
>             Fix For: 4.0
>
>
> In class "LaguerreSolver" (package "o.a.c.m.analysis.solvers"), the method "laguerre" is public. However, it doesn't make any sense to call it from outside the class (because its argument list does not contain the function whose roots must be computed).
> The method should be made private.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MATH-825) public method "laguerre" should be private

Posted by "Gilles (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MATH-825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414951#comment-13414951 ] 

Gilles commented on MATH-825:
-----------------------------

Since the change is not backward-compatible, the method should be marked as deprecated in 3.1.
                
> public method "laguerre" should be private
> ------------------------------------------
>
>                 Key: MATH-825
>                 URL: https://issues.apache.org/jira/browse/MATH-825
>             Project: Commons Math
>          Issue Type: Bug
>    Affects Versions: 3.0
>            Reporter: Gilles
>            Priority: Trivial
>             Fix For: 4.0
>
>
> In class "LaguerreSolver" (package "o.a.c.m.analysis.solvers"), the method "laguerre" is public. However, it doesn't make any sense to call it from outside the class (because its argument list does not contain the function whose roots must be computed).
> The method should be made private.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira