You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2012/02/29 10:57:58 UTC

[jira] [Commented] (FLUME-1009) HDFSEventSink should return BACKOFF when the channel returns null

    [ https://issues.apache.org/jira/browse/FLUME-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219048#comment-13219048 ] 

jiraposter@reviews.apache.org commented on FLUME-1009:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4104/
-----------------------------------------------------------

Review request for Flume.


Summary
-------

HDFSEventSink returns BACKOFF if the channel returns null. Added UNIT test to avoid regression.


This addresses bug FLUME-1009.
    https://issues.apache.org/jira/browse/FLUME-1009


Diffs
-----

  flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java 524b69c 
  flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestHDFSEventSink.java 7d8ee8a 

Diff: https://reviews.apache.org/r/4104/diff


Testing
-------

All unit tests pass.


Thanks,

Brock


                
> HDFSEventSink should return BACKOFF when the channel returns null
> -----------------------------------------------------------------
>
>                 Key: FLUME-1009
>                 URL: https://issues.apache.org/jira/browse/FLUME-1009
>             Project: Flume
>          Issue Type: Bug
>          Components: Sinks+Sources
>    Affects Versions: v1.0.0
>            Reporter: Brock Noland
>            Priority: Blocker
>
> As discussed here sinks should return BACKOFF is there is nothing in the channel.
> http://mail-archives.apache.org/mod_mbox/incubator-flume-dev/201202.mbox/%3CCAFukC%3D7Dj7%3DcP%2BzLKzu8jUAb0Y-A-Faw-_Gix0mcV-V%2B-QBZ0A%40mail.gmail.com%3E
> In conjunction with JDBCChannel, Flume will burn an entire CPU doing nothing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira