You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2015/08/30 10:45:43 UTC

Re: Review Request 37669: Ignore overflow docker components in version parsing.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37669/
-----------------------------------------------------------

(Updated Aug. 30, 2015, 8:45 a.m.)


Review request for mesos, Ben Mahler, Isabel Jimenez, and Timothy Chen.


Summary (updated)
-----------------

Ignore overflow docker components in version parsing.


Bugs: MESOS-2986
    https://issues.apache.org/jira/browse/MESOS-2986


Repository: mesos


Description (updated)
-------

Ignore overflow docker components in version parsing.


Diffs (updated)
-----

  src/docker/docker.cpp 12dc0505c9ec4bd380e817d44da2c4e8d1b0d5f5 

Diff: https://reviews.apache.org/r/37669/diff/


Testing
-------


Thanks,

haosdent huang

Re: Review Request 37669: Ignore overflow docker components in version parsing.

Posted by haosdent huang <ha...@gmail.com>.

> On Sept. 2, 2015, 2:54 p.m., Bernd Mathiske wrote:
> > src/docker/docker.cpp, line 201
> > <https://reviews.apache.org/r/37669/diff/7/?file=1059998#file1059998line201>
> >
> >     The "[0]" access looks dicy, but after reading the implementation of strings::split(), I am fairly convinced that we will never crash here. Such tricky code needs to be commented, though. I'd break out the inner split and comment on what we are doing there. This seems to erase trailing version string components starting with a "-". But how does this relate to what is written in line 195? Do we need to worry about splitting at "-" at all?

LoL, thank you very much. I think my code still have bug here. Let me update again.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37669/#review97453
-----------------------------------------------------------


On Aug. 30, 2015, 8:45 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37669/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2015, 8:45 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Timothy Chen.
> 
> 
> Bugs: MESOS-2986
>     https://issues.apache.org/jira/browse/MESOS-2986
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ignore overflow docker components in version parsing.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp 12dc0505c9ec4bd380e817d44da2c4e8d1b0d5f5 
> 
> Diff: https://reviews.apache.org/r/37669/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37669: Ignore overflow docker components in version parsing.

Posted by haosdent huang <ha...@gmail.com>.

> On Sept. 2, 2015, 2:54 p.m., Bernd Mathiske wrote:
> > src/docker/docker.cpp, line 201
> > <https://reviews.apache.org/r/37669/diff/7/?file=1059998#file1059998line201>
> >
> >     The "[0]" access looks dicy, but after reading the implementation of strings::split(), I am fairly convinced that we will never crash here. Such tricky code needs to be commented, though. I'd break out the inner split and comment on what we are doing there. This seems to erase trailing version string components starting with a "-". But how does this relate to what is written in line 195? Do we need to worry about splitting at "-" at all?
> 
> haosdent huang wrote:
>     LoL, thank you very much. I think my code still have bug here. Let me update again.

I would also append with a mock test case in this patch. Need sometime here.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37669/#review97453
-----------------------------------------------------------


On Aug. 30, 2015, 8:45 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37669/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2015, 8:45 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Timothy Chen.
> 
> 
> Bugs: MESOS-2986
>     https://issues.apache.org/jira/browse/MESOS-2986
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ignore overflow docker components in version parsing.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp 12dc0505c9ec4bd380e817d44da2c4e8d1b0d5f5 
> 
> Diff: https://reviews.apache.org/r/37669/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37669: Ignore overflow docker components in version parsing.

Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37669/#review97453
-----------------------------------------------------------



src/docker/docker.cpp (line 199)
<https://reviews.apache.org/r/37669/#comment153330>

    s/strVersion/versionString
    
    (Let's not use arbitrary abbreviations where we can avoid it.)



src/docker/docker.cpp (line 201)
<https://reviews.apache.org/r/37669/#comment153332>

    The "[0]" access looks dicy, but after reading the implementation of strings::split(), I am fairly convinced that we will never crash here. Such tricky code needs to be commented, though. I'd break out the inner split and comment on what we are doing there. This seems to erase trailing version string components starting with a "-". But how does this relate to what is written in line 195? Do we need to worry about splitting at "-" at all?


- Bernd Mathiske


On Aug. 30, 2015, 1:45 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37669/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2015, 1:45 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Timothy Chen.
> 
> 
> Bugs: MESOS-2986
>     https://issues.apache.org/jira/browse/MESOS-2986
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ignore overflow docker components in version parsing.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp 12dc0505c9ec4bd380e817d44da2c4e8d1b0d5f5 
> 
> Diff: https://reviews.apache.org/r/37669/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37669: Ignore overflow docker components in version parsing.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37669/#review97022
-----------------------------------------------------------


Patch looks great!

Reviews applied: [37669]

All tests passed.

- Mesos ReviewBot


On Aug. 30, 2015, 8:45 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37669/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2015, 8:45 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Timothy Chen.
> 
> 
> Bugs: MESOS-2986
>     https://issues.apache.org/jira/browse/MESOS-2986
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ignore overflow docker components in version parsing.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp 12dc0505c9ec4bd380e817d44da2c4e8d1b0d5f5 
> 
> Diff: https://reviews.apache.org/r/37669/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37669: Ignore overflow docker components in version parsing.

Posted by Yong Qiao Wang <yq...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37669/#review97452
-----------------------------------------------------------

Ship it!


Ship It!

- Yong Qiao Wang


On 八月 30, 2015, 8:45 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37669/
> -----------------------------------------------------------
> 
> (Updated 八月 30, 2015, 8:45 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Timothy Chen.
> 
> 
> Bugs: MESOS-2986
>     https://issues.apache.org/jira/browse/MESOS-2986
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ignore overflow docker components in version parsing.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp 12dc0505c9ec4bd380e817d44da2c4e8d1b0d5f5 
> 
> Diff: https://reviews.apache.org/r/37669/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37669: Ignore overflow docker components in version parsing.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37669/#review97628
-----------------------------------------------------------


Patch looks great!

Reviews applied: [37669]

All tests passed.

- Mesos ReviewBot


On Sept. 3, 2015, 11:16 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37669/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2015, 11:16 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Timothy Chen.
> 
> 
> Bugs: MESOS-2986
>     https://issues.apache.org/jira/browse/MESOS-2986
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ignore overflow docker components in version parsing.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp 2e17cedb3e29548bdd2d10bd87bd0f61bf123be8 
>   src/tests/containerizer/docker_tests.cpp cfad36850b40ade7a41f5b92255320ca1ed1bf93 
> 
> Diff: https://reviews.apache.org/r/37669/diff/
> 
> 
> Testing
> -------
> 
> # Add new test case
> sudo ./bin/mesos-tests.sh --gtest_filter="DockerTest.ROOT_DOCKER_parsing_version" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37669: Ignore overflow docker components in version parsing.

Posted by haosdent huang <ha...@gmail.com>.

> On Sept. 4, 2015, 6:59 a.m., Timothy Chen wrote:
> > src/docker/docker.cpp, line 203
> > <https://reviews.apache.org/r/37669/diff/10/?file=1063731#file1063731line203>
> >
> >     We remove the overflow components
> 
> haosdent huang wrote:
>     Change “remove the rest components here before parsing the docker version” to "We remove the overflow components here before parsing the docker version", right?

Oh, thanks for @brend help.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37669/#review97732
-----------------------------------------------------------


On Sept. 4, 2015, 2:27 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37669/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2015, 2:27 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Timothy Chen.
> 
> 
> Bugs: MESOS-2986
>     https://issues.apache.org/jira/browse/MESOS-2986
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ignore overflow docker components in version parsing.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp 2e17cedb3e29548bdd2d10bd87bd0f61bf123be8 
>   src/tests/containerizer/docker_tests.cpp cfad36850b40ade7a41f5b92255320ca1ed1bf93 
> 
> Diff: https://reviews.apache.org/r/37669/diff/
> 
> 
> Testing
> -------
> 
> # Add new test case
> sudo ./bin/mesos-tests.sh --gtest_filter="DockerTest.ROOT_DOCKER_parsing_version" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37669: Ignore overflow docker components in version parsing.

Posted by haosdent huang <ha...@gmail.com>.

> On Sept. 4, 2015, 6:59 a.m., Timothy Chen wrote:
> > src/docker/docker.cpp, line 203
> > <https://reviews.apache.org/r/37669/diff/10/?file=1063731#file1063731line203>
> >
> >     We remove the overflow components

Change “remove the rest components here before parsing the docker version” to "We remove the overflow components here before parsing the docker version", right?


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37669/#review97732
-----------------------------------------------------------


On Sept. 4, 2015, 2:27 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37669/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2015, 2:27 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Timothy Chen.
> 
> 
> Bugs: MESOS-2986
>     https://issues.apache.org/jira/browse/MESOS-2986
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ignore overflow docker components in version parsing.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp 2e17cedb3e29548bdd2d10bd87bd0f61bf123be8 
>   src/tests/containerizer/docker_tests.cpp cfad36850b40ade7a41f5b92255320ca1ed1bf93 
> 
> Diff: https://reviews.apache.org/r/37669/diff/
> 
> 
> Testing
> -------
> 
> # Add new test case
> sudo ./bin/mesos-tests.sh --gtest_filter="DockerTest.ROOT_DOCKER_parsing_version" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37669: Ignore overflow docker components in version parsing.

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37669/#review97732
-----------------------------------------------------------

Ship it!


Ship It!


src/docker/docker.cpp (line 203)
<https://reviews.apache.org/r/37669/#comment153745>

    We remove the overflow components


- Timothy Chen


On Sept. 4, 2015, 2:27 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37669/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2015, 2:27 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Timothy Chen.
> 
> 
> Bugs: MESOS-2986
>     https://issues.apache.org/jira/browse/MESOS-2986
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ignore overflow docker components in version parsing.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp 2e17cedb3e29548bdd2d10bd87bd0f61bf123be8 
>   src/tests/containerizer/docker_tests.cpp cfad36850b40ade7a41f5b92255320ca1ed1bf93 
> 
> Diff: https://reviews.apache.org/r/37669/diff/
> 
> 
> Testing
> -------
> 
> # Add new test case
> sudo ./bin/mesos-tests.sh --gtest_filter="DockerTest.ROOT_DOCKER_parsing_version" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37669: Ignore overflow docker components in version parsing.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37669/#review97731
-----------------------------------------------------------


Patch looks great!

Reviews applied: [37669]

All tests passed.

- Mesos ReviewBot


On Sept. 4, 2015, 2:27 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37669/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2015, 2:27 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Timothy Chen.
> 
> 
> Bugs: MESOS-2986
>     https://issues.apache.org/jira/browse/MESOS-2986
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ignore overflow docker components in version parsing.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp 2e17cedb3e29548bdd2d10bd87bd0f61bf123be8 
>   src/tests/containerizer/docker_tests.cpp cfad36850b40ade7a41f5b92255320ca1ed1bf93 
> 
> Diff: https://reviews.apache.org/r/37669/diff/
> 
> 
> Testing
> -------
> 
> # Add new test case
> sudo ./bin/mesos-tests.sh --gtest_filter="DockerTest.ROOT_DOCKER_parsing_version" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37669: Ignore overflow docker components in version parsing.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37669/
-----------------------------------------------------------

(Updated Sept. 4, 2015, 2:27 a.m.)


Review request for mesos, Ben Mahler, Isabel Jimenez, and Timothy Chen.


Changes
-------

update according @Jan's reviews


Bugs: MESOS-2986
    https://issues.apache.org/jira/browse/MESOS-2986


Repository: mesos


Description
-------

Ignore overflow docker components in version parsing.


Diffs (updated)
-----

  src/docker/docker.cpp 2e17cedb3e29548bdd2d10bd87bd0f61bf123be8 
  src/tests/containerizer/docker_tests.cpp cfad36850b40ade7a41f5b92255320ca1ed1bf93 

Diff: https://reviews.apache.org/r/37669/diff/


Testing
-------

# Add new test case
sudo ./bin/mesos-tests.sh --gtest_filter="DockerTest.ROOT_DOCKER_parsing_version" --verbose


Thanks,

haosdent huang

Re: Review Request 37669: Ignore overflow docker components in version parsing.

Posted by haosdent huang <ha...@gmail.com>.

> On Sept. 3, 2015, 3:55 p.m., Jan Schlicht wrote:
> > src/tests/containerizer/docker_tests.cpp, line 229
> > <https://reviews.apache.org/r/37669/diff/9/?file=1063258#file1063258line229>
> >
> >     This is a test of the special case with a "1.7.1.fc22" version string. How about an additional test of the general case like "1.7.1"?

Sure, already updated. Thank you very much.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37669/#review97643
-----------------------------------------------------------


On Sept. 4, 2015, 2:27 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37669/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2015, 2:27 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Timothy Chen.
> 
> 
> Bugs: MESOS-2986
>     https://issues.apache.org/jira/browse/MESOS-2986
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ignore overflow docker components in version parsing.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp 2e17cedb3e29548bdd2d10bd87bd0f61bf123be8 
>   src/tests/containerizer/docker_tests.cpp cfad36850b40ade7a41f5b92255320ca1ed1bf93 
> 
> Diff: https://reviews.apache.org/r/37669/diff/
> 
> 
> Testing
> -------
> 
> # Add new test case
> sudo ./bin/mesos-tests.sh --gtest_filter="DockerTest.ROOT_DOCKER_parsing_version" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37669: Ignore overflow docker components in version parsing.

Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37669/#review97643
-----------------------------------------------------------

Ship it!



src/tests/containerizer/docker_tests.cpp (line 229)
<https://reviews.apache.org/r/37669/#comment153656>

    This is a test of the special case with a "1.7.1.fc22" version string. How about an additional test of the general case like "1.7.1"?


- Jan Schlicht


On Sept. 3, 2015, 1:16 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37669/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2015, 1:16 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Timothy Chen.
> 
> 
> Bugs: MESOS-2986
>     https://issues.apache.org/jira/browse/MESOS-2986
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ignore overflow docker components in version parsing.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp 2e17cedb3e29548bdd2d10bd87bd0f61bf123be8 
>   src/tests/containerizer/docker_tests.cpp cfad36850b40ade7a41f5b92255320ca1ed1bf93 
> 
> Diff: https://reviews.apache.org/r/37669/diff/
> 
> 
> Testing
> -------
> 
> # Add new test case
> sudo ./bin/mesos-tests.sh --gtest_filter="DockerTest.ROOT_DOCKER_parsing_version" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37669: Ignore overflow docker components in version parsing.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37669/
-----------------------------------------------------------

(Updated Sept. 3, 2015, 11:16 a.m.)


Review request for mesos, Ben Mahler, Isabel Jimenez, and Timothy Chen.


Changes
-------

Update according Bernd opinions.


Bugs: MESOS-2986
    https://issues.apache.org/jira/browse/MESOS-2986


Repository: mesos


Description
-------

Ignore overflow docker components in version parsing.


Diffs (updated)
-----

  src/docker/docker.cpp 2e17cedb3e29548bdd2d10bd87bd0f61bf123be8 
  src/tests/containerizer/docker_tests.cpp cfad36850b40ade7a41f5b92255320ca1ed1bf93 

Diff: https://reviews.apache.org/r/37669/diff/


Testing
-------

# Add new test case
sudo ./bin/mesos-tests.sh --gtest_filter="DockerTest.ROOT_DOCKER_parsing_version" --verbose


Thanks,

haosdent huang

Re: Review Request 37669: Ignore overflow docker components in version parsing.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37669/#review97604
-----------------------------------------------------------


Patch looks great!

Reviews applied: [37669]

All tests passed.

- Mesos ReviewBot


On Sept. 3, 2015, 3:12 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37669/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2015, 3:12 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Timothy Chen.
> 
> 
> Bugs: MESOS-2986
>     https://issues.apache.org/jira/browse/MESOS-2986
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ignore overflow docker components in version parsing.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp 2e17cedb3e29548bdd2d10bd87bd0f61bf123be8 
>   src/tests/containerizer/docker_tests.cpp cfad36850b40ade7a41f5b92255320ca1ed1bf93 
> 
> Diff: https://reviews.apache.org/r/37669/diff/
> 
> 
> Testing
> -------
> 
> # Add new test case
> sudo ./bin/mesos-tests.sh --gtest_filter="DockerTest.ROOT_DOCKER_parsing_version" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37669: Ignore overflow docker components in version parsing.

Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37669/#review97624
-----------------------------------------------------------

Ship it!


Minor fixes can be dealt with when committing.


src/docker/docker.cpp (line 201)
<https://reviews.apache.org/r/37669/#comment153639>

    s/docker/Docker
    s/is/does



src/docker/docker.cpp (line 204)
<https://reviews.apache.org/r/37669/#comment153640>

    s/to/to a


- Bernd Mathiske


On Sept. 2, 2015, 8:12 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37669/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2015, 8:12 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Timothy Chen.
> 
> 
> Bugs: MESOS-2986
>     https://issues.apache.org/jira/browse/MESOS-2986
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ignore overflow docker components in version parsing.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp 2e17cedb3e29548bdd2d10bd87bd0f61bf123be8 
>   src/tests/containerizer/docker_tests.cpp cfad36850b40ade7a41f5b92255320ca1ed1bf93 
> 
> Diff: https://reviews.apache.org/r/37669/diff/
> 
> 
> Testing
> -------
> 
> # Add new test case
> sudo ./bin/mesos-tests.sh --gtest_filter="DockerTest.ROOT_DOCKER_parsing_version" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37669: Ignore overflow docker components in version parsing.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37669/
-----------------------------------------------------------

(Updated Sept. 3, 2015, 3:12 a.m.)


Review request for mesos, Ben Mahler, Isabel Jimenez, and Timothy Chen.


Bugs: MESOS-2986
    https://issues.apache.org/jira/browse/MESOS-2986


Repository: mesos


Description
-------

Ignore overflow docker components in version parsing.


Diffs
-----

  src/docker/docker.cpp 2e17cedb3e29548bdd2d10bd87bd0f61bf123be8 
  src/tests/containerizer/docker_tests.cpp cfad36850b40ade7a41f5b92255320ca1ed1bf93 

Diff: https://reviews.apache.org/r/37669/diff/


Testing (updated)
-------

# Add new test case
sudo ./bin/mesos-tests.sh --gtest_filter="DockerTest.ROOT_DOCKER_parsing_version" --verbose


Thanks,

haosdent huang

Re: Review Request 37669: Ignore overflow docker components in version parsing.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37669/
-----------------------------------------------------------

(Updated Sept. 3, 2015, 3:10 a.m.)


Review request for mesos, Ben Mahler, Isabel Jimenez, and Timothy Chen.


Bugs: MESOS-2986
    https://issues.apache.org/jira/browse/MESOS-2986


Repository: mesos


Description
-------

Ignore overflow docker components in version parsing.


Diffs (updated)
-----

  src/docker/docker.cpp 2e17cedb3e29548bdd2d10bd87bd0f61bf123be8 
  src/tests/containerizer/docker_tests.cpp cfad36850b40ade7a41f5b92255320ca1ed1bf93 

Diff: https://reviews.apache.org/r/37669/diff/


Testing
-------


Thanks,

haosdent huang