You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2022/10/10 19:00:08 UTC
[Impala-ASF-CR] IMPALA-11562: Fix test unsupported text compression in s3
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19119
Change subject: IMPALA-11562: Fix test_unsupported_text_compression in s3
......................................................................
IMPALA-11562: Fix test_unsupported_text_compression in s3
Fixes test_unsupported_text_compression for S3 tests where hdfs_util.py
was changed to expect a leading slash (and the pure HDFS implementation
removes the leading slash). Skips removing the leading slash since HDFS
now adds it and other filesystems expect the leading slash.
Change-Id: I74724b2d5af0bd879d92d5e5febe92d01c972525
---
M tests/metadata/test_partition_metadata.py
1 file changed, 10 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/19119/1
--
To view, visit http://gerrit.cloudera.org:8080/19119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I74724b2d5af0bd879d92d5e5febe92d01c972525
Gerrit-Change-Number: 19119
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-11646 IMPALA-11562: Fix test unsupported text compression in s3
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19119 )
Change subject: IMPALA-11646 IMPALA-11562: Fix test_unsupported_text_compression in s3
......................................................................
IMPALA-11646 IMPALA-11562: Fix test_unsupported_text_compression in s3
Fixes test_unsupported_text_compression for S3 tests where hdfs_util.py
was changed to expect a leading slash (and the pure HDFS implementation
removes the leading slash). Skips removing the leading slash since HDFS
now adds it and other filesystems expect the leading slash.
Change-Id: I74724b2d5af0bd879d92d5e5febe92d01c972525
Reviewed-on: http://gerrit.cloudera.org:8080/19119
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Reviewed-by: Fang-Yu Rao <fa...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/metadata/test_partition_metadata.py
1 file changed, 10 insertions(+), 10 deletions(-)
Approvals:
Joe McDonnell: Looks good to me, approved
Fang-Yu Rao: Looks good to me, but someone else must approve
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/19119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I74724b2d5af0bd879d92d5e5febe92d01c972525
Gerrit-Change-Number: 19119
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-11646 IMPALA-11562: Fix test unsupported text compression in s3
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19119 )
Change subject: IMPALA-11646 IMPALA-11562: Fix test_unsupported_text_compression in s3
......................................................................
Patch Set 3:
This test passes for me with HDFS and S3 now. It's not run for Ozone, which is how I missed it.
--
To view, visit http://gerrit.cloudera.org:8080/19119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I74724b2d5af0bd879d92d5e5febe92d01c972525
Gerrit-Change-Number: 19119
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 10 Oct 2022 20:12:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11646 IMPALA-11562: Fix test unsupported text compression in s3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19119 )
Change subject: IMPALA-11646 IMPALA-11562: Fix test_unsupported_text_compression in s3
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I74724b2d5af0bd879d92d5e5febe92d01c972525
Gerrit-Change-Number: 19119
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Oct 2022 21:50:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11646 IMPALA-11562: Fix test unsupported text compression in s3
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Fang-Yu Rao, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19119
to look at the new patch set (#3).
Change subject: IMPALA-11646 IMPALA-11562: Fix test_unsupported_text_compression in s3
......................................................................
IMPALA-11646 IMPALA-11562: Fix test_unsupported_text_compression in s3
Fixes test_unsupported_text_compression for S3 tests where hdfs_util.py
was changed to expect a leading slash (and the pure HDFS implementation
removes the leading slash). Skips removing the leading slash since HDFS
now adds it and other filesystems expect the leading slash.
Change-Id: I74724b2d5af0bd879d92d5e5febe92d01c972525
---
M tests/metadata/test_partition_metadata.py
1 file changed, 10 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/19119/3
--
To view, visit http://gerrit.cloudera.org:8080/19119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I74724b2d5af0bd879d92d5e5febe92d01c972525
Gerrit-Change-Number: 19119
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-11646 IMPALA-11562: Fix test unsupported text compression in s3
Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19119 )
Change subject: IMPALA-11646 IMPALA-11562: Fix test_unsupported_text_compression in s3
......................................................................
Patch Set 3: Code-Review+1
Thanks for the prompt fix Michael! I do not have any other comment.
I just like to check if my understanding in the following is correct after reading your fix and the corresponding functions.
When the underlying storage is HDFS and we call filesystem_client.create_file() in test_unsupported_text_compression(), DelegatingHdfsClient::create_file() is called. In this case, DelegatingHdfsClient::_normalize_path() will be invoked. _normalize_path() removes the leading slash in the given path if there is any and then webhdfs_client.create_file() will be used to create the file.
In your patch for IMPALA-11562, you removed the leading slash before calling filesystem_client.create_file(), which still works when the underlying storage is HDFS but doesn't work in s3 because HadoopFsCommandLineClient("S3") behaves a bit differently, i.e., it expects that leading slash, and thus this test failed.
--
To view, visit http://gerrit.cloudera.org:8080/19119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I74724b2d5af0bd879d92d5e5febe92d01c972525
Gerrit-Change-Number: 19119
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Oct 2022 05:21:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11646 IMPALA-11562: Fix test unsupported text compression in s3
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19119 )
Change subject: IMPALA-11646 IMPALA-11562: Fix test_unsupported_text_compression in s3
......................................................................
Patch Set 3: Code-Review+2
This looks good to me
--
To view, visit http://gerrit.cloudera.org:8080/19119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I74724b2d5af0bd879d92d5e5febe92d01c972525
Gerrit-Change-Number: 19119
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Oct 2022 00:00:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11646: Fix test unsupported text compression in s3
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Fang-Yu Rao, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19119
to look at the new patch set (#2).
Change subject: IMPALA-11646: Fix test_unsupported_text_compression in s3
......................................................................
IMPALA-11646: Fix test_unsupported_text_compression in s3
Fixes test_unsupported_text_compression for S3 tests where hdfs_util.py
was changed to expect a leading slash (and the pure HDFS implementation
removes the leading slash). Skips removing the leading slash since HDFS
now adds it and other filesystems expect the leading slash.
Change-Id: I74724b2d5af0bd879d92d5e5febe92d01c972525
---
M tests/metadata/test_partition_metadata.py
1 file changed, 10 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/19119/2
--
To view, visit http://gerrit.cloudera.org:8080/19119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I74724b2d5af0bd879d92d5e5febe92d01c972525
Gerrit-Change-Number: 19119
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-11646 IMPALA-11562: Fix test unsupported text compression in s3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19119 )
Change subject: IMPALA-11646 IMPALA-11562: Fix test_unsupported_text_compression in s3
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11596/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I74724b2d5af0bd879d92d5e5febe92d01c972525
Gerrit-Change-Number: 19119
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 10 Oct 2022 19:20:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11646 IMPALA-11562: Fix test unsupported text compression in s3
Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19119 )
Change subject: IMPALA-11646 IMPALA-11562: Fix test_unsupported_text_compression in s3
......................................................................
Patch Set 3:
> Patch Set 3:
>
> > Patch Set 3:
> >
> > > Patch Set 3: Code-Review+1
> > >
> > > Thanks for the prompt fix Michael! I do not have any other comment.
> > >
> > > I just like to check if my understanding in the following is correct after reading your fix and the corresponding functions.
> > >
> > > When the underlying storage is HDFS and we call filesystem_client.create_file() in test_unsupported_text_compression(), DelegatingHdfsClient::create_file() is called. In this case, DelegatingHdfsClient::_normalize_path() will be invoked. _normalize_path() removes the leading slash in the given path if there is any and then webhdfs_client.create_file() will be used to create the file.
> > >
> > > In your patch for IMPALA-11562, you removed the leading slash before calling filesystem_client.create_file(), which still works when the underlying storage is HDFS but doesn't work in s3 because HadoopFsCommandLineClient("S3") behaves a bit differently, i.e., it expects that leading slash, and thus this test failed.
> >
> > My understanding above is not completely accurate. IMPALA-11562 added that _normalize_path() in DelegatingHdfsClient. Thus test_unsupported_text_compression() has to be changed accordingly to pass the test in s3. IMPALA-11562 did not change test_unsupported_text_compression().
> >
> > Now I seem to understand this part of the Python test more. :-)
>
> Yes, tests were written to remove the leading slash, because DelegatingHdfsClient expected a path without slash, while the HadoopFsCommandLineClient would normalize the path by adding a leading slash if it was missing.
>
> For the Ozone work I started also using URIs with a schema, which would have complicated the HadoopFsCommandLineClient logic. I decided to invert what "normal" is, so you should now use absolute paths and DelegatingHdfsClient will normalize the path (by removing the leading slash) to fit the expectations of PyWebHdfsClient.
Thanks for the detailed explanation Michael!
--
To view, visit http://gerrit.cloudera.org:8080/19119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I74724b2d5af0bd879d92d5e5febe92d01c972525
Gerrit-Change-Number: 19119
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Oct 2022 16:56:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11646 IMPALA-11562: Fix test unsupported text compression in s3
Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19119 )
Change subject: IMPALA-11646 IMPALA-11562: Fix test_unsupported_text_compression in s3
......................................................................
Patch Set 3:
> Patch Set 3: Code-Review+1
>
> Thanks for the prompt fix Michael! I do not have any other comment.
>
> I just like to check if my understanding in the following is correct after reading your fix and the corresponding functions.
>
> When the underlying storage is HDFS and we call filesystem_client.create_file() in test_unsupported_text_compression(), DelegatingHdfsClient::create_file() is called. In this case, DelegatingHdfsClient::_normalize_path() will be invoked. _normalize_path() removes the leading slash in the given path if there is any and then webhdfs_client.create_file() will be used to create the file.
>
> In your patch for IMPALA-11562, you removed the leading slash before calling filesystem_client.create_file(), which still works when the underlying storage is HDFS but doesn't work in s3 because HadoopFsCommandLineClient("S3") behaves a bit differently, i.e., it expects that leading slash, and thus this test failed.
My understanding above is not completely accurate. IMPALA-11562 added that _normalize_path() in DelegatingHdfsClient. Thus test_unsupported_text_compression() has to be changed accordingly to pass the test in s3. IMPALA-11562 did not change test_unsupported_text_compression().
Now I seem to understand this part of the Python test more. :-)
--
To view, visit http://gerrit.cloudera.org:8080/19119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I74724b2d5af0bd879d92d5e5febe92d01c972525
Gerrit-Change-Number: 19119
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Oct 2022 05:36:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11646 IMPALA-11562: Fix test unsupported text compression in s3
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19119 )
Change subject: IMPALA-11646 IMPALA-11562: Fix test_unsupported_text_compression in s3
......................................................................
Patch Set 3:
> Patch Set 3:
>
> > Patch Set 3: Code-Review+1
> >
> > Thanks for the prompt fix Michael! I do not have any other comment.
> >
> > I just like to check if my understanding in the following is correct after reading your fix and the corresponding functions.
> >
> > When the underlying storage is HDFS and we call filesystem_client.create_file() in test_unsupported_text_compression(), DelegatingHdfsClient::create_file() is called. In this case, DelegatingHdfsClient::_normalize_path() will be invoked. _normalize_path() removes the leading slash in the given path if there is any and then webhdfs_client.create_file() will be used to create the file.
> >
> > In your patch for IMPALA-11562, you removed the leading slash before calling filesystem_client.create_file(), which still works when the underlying storage is HDFS but doesn't work in s3 because HadoopFsCommandLineClient("S3") behaves a bit differently, i.e., it expects that leading slash, and thus this test failed.
>
> My understanding above is not completely accurate. IMPALA-11562 added that _normalize_path() in DelegatingHdfsClient. Thus test_unsupported_text_compression() has to be changed accordingly to pass the test in s3. IMPALA-11562 did not change test_unsupported_text_compression().
>
> Now I seem to understand this part of the Python test more. :-)
Yes, tests were written to remove the leading slash, because DelegatingHdfsClient expected a path without slash, while the HadoopFsCommandLineClient would normalize the path by adding a leading slash if it was missing.
For the Ozone work I started also using URIs with a schema, which would have complicated the HadoopFsCommandLineClient logic. I decided to invert what "normal" is, so you should now use absolute paths and DelegatingHdfsClient will normalize the path (by removing the leading slash) to fit the expectations of PyWebHdfsClient.
--
To view, visit http://gerrit.cloudera.org:8080/19119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I74724b2d5af0bd879d92d5e5febe92d01c972525
Gerrit-Change-Number: 19119
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Oct 2022 16:17:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11646 IMPALA-11562: Fix test unsupported text compression in s3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19119 )
Change subject: IMPALA-11646 IMPALA-11562: Fix test_unsupported_text_compression in s3
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8695/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/19119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I74724b2d5af0bd879d92d5e5febe92d01c972525
Gerrit-Change-Number: 19119
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Oct 2022 16:47:41 +0000
Gerrit-HasComments: No