You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/07/30 12:16:39 UTC

[GitHub] [airflow] ashb opened a new pull request #5684: [AIRFLOW-XXX] Remove default/wrong values from test config.

ashb opened a new pull request #5684: [AIRFLOW-XXX] Remove default/wrong values from test config.
URL: https://github.com/apache/airflow/pull/5684
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] No Jira.
   
   ### Description
   
   - [x] Most of the values I've removed here are the current defaults, so we don't need to specify them again.
   
     The reason I am removing them is that `email_backend` of `airflow.utils.send_email_smtp` has been incorrect since 1.7.2(!) but hasn't mattered until #5379 somehow triggered it. By removing the default values it should make it easier to update in future.  
   
   ### Tests
   
   - [x] No tests, but should still pass :)
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services