You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/17 17:06:43 UTC
[GitHub] [flink] zhijiangW commented on a change in pull request #11786:
[FLINK-17208][network] Reduce redundant data available notifications of
PipelinedSubpartition
zhijiangW commented on a change in pull request #11786: [FLINK-17208][network] Reduce redundant data available notifications of PipelinedSubpartition
URL: https://github.com/apache/flink/pull/11786#discussion_r410355482
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -434,15 +445,12 @@ public int getBuffersInBacklog() {
}
}
- private boolean shouldNotifyDataAvailable() {
- // Notify only when we added first finished buffer.
- return readView != null && !flushRequested && getNumberOfFinishedBuffers() == 1;
+ private boolean mayNotifyDataAvailable() {
Review comment:
`mayNotifyDataAvailable` seems fit for `void` return type. I prefer to previous `shouldNotifyDataAvailable` which more fits for `boolean` return type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services