You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Gili (JIRA)" <ji...@apache.org> on 2007/06/29 05:38:04 UTC
[jira] Created: (WICKET-711) Remove log4j dependency
Remove log4j dependency
-----------------------
Key: WICKET-711
URL: https://issues.apache.org/jira/browse/WICKET-711
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.3.0-beta1
Reporter: Gili
Please consider removing Wicket's dependency on log4j. This can be achieved quite easily by replacing slf-log4j*.jar by slf4j-simple*.jar. The application footprint will shrink and all those ClassLoader problems log4j is notorious for will go away: http://www.qos.ch/logging/classloader.jsp
Finally, I recommend you consider migrating to logback, which is a native implementation of slf4j by the author of log4j: http://logback.qos.ch/
It's logging performance and output format is above and beyond what log4j provides. Once you try it you'll fall in love with the output format. Just my 2 cents :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (WICKET-711) Remove log4j dependency
Posted by "Gwyn Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gwyn Evans closed WICKET-711.
-----------------------------
Resolution: Invalid
Fix Version/s: 1.3.0-beta3
The 'main' code doesn't have the suggested dependancies on log4j - it's up to the user to choose which slf4j impl to use log4j, logback, simple-log or whatever they want - Wicket /doesn't/ mandate or even default to any.
> Remove log4j dependency
> -----------------------
>
> Key: WICKET-711
> URL: https://issues.apache.org/jira/browse/WICKET-711
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta1
> Reporter: Gili
> Priority: Trivial
> Fix For: 1.3.0-beta3
>
>
> Please consider removing Wicket's dependency on log4j. This can be achieved quite easily by replacing slf-log4j*.jar by slf4j-simple*.jar. The application footprint will shrink and all those ClassLoader problems log4j is notorious for will go away: http://www.qos.ch/logging/classloader.jsp
> Finally, I recommend you consider migrating to logback, which is a native implementation of slf4j by the author of log4j: http://logback.qos.ch/
> It's logging performance and output format is above and beyond what log4j provides. Once you try it you'll fall in love with the output format. Just my 2 cents :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-711) Remove log4j dependency
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509102 ]
Johan Compagner commented on WICKET-711:
----------------------------------------
what does it matter what examples uses?
performance of the logger? why would that be importand for a example project?
i am perfectly fine with Log4J in our examples. But if somebody wants to see something different they can patch and configure it for us.
> Remove log4j dependency
> -----------------------
>
> Key: WICKET-711
> URL: https://issues.apache.org/jira/browse/WICKET-711
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta1
> Reporter: Gili
>
> Please consider removing Wicket's dependency on log4j. This can be achieved quite easily by replacing slf-log4j*.jar by slf4j-simple*.jar. The application footprint will shrink and all those ClassLoader problems log4j is notorious for will go away: http://www.qos.ch/logging/classloader.jsp
> Finally, I recommend you consider migrating to logback, which is a native implementation of slf4j by the author of log4j: http://logback.qos.ch/
> It's logging performance and output format is above and beyond what log4j provides. Once you try it you'll fall in love with the output format. Just my 2 cents :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-711) Remove log4j dependency
Posted by "Gili (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509096 ]
Gili commented on WICKET-711:
-----------------------------
Agreed, examples has dependency, not core. Would it be possible to remove this dependency (lower the priority if needed)?
Gwyn, there are two reasons I would push for logback:
1) Superior logging format
2) Better performance
Here is a quote for #2: "Certain critical operations, for instance determining whether a log statement should be logged or not, has been significantly improved. This operation takes about 3 nanoseconds in logback versus 30 nanoseconds in log4j. Logback also creates loggers faster : 13 microseconds instead versus 23 microseconds for log4j. More importantly, it fetches an existing logger in 94 nanoseconds versus 2234 nanoseconds for log4j, a 23 fold improvement. The improvement over JUL is also far from insignificant."
I wish I could find you some reference output so you see what I mean for #1... Off the top of my head by default you get the current thread name when logging and if the log line is too long logback automatically collapses package names down to single characters (so long as they are unique) so the log is easier to read while containing even more useful information.
PS: I love the user manual of SimpleLog :) Very witty!
> Remove log4j dependency
> -----------------------
>
> Key: WICKET-711
> URL: https://issues.apache.org/jira/browse/WICKET-711
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta1
> Reporter: Gili
>
> Please consider removing Wicket's dependency on log4j. This can be achieved quite easily by replacing slf-log4j*.jar by slf4j-simple*.jar. The application footprint will shrink and all those ClassLoader problems log4j is notorious for will go away: http://www.qos.ch/logging/classloader.jsp
> Finally, I recommend you consider migrating to logback, which is a native implementation of slf4j by the author of log4j: http://logback.qos.ch/
> It's logging performance and output format is above and beyond what log4j provides. Once you try it you'll fall in love with the output format. Just my 2 cents :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-711) Remove log4j dependency
Posted by "Gili (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509108 ]
Gili commented on WICKET-711:
-----------------------------
Here is a blog that contains sample output from logback and some discussion of performance benefits: http://xhab.blogspot.com/2007/03/new-logging-experience.html
> Remove log4j dependency
> -----------------------
>
> Key: WICKET-711
> URL: https://issues.apache.org/jira/browse/WICKET-711
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta1
> Reporter: Gili
> Priority: Trivial
>
> Please consider removing Wicket's dependency on log4j. This can be achieved quite easily by replacing slf-log4j*.jar by slf4j-simple*.jar. The application footprint will shrink and all those ClassLoader problems log4j is notorious for will go away: http://www.qos.ch/logging/classloader.jsp
> Finally, I recommend you consider migrating to logback, which is a native implementation of slf4j by the author of log4j: http://logback.qos.ch/
> It's logging performance and output format is above and beyond what log4j provides. Once you try it you'll fall in love with the output format. Just my 2 cents :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-711) Remove log4j dependency
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509058 ]
Johan Compagner commented on WICKET-711:
----------------------------------------
yes only examples has log4j dependency and that is just fine.
all core wicket only have the api of sl4j as far as i know.
so i guess this issue can be closed? But maybe pom guru's martijn and almaw have a thought?
> Remove log4j dependency
> -----------------------
>
> Key: WICKET-711
> URL: https://issues.apache.org/jira/browse/WICKET-711
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta1
> Reporter: Gili
>
> Please consider removing Wicket's dependency on log4j. This can be achieved quite easily by replacing slf-log4j*.jar by slf4j-simple*.jar. The application footprint will shrink and all those ClassLoader problems log4j is notorious for will go away: http://www.qos.ch/logging/classloader.jsp
> Finally, I recommend you consider migrating to logback, which is a native implementation of slf4j by the author of log4j: http://logback.qos.ch/
> It's logging performance and output format is above and beyond what log4j provides. Once you try it you'll fall in love with the output format. Just my 2 cents :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-711) Remove log4j dependency
Posted by "Gwyn Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509052 ]
Gwyn Evans commented on WICKET-711:
-----------------------------------
As far as I can see, Wicket builds with slf4j-api and it's up to the user to choose the implemtantion they want at run-time, so *what* dependency on log4j? File/line details?
Left open (for the moment) in case I'm missing, something.
/Gwyn
> Remove log4j dependency
> -----------------------
>
> Key: WICKET-711
> URL: https://issues.apache.org/jira/browse/WICKET-711
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta1
> Reporter: Gili
>
> Please consider removing Wicket's dependency on log4j. This can be achieved quite easily by replacing slf-log4j*.jar by slf4j-simple*.jar. The application footprint will shrink and all those ClassLoader problems log4j is notorious for will go away: http://www.qos.ch/logging/classloader.jsp
> Finally, I recommend you consider migrating to logback, which is a native implementation of slf4j by the author of log4j: http://logback.qos.ch/
> It's logging performance and output format is above and beyond what log4j provides. Once you try it you'll fall in love with the output format. Just my 2 cents :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-711) Remove log4j dependency
Posted by "Gwyn Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509057 ]
Gwyn Evans commented on WICKET-711:
-----------------------------------
Incidentally, Gili, is you want a small footprint, take a look at https://simple-log.dev.java.net/, which doesn't require a major manual! It also blows away logback's claim to be "a smaller footprint than all existing logging systems"
> Remove log4j dependency
> -----------------------
>
> Key: WICKET-711
> URL: https://issues.apache.org/jira/browse/WICKET-711
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta1
> Reporter: Gili
>
> Please consider removing Wicket's dependency on log4j. This can be achieved quite easily by replacing slf-log4j*.jar by slf4j-simple*.jar. The application footprint will shrink and all those ClassLoader problems log4j is notorious for will go away: http://www.qos.ch/logging/classloader.jsp
> Finally, I recommend you consider migrating to logback, which is a native implementation of slf4j by the author of log4j: http://logback.qos.ch/
> It's logging performance and output format is above and beyond what log4j provides. Once you try it you'll fall in love with the output format. Just my 2 cents :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-711) Remove log4j dependency
Posted by "Gwyn Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509165 ]
Gwyn Evans commented on WICKET-711:
-----------------------------------
Ignoring examples (as it's just an /example/ project),
1) we *don't* have any dependcancy on Log4J
2) We build to the slf4j *api*, not any implementation
It's arguable that we should supply a default impl in the quickstart, but that's another issue (literally - open a new one if you want to raise that,.)
> Remove log4j dependency
> -----------------------
>
> Key: WICKET-711
> URL: https://issues.apache.org/jira/browse/WICKET-711
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta1
> Reporter: Gili
> Priority: Trivial
>
> Please consider removing Wicket's dependency on log4j. This can be achieved quite easily by replacing slf-log4j*.jar by slf4j-simple*.jar. The application footprint will shrink and all those ClassLoader problems log4j is notorious for will go away: http://www.qos.ch/logging/classloader.jsp
> Finally, I recommend you consider migrating to logback, which is a native implementation of slf4j by the author of log4j: http://logback.qos.ch/
> It's logging performance and output format is above and beyond what log4j provides. Once you try it you'll fall in love with the output format. Just my 2 cents :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-711) Remove log4j dependency
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Compagner updated WICKET-711:
-----------------------------------
Priority: Trivial (was: Major)
> Remove log4j dependency
> -----------------------
>
> Key: WICKET-711
> URL: https://issues.apache.org/jira/browse/WICKET-711
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta1
> Reporter: Gili
> Priority: Trivial
>
> Please consider removing Wicket's dependency on log4j. This can be achieved quite easily by replacing slf-log4j*.jar by slf4j-simple*.jar. The application footprint will shrink and all those ClassLoader problems log4j is notorious for will go away: http://www.qos.ch/logging/classloader.jsp
> Finally, I recommend you consider migrating to logback, which is a native implementation of slf4j by the author of log4j: http://logback.qos.ch/
> It's logging performance and output format is above and beyond what log4j provides. Once you try it you'll fall in love with the output format. Just my 2 cents :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-711) Remove log4j dependency
Posted by "Gili (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509103 ]
Gili commented on WICKET-711:
-----------------------------
To clarify I am pushing two completely independent (though somewhat related) issues here:
1) Remove any dependecy on log4j because it causes ClassLoader issues (especially when mixed with Tomcat)
2) Consider bundling logback as the default slf4j implementation for the reasons mentioned above. Users can still switch to another implementation of their liking if necessary.
> Remove log4j dependency
> -----------------------
>
> Key: WICKET-711
> URL: https://issues.apache.org/jira/browse/WICKET-711
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta1
> Reporter: Gili
> Priority: Trivial
>
> Please consider removing Wicket's dependency on log4j. This can be achieved quite easily by replacing slf-log4j*.jar by slf4j-simple*.jar. The application footprint will shrink and all those ClassLoader problems log4j is notorious for will go away: http://www.qos.ch/logging/classloader.jsp
> Finally, I recommend you consider migrating to logback, which is a native implementation of slf4j by the author of log4j: http://logback.qos.ch/
> It's logging performance and output format is above and beyond what log4j provides. Once you try it you'll fall in love with the output format. Just my 2 cents :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.