[GitHub] [skywalking-satellite] wu-sheng commented on a change in pull request #82: Support partition queue

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #82:
URL: https://github.com/apache/skywalking-satellite/pull/82#discussion_r745532386



##########
File path: configs/satellite_config.yaml
##########
@@ -103,6 +105,8 @@ pipes:
         plugin_name: "memory-queue"
         # The maximum buffer event size.
         event_buffer_size: ${SATELLITE_QUEUE_EVENT_BUFFER_SIZE:5000}
+        # The partition count of queue.
+        partition_count: ${SATELLITE_QUEUE_PARTITION_COUNT:1}

Review comment:
       Remove count. Partition is enough.

##########
File path: docs/en/setup/examples/high-throughput-queue/README.md
##########
@@ -0,0 +1,19 @@
+# High throughput queue
+
+High throughput queues can send messages to multiple channels using by `round-robin` policy for load-balance, and consume messages from each queue in parallel.
+This prevents the single-threaded sender from performing network IO, blocking the `recieve`/`fetch`/`consumer` to the queue.

Review comment:
       Receiver and fetcher.

##########
File path: docs/en/setup/plugins/queue_mmap-queue.md
##########
@@ -15,6 +15,9 @@ flush_period: 1000
 flush_ceiling_num: 10000
 # The max size of the input event. Default value is 20k.
 max_event_size: 20480
+
+# The partition count of queue.
+partition_count: 1

Review comment:
       mmap queue supports partitions?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org