You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ki...@apache.org on 2013/02/12 01:47:23 UTC
svn commit: r1445005 - /commons/proper/functor/trunk/api/pom.xml
Author: kinow
Date: Tue Feb 12 00:47:23 2013
New Revision: 1445005
URL: http://svn.apache.org/r1445005
Log:
Remove duplicated groupId
Modified:
commons/proper/functor/trunk/api/pom.xml
Modified: commons/proper/functor/trunk/api/pom.xml
URL: http://svn.apache.org/viewvc/commons/proper/functor/trunk/api/pom.xml?rev=1445005&r1=1445004&r2=1445005&view=diff
==============================================================================
--- commons/proper/functor/trunk/api/pom.xml (original)
+++ commons/proper/functor/trunk/api/pom.xml Tue Feb 12 00:47:23 2013
@@ -22,7 +22,6 @@
<artifactId>commons-functor-parent</artifactId>
<version>1.0-SNAPSHOT</version>
</parent>
- <groupId>org.apache.commons</groupId>
<artifactId>commons-functor-api</artifactId>
<name>Commons Functor API</name>
<description>Provide the basic APIs</description>
Re: svn commit: r1445005 - /commons/proper/functor/trunk/api/pom.xml
Posted by sebb <se...@gmail.com>.
On 12 February 2013 20:42, Matt Benson <gu...@gmail.com> wrote:
> Wait, now I think we're all getting out of sync with one another. :) I
> can respect Sebastian's point that a Commons component's "top" pom
> explicitly declare the groupId, particularly in light of his willingness to
> omit it from any subordinate modules, so actually the change that
> precipitated this whole discussion should stand. The groupId should then
> be explicitly added to commons-functor-parent, and can be removed from any
> child modules including build-tools.
I had not noticed that the pom in question was a module pom.
I agree that only the top-level component pom needs the groupId.
And it's then safer if the modules don't (re)define the groupId
(provided that they chain back to the top-level pom of course).
> Matt
>
>
> On Mon, Feb 11, 2013 at 6:47 PM, <ki...@apache.org> wrote:
>
>> Author: kinow
>> Date: Tue Feb 12 00:47:23 2013
>> New Revision: 1445005
>>
>> URL: http://svn.apache.org/r1445005
>> Log:
>> Remove duplicated groupId
>>
>> Modified:
>> commons/proper/functor/trunk/api/pom.xml
>>
>> Modified: commons/proper/functor/trunk/api/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/commons/proper/functor/trunk/api/pom.xml?rev=1445005&r1=1445004&r2=1445005&view=diff
>>
>> ==============================================================================
>> --- commons/proper/functor/trunk/api/pom.xml (original)
>> +++ commons/proper/functor/trunk/api/pom.xml Tue Feb 12 00:47:23 2013
>> @@ -22,7 +22,6 @@
>> <artifactId>commons-functor-parent</artifactId>
>> <version>1.0-SNAPSHOT</version>
>> </parent>
>> - <groupId>org.apache.commons</groupId>
>> <artifactId>commons-functor-api</artifactId>
>> <name>Commons Functor API</name>
>> <description>Provide the basic APIs</description>
>>
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1445005 - /commons/proper/functor/trunk/api/pom.xml
Posted by sebb <se...@gmail.com>.
On 12 February 2013 21:09, Matt Benson <gu...@gmail.com> wrote:
> I think Seb and I are in agreement to add groupId to commons-functor-parent
> and remove it from every module pom beneath.
Yes.
Luckily functor has yet to be released so it won't matter if any of
the groupIds disagree ...
> Matt
>
>
> On Tue, Feb 12, 2013 at 3:00 PM, Bruno P. Kinoshita <
> brunodepaulak@yahoo.com.br> wrote:
>
>> Ops, note to self: see the parent pom before posting to the mailing list
>> or committing to SVN :) Sorry, I thought commons-functor-parent had already
>> a groupId.
>>
>> Let me know what is the best choice then, and I'll update the trunk.
>>
>> Cheers
>>
>> Bruno P. Kinoshita
>> http://kinoshita.eti.br
>> http://tupilabs.com
>>
>>
>> ----- Original Message -----
>> > From: Matt Benson <gu...@gmail.com>
>> > To: dev@commons.apache.org
>> > Cc: commits@commons.apache.org
>> > Sent: Tuesday, February 12, 2013 6:42 PM
>> > Subject: Re: svn commit: r1445005 -
>> /commons/proper/functor/trunk/api/pom.xml
>> >
>> > Wait, now I think we're all getting out of sync with one another. :) I
>> > can respect Sebastian's point that a Commons component's "top"
>> > pom
>> > explicitly declare the groupId, particularly in light of his willingness
>> to
>> > omit it from any subordinate modules, so actually the change that
>> > precipitated this whole discussion should stand. The groupId should then
>> > be explicitly added to commons-functor-parent, and can be removed from
>> any
>> > child modules including build-tools.
>> >
>> > Matt
>> >
>> >
>> > On Mon, Feb 11, 2013 at 6:47 PM, <ki...@apache.org> wrote:
>> >
>> >> Author: kinow
>> >> Date: Tue Feb 12 00:47:23 2013
>> >> New Revision: 1445005
>> >>
>> >> URL: http://svn.apache.org/r1445005
>> >> Log:
>> >> Remove duplicated groupId
>> >>
>> >> Modified:
>> >> commons/proper/functor/trunk/api/pom.xml
>> >>
>> >> Modified: commons/proper/functor/trunk/api/pom.xml
>> >> URL:
>> >>
>> >
>> http://svn.apache.org/viewvc/commons/proper/functor/trunk/api/pom.xml?rev=1445005&r1=1445004&r2=1445005&view=diff
>> >>
>> >>
>> >
>> ==============================================================================
>> >> --- commons/proper/functor/trunk/api/pom.xml (original)
>> >> +++ commons/proper/functor/trunk/api/pom.xml Tue Feb 12 00:47:23 2013
>> >> @@ -22,7 +22,6 @@
>> >> <artifactId>commons-functor-parent</artifactId>
>> >> <version>1.0-SNAPSHOT</version>
>> >> </parent>
>> >> - <groupId>org.apache.commons</groupId>
>> >> <artifactId>commons-functor-api</artifactId>
>> >> <name>Commons Functor API</name>
>> >> <description>Provide the basic APIs</description>
>> >>
>> >>
>> >>
>> >
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1445005 - /commons/proper/functor/trunk/api/pom.xml
Posted by Matt Benson <gu...@gmail.com>.
I think Seb and I are in agreement to add groupId to commons-functor-parent
and remove it from every module pom beneath.
Matt
On Tue, Feb 12, 2013 at 3:00 PM, Bruno P. Kinoshita <
brunodepaulak@yahoo.com.br> wrote:
> Ops, note to self: see the parent pom before posting to the mailing list
> or committing to SVN :) Sorry, I thought commons-functor-parent had already
> a groupId.
>
> Let me know what is the best choice then, and I'll update the trunk.
>
> Cheers
>
> Bruno P. Kinoshita
> http://kinoshita.eti.br
> http://tupilabs.com
>
>
> ----- Original Message -----
> > From: Matt Benson <gu...@gmail.com>
> > To: dev@commons.apache.org
> > Cc: commits@commons.apache.org
> > Sent: Tuesday, February 12, 2013 6:42 PM
> > Subject: Re: svn commit: r1445005 -
> /commons/proper/functor/trunk/api/pom.xml
> >
> > Wait, now I think we're all getting out of sync with one another. :) I
> > can respect Sebastian's point that a Commons component's "top"
> > pom
> > explicitly declare the groupId, particularly in light of his willingness
> to
> > omit it from any subordinate modules, so actually the change that
> > precipitated this whole discussion should stand. The groupId should then
> > be explicitly added to commons-functor-parent, and can be removed from
> any
> > child modules including build-tools.
> >
> > Matt
> >
> >
> > On Mon, Feb 11, 2013 at 6:47 PM, <ki...@apache.org> wrote:
> >
> >> Author: kinow
> >> Date: Tue Feb 12 00:47:23 2013
> >> New Revision: 1445005
> >>
> >> URL: http://svn.apache.org/r1445005
> >> Log:
> >> Remove duplicated groupId
> >>
> >> Modified:
> >> commons/proper/functor/trunk/api/pom.xml
> >>
> >> Modified: commons/proper/functor/trunk/api/pom.xml
> >> URL:
> >>
> >
> http://svn.apache.org/viewvc/commons/proper/functor/trunk/api/pom.xml?rev=1445005&r1=1445004&r2=1445005&view=diff
> >>
> >>
> >
> ==============================================================================
> >> --- commons/proper/functor/trunk/api/pom.xml (original)
> >> +++ commons/proper/functor/trunk/api/pom.xml Tue Feb 12 00:47:23 2013
> >> @@ -22,7 +22,6 @@
> >> <artifactId>commons-functor-parent</artifactId>
> >> <version>1.0-SNAPSHOT</version>
> >> </parent>
> >> - <groupId>org.apache.commons</groupId>
> >> <artifactId>commons-functor-api</artifactId>
> >> <name>Commons Functor API</name>
> >> <description>Provide the basic APIs</description>
> >>
> >>
> >>
> >
>
Re: svn commit: r1445005 - /commons/proper/functor/trunk/api/pom.xml
Posted by sebb <se...@gmail.com>.
On 12 February 2013 21:38, Bruno P. Kinoshita <ki...@apache.org> wrote:
>> It looks like functor has not yet been released, so we have free
>> choice over groupId (and artifactId).
>
> Exactly, that's why we're also starting threads about serialization, default arity, interfaces nomenclature, etc :o)
>
>> We should use org.apache.commons for the groupId.
>
>
> Done in r1445397. build-tools was also overriding the parent version, so I removed too. I hope I didn't make any mistakes now.
It only makes sense to default to the component top-level pom if the
module pom has the top-level pom as its parent.
That is not the case for the build-tools module.
I don't know if it's possible to change the parent; if not, there can
be no defaulting of groupId etc.
> Thanks!
>
> [1] http://svn.apache.org/viewvc?view=revision&revision=r1445397
>
> Bruno P. Kinoshita
> http://kinoshita.eti.br
> http://tupilabs.com
>
>
> ----- Original Message -----
>> From: sebb <se...@gmail.com>
>> To: Commons Developers List <de...@commons.apache.org>
>> Cc:
>> Sent: Tuesday, February 12, 2013 7:09 PM
>> Subject: Re: svn commit: r1445005 - /commons/proper/functor/trunk/api/pom.xml
>>
>> On 12 February 2013 21:00, Bruno P. Kinoshita
>> <br...@yahoo.com.br> wrote:
>>> Ops, note to self: see the parent pom before posting to the mailing list or
>> committing to SVN :) Sorry, I thought commons-functor-parent had already a
>> groupId.
>>>
>>> Let me know what is the best choice then, and I'll update the trunk.
>>
>> It looks like functor has not yet been released, so we have free
>> choice over groupId (and artifactId).
>>
>> We should use org.apache.commons for the groupId.
>>
>>> Cheers
>>>
>>> Bruno P. Kinoshita
>>> http://kinoshita.eti.br
>>> http://tupilabs.com
>>>
>>>
>>> ----- Original Message -----
>>>> From: Matt Benson <gu...@gmail.com>
>>>> To: dev@commons.apache.org
>>>> Cc: commits@commons.apache.org
>>>> Sent: Tuesday, February 12, 2013 6:42 PM
>>>> Subject: Re: svn commit: r1445005 -
>> /commons/proper/functor/trunk/api/pom.xml
>>>>
>>>> Wait, now I think we're all getting out of sync with one another.
>> :) I
>>>> can respect Sebastian's point that a Commons component's
>> "top"
>>>> pom
>>>> explicitly declare the groupId, particularly in light of his
>> willingness to
>>>> omit it from any subordinate modules, so actually the change that
>>>> precipitated this whole discussion should stand. The groupId should
>> then
>>>> be explicitly added to commons-functor-parent, and can be removed from
>> any
>>>> child modules including build-tools.
>>>>
>>>> Matt
>>>>
>>>>
>>>> On Mon, Feb 11, 2013 at 6:47 PM, <ki...@apache.org> wrote:
>>>>
>>>>> Author: kinow
>>>>> Date: Tue Feb 12 00:47:23 2013
>>>>> New Revision: 1445005
>>>>>
>>>>> URL: http://svn.apache.org/r1445005
>>>>> Log:
>>>>> Remove duplicated groupId
>>>>>
>>>>> Modified:
>>>>> commons/proper/functor/trunk/api/pom.xml
>>>>>
>>>>> Modified: commons/proper/functor/trunk/api/pom.xml
>>>>> URL:
>>>>>
>>>>
>> http://svn.apache.org/viewvc/commons/proper/functor/trunk/api/pom.xml?rev=1445005&r1=1445004&r2=1445005&view=diff
>>>>>
>>>>>
>>>>
>> ==============================================================================
>>>>> --- commons/proper/functor/trunk/api/pom.xml (original)
>>>>> +++ commons/proper/functor/trunk/api/pom.xml Tue Feb 12 00:47:23
>> 2013
>>>>> @@ -22,7 +22,6 @@
>>>>> <artifactId>commons-functor-parent</artifactId>
>>>>> <version>1.0-SNAPSHOT</version>
>>>>> </parent>
>>>>> - <groupId>org.apache.commons</groupId>
>>>>> <artifactId>commons-functor-api</artifactId>
>>>>> <name>Commons Functor API</name>
>>>>> <description>Provide the basic APIs</description>
>>>>>
>>>>>
>>>>>
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1445005 - /commons/proper/functor/trunk/api/pom.xml
Posted by "Bruno P. Kinoshita" <ki...@apache.org>.
> It looks like functor has not yet been released, so we have free
> choice over groupId (and artifactId).
Exactly, that's why we're also starting threads about serialization, default arity, interfaces nomenclature, etc :o)
> We should use org.apache.commons for the groupId.
Done in r1445397. build-tools was also overriding the parent version, so I removed too. I hope I didn't make any mistakes now.
Thanks!
[1] http://svn.apache.org/viewvc?view=revision&revision=r1445397
Bruno P. Kinoshita
http://kinoshita.eti.br
http://tupilabs.com
----- Original Message -----
> From: sebb <se...@gmail.com>
> To: Commons Developers List <de...@commons.apache.org>
> Cc:
> Sent: Tuesday, February 12, 2013 7:09 PM
> Subject: Re: svn commit: r1445005 - /commons/proper/functor/trunk/api/pom.xml
>
> On 12 February 2013 21:00, Bruno P. Kinoshita
> <br...@yahoo.com.br> wrote:
>> Ops, note to self: see the parent pom before posting to the mailing list or
> committing to SVN :) Sorry, I thought commons-functor-parent had already a
> groupId.
>>
>> Let me know what is the best choice then, and I'll update the trunk.
>
> It looks like functor has not yet been released, so we have free
> choice over groupId (and artifactId).
>
> We should use org.apache.commons for the groupId.
>
>> Cheers
>>
>> Bruno P. Kinoshita
>> http://kinoshita.eti.br
>> http://tupilabs.com
>>
>>
>> ----- Original Message -----
>>> From: Matt Benson <gu...@gmail.com>
>>> To: dev@commons.apache.org
>>> Cc: commits@commons.apache.org
>>> Sent: Tuesday, February 12, 2013 6:42 PM
>>> Subject: Re: svn commit: r1445005 -
> /commons/proper/functor/trunk/api/pom.xml
>>>
>>> Wait, now I think we're all getting out of sync with one another.
> :) I
>>> can respect Sebastian's point that a Commons component's
> "top"
>>> pom
>>> explicitly declare the groupId, particularly in light of his
> willingness to
>>> omit it from any subordinate modules, so actually the change that
>>> precipitated this whole discussion should stand. The groupId should
> then
>>> be explicitly added to commons-functor-parent, and can be removed from
> any
>>> child modules including build-tools.
>>>
>>> Matt
>>>
>>>
>>> On Mon, Feb 11, 2013 at 6:47 PM, <ki...@apache.org> wrote:
>>>
>>>> Author: kinow
>>>> Date: Tue Feb 12 00:47:23 2013
>>>> New Revision: 1445005
>>>>
>>>> URL: http://svn.apache.org/r1445005
>>>> Log:
>>>> Remove duplicated groupId
>>>>
>>>> Modified:
>>>> commons/proper/functor/trunk/api/pom.xml
>>>>
>>>> Modified: commons/proper/functor/trunk/api/pom.xml
>>>> URL:
>>>>
>>>
> http://svn.apache.org/viewvc/commons/proper/functor/trunk/api/pom.xml?rev=1445005&r1=1445004&r2=1445005&view=diff
>>>>
>>>>
>>>
> ==============================================================================
>>>> --- commons/proper/functor/trunk/api/pom.xml (original)
>>>> +++ commons/proper/functor/trunk/api/pom.xml Tue Feb 12 00:47:23
> 2013
>>>> @@ -22,7 +22,6 @@
>>>> <artifactId>commons-functor-parent</artifactId>
>>>> <version>1.0-SNAPSHOT</version>
>>>> </parent>
>>>> - <groupId>org.apache.commons</groupId>
>>>> <artifactId>commons-functor-api</artifactId>
>>>> <name>Commons Functor API</name>
>>>> <description>Provide the basic APIs</description>
>>>>
>>>>
>>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1445005 - /commons/proper/functor/trunk/api/pom.xml
Posted by sebb <se...@gmail.com>.
On 12 February 2013 21:00, Bruno P. Kinoshita
<br...@yahoo.com.br> wrote:
> Ops, note to self: see the parent pom before posting to the mailing list or committing to SVN :) Sorry, I thought commons-functor-parent had already a groupId.
>
> Let me know what is the best choice then, and I'll update the trunk.
It looks like functor has not yet been released, so we have free
choice over groupId (and artifactId).
We should use org.apache.commons for the groupId.
> Cheers
>
> Bruno P. Kinoshita
> http://kinoshita.eti.br
> http://tupilabs.com
>
>
> ----- Original Message -----
>> From: Matt Benson <gu...@gmail.com>
>> To: dev@commons.apache.org
>> Cc: commits@commons.apache.org
>> Sent: Tuesday, February 12, 2013 6:42 PM
>> Subject: Re: svn commit: r1445005 - /commons/proper/functor/trunk/api/pom.xml
>>
>> Wait, now I think we're all getting out of sync with one another. :) I
>> can respect Sebastian's point that a Commons component's "top"
>> pom
>> explicitly declare the groupId, particularly in light of his willingness to
>> omit it from any subordinate modules, so actually the change that
>> precipitated this whole discussion should stand. The groupId should then
>> be explicitly added to commons-functor-parent, and can be removed from any
>> child modules including build-tools.
>>
>> Matt
>>
>>
>> On Mon, Feb 11, 2013 at 6:47 PM, <ki...@apache.org> wrote:
>>
>>> Author: kinow
>>> Date: Tue Feb 12 00:47:23 2013
>>> New Revision: 1445005
>>>
>>> URL: http://svn.apache.org/r1445005
>>> Log:
>>> Remove duplicated groupId
>>>
>>> Modified:
>>> commons/proper/functor/trunk/api/pom.xml
>>>
>>> Modified: commons/proper/functor/trunk/api/pom.xml
>>> URL:
>>>
>> http://svn.apache.org/viewvc/commons/proper/functor/trunk/api/pom.xml?rev=1445005&r1=1445004&r2=1445005&view=diff
>>>
>>>
>> ==============================================================================
>>> --- commons/proper/functor/trunk/api/pom.xml (original)
>>> +++ commons/proper/functor/trunk/api/pom.xml Tue Feb 12 00:47:23 2013
>>> @@ -22,7 +22,6 @@
>>> <artifactId>commons-functor-parent</artifactId>
>>> <version>1.0-SNAPSHOT</version>
>>> </parent>
>>> - <groupId>org.apache.commons</groupId>
>>> <artifactId>commons-functor-api</artifactId>
>>> <name>Commons Functor API</name>
>>> <description>Provide the basic APIs</description>
>>>
>>>
>>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1445005 - /commons/proper/functor/trunk/api/pom.xml
Posted by "Bruno P. Kinoshita" <br...@yahoo.com.br>.
Ops, note to self: see the parent pom before posting to the mailing list or committing to SVN :) Sorry, I thought commons-functor-parent had already a groupId.
Let me know what is the best choice then, and I'll update the trunk.
Cheers
Bruno P. Kinoshita
http://kinoshita.eti.br
http://tupilabs.com
----- Original Message -----
> From: Matt Benson <gu...@gmail.com>
> To: dev@commons.apache.org
> Cc: commits@commons.apache.org
> Sent: Tuesday, February 12, 2013 6:42 PM
> Subject: Re: svn commit: r1445005 - /commons/proper/functor/trunk/api/pom.xml
>
> Wait, now I think we're all getting out of sync with one another. :) I
> can respect Sebastian's point that a Commons component's "top"
> pom
> explicitly declare the groupId, particularly in light of his willingness to
> omit it from any subordinate modules, so actually the change that
> precipitated this whole discussion should stand. The groupId should then
> be explicitly added to commons-functor-parent, and can be removed from any
> child modules including build-tools.
>
> Matt
>
>
> On Mon, Feb 11, 2013 at 6:47 PM, <ki...@apache.org> wrote:
>
>> Author: kinow
>> Date: Tue Feb 12 00:47:23 2013
>> New Revision: 1445005
>>
>> URL: http://svn.apache.org/r1445005
>> Log:
>> Remove duplicated groupId
>>
>> Modified:
>> commons/proper/functor/trunk/api/pom.xml
>>
>> Modified: commons/proper/functor/trunk/api/pom.xml
>> URL:
>>
> http://svn.apache.org/viewvc/commons/proper/functor/trunk/api/pom.xml?rev=1445005&r1=1445004&r2=1445005&view=diff
>>
>>
> ==============================================================================
>> --- commons/proper/functor/trunk/api/pom.xml (original)
>> +++ commons/proper/functor/trunk/api/pom.xml Tue Feb 12 00:47:23 2013
>> @@ -22,7 +22,6 @@
>> <artifactId>commons-functor-parent</artifactId>
>> <version>1.0-SNAPSHOT</version>
>> </parent>
>> - <groupId>org.apache.commons</groupId>
>> <artifactId>commons-functor-api</artifactId>
>> <name>Commons Functor API</name>
>> <description>Provide the basic APIs</description>
>>
>>
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1445005 - /commons/proper/functor/trunk/api/pom.xml
Posted by Matt Benson <gu...@gmail.com>.
Wait, now I think we're all getting out of sync with one another. :) I
can respect Sebastian's point that a Commons component's "top" pom
explicitly declare the groupId, particularly in light of his willingness to
omit it from any subordinate modules, so actually the change that
precipitated this whole discussion should stand. The groupId should then
be explicitly added to commons-functor-parent, and can be removed from any
child modules including build-tools.
Matt
On Mon, Feb 11, 2013 at 6:47 PM, <ki...@apache.org> wrote:
> Author: kinow
> Date: Tue Feb 12 00:47:23 2013
> New Revision: 1445005
>
> URL: http://svn.apache.org/r1445005
> Log:
> Remove duplicated groupId
>
> Modified:
> commons/proper/functor/trunk/api/pom.xml
>
> Modified: commons/proper/functor/trunk/api/pom.xml
> URL:
> http://svn.apache.org/viewvc/commons/proper/functor/trunk/api/pom.xml?rev=1445005&r1=1445004&r2=1445005&view=diff
>
> ==============================================================================
> --- commons/proper/functor/trunk/api/pom.xml (original)
> +++ commons/proper/functor/trunk/api/pom.xml Tue Feb 12 00:47:23 2013
> @@ -22,7 +22,6 @@
> <artifactId>commons-functor-parent</artifactId>
> <version>1.0-SNAPSHOT</version>
> </parent>
> - <groupId>org.apache.commons</groupId>
> <artifactId>commons-functor-api</artifactId>
> <name>Commons Functor API</name>
> <description>Provide the basic APIs</description>
>
>
>
Re: svn commit: r1445005 - /commons/proper/functor/trunk/api/pom.xml
Posted by sebb <se...@gmail.com>.
On 12 February 2013 20:36, Bruno P. Kinoshita
<br...@yahoo.com.br> wrote:
>> But the groupId varies between components, so I think it's important
>> to be specific, even if it happens to be the same as the parent.
>
>
> Ah, I think I got it. The build-tools child module has a different groupId (it's org.apache.commons:commons-functor-build-tools)
No, the build tools groupId is defined as follows:
<groupId>org.apache.commons</groupId>
> , thus having the groupId explicit in the other children modules can help developers/users (and maybe avoid errors) :o)
No, that was not my intention.
> Fair point. I'll revert the change today then.
>
> Thanks!
>
> Bruno P. Kinoshita
> http://kinoshita.eti.br
> http://tupilabs.com
>
>
> ----- Original Message -----
>> From: sebb <se...@gmail.com>
>> To: Commons Developers List <de...@commons.apache.org>; gudnabrsam@gmail.com
>> Cc: Bruno P. Kinoshita <ki...@apache.org>
>> Sent: Tuesday, February 12, 2013 6:20 PM
>> Subject: Re: svn commit: r1445005 - /commons/proper/functor/trunk/api/pom.xml
>>
>> On 12 February 2013 07:05, Matt Benson <gu...@gmail.com> wrote:
>>> Personally I fall on the side of inheriting as much as possible from parent
>>> POMs. If necessary we can have a Commons-wide vote.
>>
>> Yes, for items that are common to all components we should inherit.
>>
>> But the groupId varies between components, so I think it's important
>> to be specific, even if it happens to be the same as the parent.
>>
>> Otherwise it is not clear if the inheritance is deliberate or accidental.
>>
>>> Matt
>>>
>>>
>>> On Mon, Feb 11, 2013 at 10:26 PM, Bruno P. Kinoshita
>> <ki...@apache.org>wrote:
>>>
>>>> >Although strictly speaking the groupId is not required as it is
>>>> >inherited from the parent groupId, I think it's best to be
>> explicit.
>>>>
>>>> I'm fine with or without the groupId in the child project. I think
>> it's
>>>> useful to avoid misspellings and removed because of an Eclipse warning.
>> But
>>>> if by being explicit we will help users/developers, then I'm +1 for
>>>> repeating the groupId :-) Should I revert this change then? (and
>> perhaps
>>>> this could be a good practice for multi-module commons components
>> too?).
>>>>
>>>> Thanks
>>>>
>>>> [1] https://git-wip-us.apache.org/repos/asf/maven.git
>>>>
>>>> Bruno P. Kinoshita
>>>> http://kinoshita.eti.br
>>>> http://tupilabs.com
>>>>
>>>>
>>>> >________________________________
>>>> > From: sebb <se...@gmail.com>
>>>> >To: dev@commons.apache.org
>>>> >Sent: Tuesday, February 12, 2013 12:39 AM
>>>> >Subject: Re: svn commit: r1445005 -
>>>> /commons/proper/functor/trunk/api/pom.xml
>>>> >
>>>> >On 12 February 2013 00:47, <ki...@apache.org> wrote:
>>>> >> Author: kinow
>>>> >> Date: Tue Feb 12 00:47:23 2013
>>>> >> New Revision: 1445005
>>>> >>
>>>> >> URL: http://svn.apache.org/r1445005
>>>> >> Log:
>>>> >> Remove duplicated groupId
>>>> >>
>>>> >> Modified:
>>>> >> commons/proper/functor/trunk/api/pom.xml
>>>> >>
>>>> >> Modified: commons/proper/functor/trunk/api/pom.xml
>>>> >> URL:
>>>>
>> http://svn.apache.org/viewvc/commons/proper/functor/trunk/api/pom.xml?rev=1445005&r1=1445004&r2=1445005&view=diff
>>>> >>
>>>>
>> ==============================================================================
>>>> >> --- commons/proper/functor/trunk/api/pom.xml (original)
>>>> >> +++ commons/proper/functor/trunk/api/pom.xml Tue Feb 12
>> 00:47:23 2013
>>>> >> @@ -22,7 +22,6 @@
>>>> >>
>> <artifactId>commons-functor-parent</artifactId>
>>>> >> <version>1.0-SNAPSHOT</version>
>>>> >> </parent>
>>>> >> - <groupId>org.apache.commons</groupId>
>>>> >
>>>> >Although strictly speaking the groupId is not required as it is
>>>> >inherited from the parent groupId, I think it's best to be
>> explicit.
>>>> >
>>>> >> <artifactId>commons-functor-api</artifactId>
>>>> >> <name>Commons Functor API</name>
>>>> >> <description>Provide the basic
>> APIs</description>
>>>> >>
>>>> >>
>>>> >
>>>>
>>> ---------------------------------------------------------------------
>>>> >To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>> >For additional commands, e-mail: dev-help@commons.apache.org
>>>> >
>>>> >
>>>> >
>>>> >
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>
>>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1445005 - /commons/proper/functor/trunk/api/pom.xml
Posted by "Bruno P. Kinoshita" <br...@yahoo.com.br>.
> But the groupId varies between components, so I think it's important
> to be specific, even if it happens to be the same as the parent.
Ah, I think I got it. The build-tools child module has a different groupId (it's org.apache.commons:commons-functor-build-tools), thus having the groupId explicit in the other children modules can help developers/users (and maybe avoid errors) :o)
Fair point. I'll revert the change today then.
Thanks!
Bruno P. Kinoshita
http://kinoshita.eti.br
http://tupilabs.com
----- Original Message -----
> From: sebb <se...@gmail.com>
> To: Commons Developers List <de...@commons.apache.org>; gudnabrsam@gmail.com
> Cc: Bruno P. Kinoshita <ki...@apache.org>
> Sent: Tuesday, February 12, 2013 6:20 PM
> Subject: Re: svn commit: r1445005 - /commons/proper/functor/trunk/api/pom.xml
>
> On 12 February 2013 07:05, Matt Benson <gu...@gmail.com> wrote:
>> Personally I fall on the side of inheriting as much as possible from parent
>> POMs. If necessary we can have a Commons-wide vote.
>
> Yes, for items that are common to all components we should inherit.
>
> But the groupId varies between components, so I think it's important
> to be specific, even if it happens to be the same as the parent.
>
> Otherwise it is not clear if the inheritance is deliberate or accidental.
>
>> Matt
>>
>>
>> On Mon, Feb 11, 2013 at 10:26 PM, Bruno P. Kinoshita
> <ki...@apache.org>wrote:
>>
>>> >Although strictly speaking the groupId is not required as it is
>>> >inherited from the parent groupId, I think it's best to be
> explicit.
>>>
>>> I'm fine with or without the groupId in the child project. I think
> it's
>>> useful to avoid misspellings and removed because of an Eclipse warning.
> But
>>> if by being explicit we will help users/developers, then I'm +1 for
>>> repeating the groupId :-) Should I revert this change then? (and
> perhaps
>>> this could be a good practice for multi-module commons components
> too?).
>>>
>>> Thanks
>>>
>>> [1] https://git-wip-us.apache.org/repos/asf/maven.git
>>>
>>> Bruno P. Kinoshita
>>> http://kinoshita.eti.br
>>> http://tupilabs.com
>>>
>>>
>>> >________________________________
>>> > From: sebb <se...@gmail.com>
>>> >To: dev@commons.apache.org
>>> >Sent: Tuesday, February 12, 2013 12:39 AM
>>> >Subject: Re: svn commit: r1445005 -
>>> /commons/proper/functor/trunk/api/pom.xml
>>> >
>>> >On 12 February 2013 00:47, <ki...@apache.org> wrote:
>>> >> Author: kinow
>>> >> Date: Tue Feb 12 00:47:23 2013
>>> >> New Revision: 1445005
>>> >>
>>> >> URL: http://svn.apache.org/r1445005
>>> >> Log:
>>> >> Remove duplicated groupId
>>> >>
>>> >> Modified:
>>> >> commons/proper/functor/trunk/api/pom.xml
>>> >>
>>> >> Modified: commons/proper/functor/trunk/api/pom.xml
>>> >> URL:
>>>
> http://svn.apache.org/viewvc/commons/proper/functor/trunk/api/pom.xml?rev=1445005&r1=1445004&r2=1445005&view=diff
>>> >>
>>>
> ==============================================================================
>>> >> --- commons/proper/functor/trunk/api/pom.xml (original)
>>> >> +++ commons/proper/functor/trunk/api/pom.xml Tue Feb 12
> 00:47:23 2013
>>> >> @@ -22,7 +22,6 @@
>>> >>
> <artifactId>commons-functor-parent</artifactId>
>>> >> <version>1.0-SNAPSHOT</version>
>>> >> </parent>
>>> >> - <groupId>org.apache.commons</groupId>
>>> >
>>> >Although strictly speaking the groupId is not required as it is
>>> >inherited from the parent groupId, I think it's best to be
> explicit.
>>> >
>>> >> <artifactId>commons-functor-api</artifactId>
>>> >> <name>Commons Functor API</name>
>>> >> <description>Provide the basic
> APIs</description>
>>> >>
>>> >>
>>> >
>>>
>> ---------------------------------------------------------------------
>>> >To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> >For additional commands, e-mail: dev-help@commons.apache.org
>>> >
>>> >
>>> >
>>> >
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1445005 - /commons/proper/functor/trunk/api/pom.xml
Posted by sebb <se...@gmail.com>.
On 12 February 2013 07:05, Matt Benson <gu...@gmail.com> wrote:
> Personally I fall on the side of inheriting as much as possible from parent
> POMs. If necessary we can have a Commons-wide vote.
Yes, for items that are common to all components we should inherit.
But the groupId varies between components, so I think it's important
to be specific, even if it happens to be the same as the parent.
Otherwise it is not clear if the inheritance is deliberate or accidental.
> Matt
>
>
> On Mon, Feb 11, 2013 at 10:26 PM, Bruno P. Kinoshita <ki...@apache.org>wrote:
>
>> >Although strictly speaking the groupId is not required as it is
>> >inherited from the parent groupId, I think it's best to be explicit.
>>
>> I'm fine with or without the groupId in the child project. I think it's
>> useful to avoid misspellings and removed because of an Eclipse warning. But
>> if by being explicit we will help users/developers, then I'm +1 for
>> repeating the groupId :-) Should I revert this change then? (and perhaps
>> this could be a good practice for multi-module commons components too?).
>>
>> Thanks
>>
>> [1] https://git-wip-us.apache.org/repos/asf/maven.git
>>
>> Bruno P. Kinoshita
>> http://kinoshita.eti.br
>> http://tupilabs.com
>>
>>
>> >________________________________
>> > From: sebb <se...@gmail.com>
>> >To: dev@commons.apache.org
>> >Sent: Tuesday, February 12, 2013 12:39 AM
>> >Subject: Re: svn commit: r1445005 -
>> /commons/proper/functor/trunk/api/pom.xml
>> >
>> >On 12 February 2013 00:47, <ki...@apache.org> wrote:
>> >> Author: kinow
>> >> Date: Tue Feb 12 00:47:23 2013
>> >> New Revision: 1445005
>> >>
>> >> URL: http://svn.apache.org/r1445005
>> >> Log:
>> >> Remove duplicated groupId
>> >>
>> >> Modified:
>> >> commons/proper/functor/trunk/api/pom.xml
>> >>
>> >> Modified: commons/proper/functor/trunk/api/pom.xml
>> >> URL:
>> http://svn.apache.org/viewvc/commons/proper/functor/trunk/api/pom.xml?rev=1445005&r1=1445004&r2=1445005&view=diff
>> >>
>> ==============================================================================
>> >> --- commons/proper/functor/trunk/api/pom.xml (original)
>> >> +++ commons/proper/functor/trunk/api/pom.xml Tue Feb 12 00:47:23 2013
>> >> @@ -22,7 +22,6 @@
>> >> <artifactId>commons-functor-parent</artifactId>
>> >> <version>1.0-SNAPSHOT</version>
>> >> </parent>
>> >> - <groupId>org.apache.commons</groupId>
>> >
>> >Although strictly speaking the groupId is not required as it is
>> >inherited from the parent groupId, I think it's best to be explicit.
>> >
>> >> <artifactId>commons-functor-api</artifactId>
>> >> <name>Commons Functor API</name>
>> >> <description>Provide the basic APIs</description>
>> >>
>> >>
>> >
>> >---------------------------------------------------------------------
>> >To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> >For additional commands, e-mail: dev-help@commons.apache.org
>> >
>> >
>> >
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1445005 - /commons/proper/functor/trunk/api/pom.xml
Posted by Matt Benson <gu...@gmail.com>.
Personally I fall on the side of inheriting as much as possible from parent
POMs. If necessary we can have a Commons-wide vote.
Matt
On Mon, Feb 11, 2013 at 10:26 PM, Bruno P. Kinoshita <ki...@apache.org>wrote:
> >Although strictly speaking the groupId is not required as it is
> >inherited from the parent groupId, I think it's best to be explicit.
>
> I'm fine with or without the groupId in the child project. I think it's
> useful to avoid misspellings and removed because of an Eclipse warning. But
> if by being explicit we will help users/developers, then I'm +1 for
> repeating the groupId :-) Should I revert this change then? (and perhaps
> this could be a good practice for multi-module commons components too?).
>
> Thanks
>
> [1] https://git-wip-us.apache.org/repos/asf/maven.git
>
> Bruno P. Kinoshita
> http://kinoshita.eti.br
> http://tupilabs.com
>
>
> >________________________________
> > From: sebb <se...@gmail.com>
> >To: dev@commons.apache.org
> >Sent: Tuesday, February 12, 2013 12:39 AM
> >Subject: Re: svn commit: r1445005 -
> /commons/proper/functor/trunk/api/pom.xml
> >
> >On 12 February 2013 00:47, <ki...@apache.org> wrote:
> >> Author: kinow
> >> Date: Tue Feb 12 00:47:23 2013
> >> New Revision: 1445005
> >>
> >> URL: http://svn.apache.org/r1445005
> >> Log:
> >> Remove duplicated groupId
> >>
> >> Modified:
> >> commons/proper/functor/trunk/api/pom.xml
> >>
> >> Modified: commons/proper/functor/trunk/api/pom.xml
> >> URL:
> http://svn.apache.org/viewvc/commons/proper/functor/trunk/api/pom.xml?rev=1445005&r1=1445004&r2=1445005&view=diff
> >>
> ==============================================================================
> >> --- commons/proper/functor/trunk/api/pom.xml (original)
> >> +++ commons/proper/functor/trunk/api/pom.xml Tue Feb 12 00:47:23 2013
> >> @@ -22,7 +22,6 @@
> >> <artifactId>commons-functor-parent</artifactId>
> >> <version>1.0-SNAPSHOT</version>
> >> </parent>
> >> - <groupId>org.apache.commons</groupId>
> >
> >Although strictly speaking the groupId is not required as it is
> >inherited from the parent groupId, I think it's best to be explicit.
> >
> >> <artifactId>commons-functor-api</artifactId>
> >> <name>Commons Functor API</name>
> >> <description>Provide the basic APIs</description>
> >>
> >>
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
Re: svn commit: r1445005 - /commons/proper/functor/trunk/api/pom.xml
Posted by sebb <se...@gmail.com>.
On 12 February 2013 04:26, Bruno P. Kinoshita <ki...@apache.org> wrote:
>>Although strictly speaking the groupId is not required as it is
>>inherited from the parent groupId, I think it's best to be explicit.
>
> I'm fine with or without the groupId in the child project. I think it's useful to avoid misspellings and removed because of an Eclipse warning. But if by being explicit we will help users/developers, then I'm +1 for repeating the groupId :-)
> Should I revert this change then?
Please.
> (and perhaps this could be a good practice for multi-module commons components too?).
No.
That's different, because all modules in a component must have the
same groupId (at least I assume that is the case).
> Thanks
>
> [1] https://git-wip-us.apache.org/repos/asf/maven.git
>
> Bruno P. Kinoshita
> http://kinoshita.eti.br
> http://tupilabs.com
>
>
>>________________________________
>> From: sebb <se...@gmail.com>
>>To: dev@commons.apache.org
>>Sent: Tuesday, February 12, 2013 12:39 AM
>>Subject: Re: svn commit: r1445005 - /commons/proper/functor/trunk/api/pom.xml
>>
>>On 12 February 2013 00:47, <ki...@apache.org> wrote:
>>> Author: kinow
>>> Date: Tue Feb 12 00:47:23 2013
>>> New Revision: 1445005
>>>
>>> URL: http://svn.apache.org/r1445005
>>> Log:
>>> Remove duplicated groupId
>>>
>>> Modified:
>>> commons/proper/functor/trunk/api/pom.xml
>>>
>>> Modified: commons/proper/functor/trunk/api/pom.xml
>>> URL: http://svn.apache.org/viewvc/commons/proper/functor/trunk/api/pom.xml?rev=1445005&r1=1445004&r2=1445005&view=diff
>>> ==============================================================================
>>> --- commons/proper/functor/trunk/api/pom.xml (original)
>>> +++ commons/proper/functor/trunk/api/pom.xml Tue Feb 12 00:47:23 2013
>>> @@ -22,7 +22,6 @@
>>> <artifactId>commons-functor-parent</artifactId>
>>> <version>1.0-SNAPSHOT</version>
>>> </parent>
>>> - <groupId>org.apache.commons</groupId>
>>
>>Although strictly speaking the groupId is not required as it is
>>inherited from the parent groupId, I think it's best to be explicit.
>>
>>> <artifactId>commons-functor-api</artifactId>
>>> <name>Commons Functor API</name>
>>> <description>Provide the basic APIs</description>
>>>
>>>
>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1445005 - /commons/proper/functor/trunk/api/pom.xml
Posted by "Bruno P. Kinoshita" <ki...@apache.org>.
>Although strictly speaking the groupId is not required as it is
>inherited from the parent groupId, I think it's best to be explicit.
I'm fine with or without the groupId in the child project. I think it's useful to avoid misspellings and removed because of an Eclipse warning. But if by being explicit we will help users/developers, then I'm +1 for repeating the groupId :-) Should I revert this change then? (and perhaps this could be a good practice for multi-module commons components too?).
Thanks
[1] https://git-wip-us.apache.org/repos/asf/maven.git
Bruno P. Kinoshita
http://kinoshita.eti.br
http://tupilabs.com
>________________________________
> From: sebb <se...@gmail.com>
>To: dev@commons.apache.org
>Sent: Tuesday, February 12, 2013 12:39 AM
>Subject: Re: svn commit: r1445005 - /commons/proper/functor/trunk/api/pom.xml
>
>On 12 February 2013 00:47, <ki...@apache.org> wrote:
>> Author: kinow
>> Date: Tue Feb 12 00:47:23 2013
>> New Revision: 1445005
>>
>> URL: http://svn.apache.org/r1445005
>> Log:
>> Remove duplicated groupId
>>
>> Modified:
>> commons/proper/functor/trunk/api/pom.xml
>>
>> Modified: commons/proper/functor/trunk/api/pom.xml
>> URL: http://svn.apache.org/viewvc/commons/proper/functor/trunk/api/pom.xml?rev=1445005&r1=1445004&r2=1445005&view=diff
>> ==============================================================================
>> --- commons/proper/functor/trunk/api/pom.xml (original)
>> +++ commons/proper/functor/trunk/api/pom.xml Tue Feb 12 00:47:23 2013
>> @@ -22,7 +22,6 @@
>> <artifactId>commons-functor-parent</artifactId>
>> <version>1.0-SNAPSHOT</version>
>> </parent>
>> - <groupId>org.apache.commons</groupId>
>
>Although strictly speaking the groupId is not required as it is
>inherited from the parent groupId, I think it's best to be explicit.
>
>> <artifactId>commons-functor-api</artifactId>
>> <name>Commons Functor API</name>
>> <description>Provide the basic APIs</description>
>>
>>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>For additional commands, e-mail: dev-help@commons.apache.org
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1445005 - /commons/proper/functor/trunk/api/pom.xml
Posted by sebb <se...@gmail.com>.
On 12 February 2013 00:47, <ki...@apache.org> wrote:
> Author: kinow
> Date: Tue Feb 12 00:47:23 2013
> New Revision: 1445005
>
> URL: http://svn.apache.org/r1445005
> Log:
> Remove duplicated groupId
>
> Modified:
> commons/proper/functor/trunk/api/pom.xml
>
> Modified: commons/proper/functor/trunk/api/pom.xml
> URL: http://svn.apache.org/viewvc/commons/proper/functor/trunk/api/pom.xml?rev=1445005&r1=1445004&r2=1445005&view=diff
> ==============================================================================
> --- commons/proper/functor/trunk/api/pom.xml (original)
> +++ commons/proper/functor/trunk/api/pom.xml Tue Feb 12 00:47:23 2013
> @@ -22,7 +22,6 @@
> <artifactId>commons-functor-parent</artifactId>
> <version>1.0-SNAPSHOT</version>
> </parent>
> - <groupId>org.apache.commons</groupId>
Although strictly speaking the groupId is not required as it is
inherited from the parent groupId, I think it's best to be explicit.
> <artifactId>commons-functor-api</artifactId>
> <name>Commons Functor API</name>
> <description>Provide the basic APIs</description>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org