You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Brian Denny <br...@briandenny.net> on 2003/05/27 18:32:36 UTC

'svn pe --revprop' falsely reports success

If you don't enable revprop changes by activating the pre-revprop-change
hook, the subversion server acts as though the hook had failed (no 
propchange is made).

That's fine and dandy, but it's kind of unfortunate that you still get
the message:
  Set new value for property `svn:log' on revision 75

This is, perhaps, a more general case of commit-hook failure not being
reported.  *If* there is a way for the repository administrator to
return an error message from a hook script (not sure off the top of my
head), then it's not a problem in the general case.  But it just seems 
wrong for the default behavior, with no hook-script in place, to be "fail 
while indicating success".

I couldn't find an issue for this in IZ.  Should I open one?

-brian


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: 'svn pe --revprop' falsely reports success

Posted by Brian Denny <br...@briandenny.net>.
On Tue, May 27, 2003 at 01:36:49PM -0500, kfogel@collab.net wrote:
> Ben Collins-Sussman <su...@collab.net> writes:
> > > I couldn't find an issue for this in IZ.  Should I open one?
> > 
> > I think so, yah.
> 
> I'm pretty sure there was an issue about this... Do try some different
> searches, it'll probably turn up.

Issue 443, "post-commit hook script (error) output lost", has comments
about this problem. 

-brian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: 'svn pe --revprop' falsely reports success

Posted by kf...@collab.net.
Ben Collins-Sussman <su...@collab.net> writes:
> > I couldn't find an issue for this in IZ.  Should I open one?
> 
> I think so, yah.

I'm pretty sure there was an issue about this... Do try some different
searches, it'll probably turn up.

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: 'svn pe --revprop' falsely reports success

Posted by Ben Collins-Sussman <su...@collab.net>.
Brian Denny <br...@briandenny.net> writes:

> I couldn't find an issue for this in IZ.  Should I open one?

I think so, yah.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org