You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Sylvain Lebresne (JIRA)" <ji...@apache.org> on 2010/05/06 13:14:49 UTC
[jira] Created: (CASSANDRA-1058) Add ColumnType as enum
Add ColumnType as enum
----------------------
Key: CASSANDRA-1058
URL: https://issues.apache.org/jira/browse/CASSANDRA-1058
Project: Cassandra
Issue Type: Improvement
Affects Versions: 0.7
Reporter: Sylvain Lebresne
Assignee: Kelvin Kakugawa
Fix For: 0.7
Add column type as enum (in particular in preparation for CASSANDRA-580)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1058) Add ColumnType as enum
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12865062#action_12865062 ]
Sylvain Lebresne commented on CASSANDRA-1058:
---------------------------------------------
What about ColumnFamilyType actually for this one ?
It seems a bit more precise to me and in the code, the function that will
return this enum arealready called getColumnFamilyType or
validateColumnFamily (but just proposing, RowType is shorter, I see
the advantages in that :)).
> Add ColumnType as enum
> ----------------------
>
> Key: CASSANDRA-1058
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1058
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: 0.7
> Reporter: Sylvain Lebresne
> Assignee: Kelvin Kakugawa
> Fix For: 0.7
>
> Attachments: 1058-Add-ColumnType-as-enum.patch
>
>
> Add column type as enum (in particular in preparation for CASSANDRA-580)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1058) Add ColumnType as enum
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12865122#action_12865122 ]
Jonathan Ellis commented on CASSANDRA-1058:
-------------------------------------------
Fine
> Add ColumnType as enum
> ----------------------
>
> Key: CASSANDRA-1058
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1058
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: 0.7
> Reporter: Sylvain Lebresne
> Assignee: Kelvin Kakugawa
> Fix For: 0.7
>
> Attachments: 1058-Add-ColumnType-as-enum.patch, 1058-Add-the-ColumnFamilyType-enum.patch
>
>
> Add column type as enum (in particular in preparation for CASSANDRA-580)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1058) Add ColumnType as enum
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne updated CASSANDRA-1058:
----------------------------------------
Attachment: 1058-Add-the-ColumnFamilyType-enum.patch
Attaching the patch using the ColumnFamilyType name as it feel more natural to me.
I can switch back to RowType really quickly if there is a consensus for that, so feel free
to ask.
> Add ColumnType as enum
> ----------------------
>
> Key: CASSANDRA-1058
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1058
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: 0.7
> Reporter: Sylvain Lebresne
> Assignee: Kelvin Kakugawa
> Fix For: 0.7
>
> Attachments: 1058-Add-ColumnType-as-enum.patch, 1058-Add-the-ColumnFamilyType-enum.patch
>
>
> Add column type as enum (in particular in preparation for CASSANDRA-580)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1058) Add ColumnType as enum
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864798#action_12864798 ]
Sylvain Lebresne commented on CASSANDRA-1058:
---------------------------------------------
My opinion is that RowType is not perfect either as whatever name we choose, it will
describe the columns of a SuperColumn (damn SuperColumns ...), that are no row.
Maybe ContainerType or the longer ColumnContainerType ?
> Add ColumnType as enum
> ----------------------
>
> Key: CASSANDRA-1058
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1058
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: 0.7
> Reporter: Sylvain Lebresne
> Assignee: Kelvin Kakugawa
> Fix For: 0.7
>
> Attachments: 1058-Add-ColumnType-as-enum.patch
>
>
> Add column type as enum (in particular in preparation for CASSANDRA-580)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1058) Add ColumnType as enum
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864797#action_12864797 ]
Jonathan Ellis commented on CASSANDRA-1058:
-------------------------------------------
wouldn't RowType be a better description of the enum's purpose?
> Add ColumnType as enum
> ----------------------
>
> Key: CASSANDRA-1058
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1058
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: 0.7
> Reporter: Sylvain Lebresne
> Assignee: Kelvin Kakugawa
> Fix For: 0.7
>
> Attachments: 1058-Add-ColumnType-as-enum.patch
>
>
> Add column type as enum (in particular in preparation for CASSANDRA-580)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1058) Add ColumnType as enum
Posted by "Todd Blose (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864803#action_12864803 ]
Todd Blose commented on CASSANDRA-1058:
---------------------------------------
SnakeYAML supports java enums. If you're going to do this, you should expect a correct enum in the config instead of doing extra parsing in DatabaseDescriptor.
http://code.google.com/p/snakeyaml/wiki/Documentation#Enum
> Add ColumnType as enum
> ----------------------
>
> Key: CASSANDRA-1058
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1058
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: 0.7
> Reporter: Sylvain Lebresne
> Assignee: Kelvin Kakugawa
> Fix For: 0.7
>
> Attachments: 1058-Add-ColumnType-as-enum.patch
>
>
> Add column type as enum (in particular in preparation for CASSANDRA-580)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1058) Add ColumnType as enum
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864805#action_12864805 ]
Jonathan Ellis commented on CASSANDRA-1058:
-------------------------------------------
I must be missing something, because it seems to me that Version shouldn't be part of ColumnType, it should be part of the timestamp stuff.
That is, a column and a supercolumn will both have a Version, which will either be a byte[], or a long. As with today, SC would only need that for tombstone-ing.
> Add ColumnType as enum
> ----------------------
>
> Key: CASSANDRA-1058
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1058
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: 0.7
> Reporter: Sylvain Lebresne
> Assignee: Kelvin Kakugawa
> Fix For: 0.7
>
> Attachments: 1058-Add-ColumnType-as-enum.patch
>
>
> Add column type as enum (in particular in preparation for CASSANDRA-580)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1058) Add ColumnType as enum
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864799#action_12864799 ]
Jonathan Ellis commented on CASSANDRA-1058:
-------------------------------------------
it describes whether the row contains columns or supercolumns, no?
> Add ColumnType as enum
> ----------------------
>
> Key: CASSANDRA-1058
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1058
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: 0.7
> Reporter: Sylvain Lebresne
> Assignee: Kelvin Kakugawa
> Fix For: 0.7
>
> Attachments: 1058-Add-ColumnType-as-enum.patch
>
>
> Add column type as enum (in particular in preparation for CASSANDRA-580)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1058) Add ColumnType as enum
Posted by "Kelvin Kakugawa (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864827#action_12864827 ]
Kelvin Kakugawa commented on CASSANDRA-1058:
--------------------------------------------
(as discussed on IRC)
the plans are to name this RowType (since, CFs are restricted to one Column type)
RowType will only encompass: Super, Standard
> Add ColumnType as enum
> ----------------------
>
> Key: CASSANDRA-1058
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1058
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: 0.7
> Reporter: Sylvain Lebresne
> Assignee: Kelvin Kakugawa
> Fix For: 0.7
>
> Attachments: 1058-Add-ColumnType-as-enum.patch
>
>
> Add column type as enum (in particular in preparation for CASSANDRA-580)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1058) Add ColumnType as enum
Posted by "Kelvin Kakugawa (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864814#action_12864814 ]
Kelvin Kakugawa commented on CASSANDRA-1058:
--------------------------------------------
Right now, in 580, I use the ColumnType enum to denote whether the Version (actually called Clock) is a byte[] or a long.
For this patch, it should be sufficient to just support Standard and Super.
> Add ColumnType as enum
> ----------------------
>
> Key: CASSANDRA-1058
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1058
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: 0.7
> Reporter: Sylvain Lebresne
> Assignee: Kelvin Kakugawa
> Fix For: 0.7
>
> Attachments: 1058-Add-ColumnType-as-enum.patch
>
>
> Add column type as enum (in particular in preparation for CASSANDRA-580)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1058) Add ColumnType as enum
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne updated CASSANDRA-1058:
----------------------------------------
Attachment: 1058-Add-ColumnType-as-enum.patch
Adding first part from CASSANDRA-580 wip patch rebased against trunk.
> Add ColumnType as enum
> ----------------------
>
> Key: CASSANDRA-1058
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1058
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: 0.7
> Reporter: Sylvain Lebresne
> Assignee: Kelvin Kakugawa
> Fix For: 0.7
>
> Attachments: 1058-Add-ColumnType-as-enum.patch
>
>
> Add column type as enum (in particular in preparation for CASSANDRA-580)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1058) Add ColumnType as enum
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864801#action_12864801 ]
Sylvain Lebresne commented on CASSANDRA-1058:
---------------------------------------------
Not only. That is, SuperColumn have a ColumnType too. Right now, this can only be Standard.
But 580 will introduce other kind, like a 'Version' ColumnType, that SuperColumn can contain.
I believe the long way to describe it is "The kind of IColumn a IColumnContainer contains".
> Add ColumnType as enum
> ----------------------
>
> Key: CASSANDRA-1058
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1058
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: 0.7
> Reporter: Sylvain Lebresne
> Assignee: Kelvin Kakugawa
> Fix For: 0.7
>
> Attachments: 1058-Add-ColumnType-as-enum.patch
>
>
> Add column type as enum (in particular in preparation for CASSANDRA-580)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.