You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/02/09 16:07:01 UTC

[GitHub] [arrow-rs] tustvold opened a new issue, #3684: ArrowArray::try_from_raw Misleading Signature

tustvold opened a new issue, #3684:
URL: https://github.com/apache/arrow-rs/issues/3684

   **Describe the bug**
   <!--
   A clear and concise description of what the bug is.
   -->
   
   `ArrowArray::try_from_raw` accepts `*const FFI_ArrowArray` and `*const FFI_ArrowSchema`. As of https://github.com/apache/arrow-rs/pull/1449 no longer takes ownership of the pointers, and instead "moves" the contents into its own allocations. The method is unsafe, and so this technically isn't unsound, but it is fairly surprising to people unfamiliar with the interface who might assume they can pass in a const reference.
   
   Related to this, the fact it doesn't take ownership makes it very easy to accidentally leak memory https://github.com/apache/arrow-rs/pull/1878 and https://github.com/apache/arrow-rs/issues/3683
   
   **To Reproduce**
   <!--
   Steps to reproduce the behavior:
   -->
   
   **Expected behavior**
   <!--
   A clear and concise description of what you expected to happen.
   -->
   
   **Additional context**
   <!--
   Add any other context about the problem here.
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold commented on issue #3684: ArrowArray::try_from_raw Misleading Signature

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on issue #3684:
URL: https://github.com/apache/arrow-rs/issues/3684#issuecomment-1426077098

   `label_issue.py` automatically added labels {'arrow'} from #3685


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold closed issue #3684: ArrowArray::try_from_raw Misleading Signature

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold closed issue #3684: ArrowArray::try_from_raw Misleading Signature
URL: https://github.com/apache/arrow-rs/issues/3684


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org