[GitHub] jvrao commented on issue #774: Open should run recovery by default

[GitBox <gi...@apache.org>]

jvrao commented on issue #774: Open should run recovery by default
URL: https://github.com/apache/bookkeeper/pull/774#issuecomment-347095397
 
 
   Thanks for the ping. It is an API change and it is changing old behavior. 
   So users need to be very careful in moving to new API. So lets take a case/scenario 
   1. non-recovery: default
   If the caller doesn't know what they are doing, the ledger may *never* get sealed. 
   What is the down side of that? Replicator will seal it if it needs to, but until then last
   fragment may stay under replicatated. 
   
   2. Recovery: Default
   If the caller doesn't know what they are doing, writer may get an error.
   
   @ivankelly Am I missing anything on the down side of non-recover default? 
   While I like to keep the old behavior, it is natural understanding that the open for read
   is generally non invasive. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services