You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by GitBox <gi...@apache.org> on 2022/03/13 22:05:38 UTC
[GitHub] [sling-feature-launcher-maven-plugin] enapps-enorman opened a new pull request #4: SLING-11158 use feature launcher assembly to launch
enapps-enorman opened a new pull request #4:
URL: https://github.com/apache/sling-feature-launcher-maven-plugin/pull/4
unpack the feature launcher assembly and use the contained script
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-feature-launcher-maven-plugin] sonarcloud[bot] removed a comment on pull request #4: SLING-11158 use feature launcher assembly to launch
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #4:
URL: https://github.com/apache/sling-feature-launcher-maven-plugin/pull/4#issuecomment-1066197070
SonarCloud Quality Gate failed. 
[](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-feature-launcher-maven-plugin] sonarcloud[bot] commented on pull request #4: SLING-11158 use feature launcher assembly to launch
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #4:
URL: https://github.com/apache/sling-feature-launcher-maven-plugin/pull/4#issuecomment-1066197070
SonarCloud Quality Gate failed. 
[](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-feature-launcher-maven-plugin] sonarcloud[bot] removed a comment on pull request #4: SLING-11158 use feature launcher assembly to launch
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #4:
URL: https://github.com/apache/sling-feature-launcher-maven-plugin/pull/4#issuecomment-1066192155
SonarCloud Quality Gate failed. 
[](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-feature-launcher-maven-plugin] sonarcloud[bot] commented on pull request #4: SLING-11158 use feature launcher assembly to launch
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #4:
URL: https://github.com/apache/sling-feature-launcher-maven-plugin/pull/4#issuecomment-1066192155
SonarCloud Quality Gate failed. 
[](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-feature-launcher-maven-plugin] rombert commented on a change in pull request #4: SLING-11158 use feature launcher assembly to launch
Posted by GitBox <gi...@apache.org>.
rombert commented on a change in pull request #4:
URL: https://github.com/apache/sling-feature-launcher-maven-plugin/pull/4#discussion_r825781550
##########
File path: src/it/simple-it/pom.xml
##########
@@ -101,6 +101,7 @@
<artifactId>@project.artifactId@</artifactId>
<version>@project.version@</version>
<configuration>
+ <featureLauncherVersion>1.1.26</featureLauncherVersion>
Review comment:
It would be good to add a comment saying why we pin the version here.
##########
File path: src/it/simple-it/pom.xml
##########
@@ -101,6 +101,7 @@
<artifactId>@project.artifactId@</artifactId>
<version>@project.version@</version>
<configuration>
+ <featureLauncherVersion>1.1.26</featureLauncherVersion>
Review comment:
It would be good to add a comment saying why we pin the version here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-feature-launcher-maven-plugin] rombert commented on a change in pull request #4: SLING-11158 use feature launcher assembly to launch
Posted by GitBox <gi...@apache.org>.
rombert commented on a change in pull request #4:
URL: https://github.com/apache/sling-feature-launcher-maven-plugin/pull/4#discussion_r825779156
##########
File path: src/main/java/org/apache/sling/maven/feature/launcher/StartMojo.java
##########
@@ -124,24 +171,58 @@ public void execute() throws MojoExecutionException, MojoFailureException {
File featureFile = result.getArtifact().getFile();
List<String> args = new ArrayList<>();
- String javahome = System.getenv("JAVA_HOME");
- if (javahome == null || javahome.isEmpty()) {
- // SLING-9843 fallback to java.home system property if JAVA_HOME env variable is not set
- getLog().warn("The JAVA_HOME env variable was not set, falling back to the java.home system property");
- javahome = System.getProperty("java.home");
- }
- args.add(javahome + File.separatorChar + "bin" + File.separatorChar + "java");
- // SLING-9994 - if any extra vm options were supplied, apply them here
- String[] vmOptions = launch.getLauncherArguments().getVmOptions();
- if (vmOptions != null) {
- for (String vmOption : vmOptions) {
- if (vmOption != null && !vmOption.isEmpty()) {
- args.add(vmOption);
+ if (useAssembly) {
Review comment:
I have not checked, but I assume that the launcher script consults the `JAVA_HOME` env var, right?
##########
File path: src/main/java/org/apache/sling/maven/feature/launcher/StartMojo.java
##########
@@ -124,24 +171,58 @@ public void execute() throws MojoExecutionException, MojoFailureException {
File featureFile = result.getArtifact().getFile();
List<String> args = new ArrayList<>();
- String javahome = System.getenv("JAVA_HOME");
- if (javahome == null || javahome.isEmpty()) {
- // SLING-9843 fallback to java.home system property if JAVA_HOME env variable is not set
- getLog().warn("The JAVA_HOME env variable was not set, falling back to the java.home system property");
- javahome = System.getProperty("java.home");
- }
- args.add(javahome + File.separatorChar + "bin" + File.separatorChar + "java");
- // SLING-9994 - if any extra vm options were supplied, apply them here
- String[] vmOptions = launch.getLauncherArguments().getVmOptions();
- if (vmOptions != null) {
- for (String vmOption : vmOptions) {
- if (vmOption != null && !vmOption.isEmpty()) {
- args.add(vmOption);
+ if (useAssembly) {
Review comment:
I have not checked, but I assume that the launcher script consults the `JAVA_HOME` env var, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-feature-launcher-maven-plugin] enapps-enorman commented on a change in pull request #4: SLING-11158 use feature launcher assembly to launch
Posted by GitBox <gi...@apache.org>.
enapps-enorman commented on a change in pull request #4:
URL: https://github.com/apache/sling-feature-launcher-maven-plugin/pull/4#discussion_r826257664
##########
File path: src/main/java/org/apache/sling/maven/feature/launcher/StartMojo.java
##########
@@ -124,24 +171,58 @@ public void execute() throws MojoExecutionException, MojoFailureException {
File featureFile = result.getArtifact().getFile();
List<String> args = new ArrayList<>();
- String javahome = System.getenv("JAVA_HOME");
- if (javahome == null || javahome.isEmpty()) {
- // SLING-9843 fallback to java.home system property if JAVA_HOME env variable is not set
- getLog().warn("The JAVA_HOME env variable was not set, falling back to the java.home system property");
- javahome = System.getProperty("java.home");
- }
- args.add(javahome + File.separatorChar + "bin" + File.separatorChar + "java");
- // SLING-9994 - if any extra vm options were supplied, apply them here
- String[] vmOptions = launch.getLauncherArguments().getVmOptions();
- if (vmOptions != null) {
- for (String vmOption : vmOptions) {
- if (vmOption != null && !vmOption.isEmpty()) {
- args.add(vmOption);
+ if (useAssembly) {
Review comment:
Yes the launcher script does have some logic for finding where the java executable is. But thinking more about this more, it probably wouldn't hurt to set the JAVA_HOME env variable here to deal with things like SLING-9843
I''ll make that change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-feature-launcher-maven-plugin] enapps-enorman commented on a change in pull request #4: SLING-11158 use feature launcher assembly to launch
Posted by GitBox <gi...@apache.org>.
enapps-enorman commented on a change in pull request #4:
URL: https://github.com/apache/sling-feature-launcher-maven-plugin/pull/4#discussion_r826257956
##########
File path: src/it/simple-it/pom.xml
##########
@@ -101,6 +101,7 @@
<artifactId>@project.artifactId@</artifactId>
<version>@project.version@</version>
<configuration>
+ <featureLauncherVersion>1.1.26</featureLauncherVersion>
Review comment:
sure. I'll add a comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-feature-launcher-maven-plugin] sonarcloud[bot] commented on pull request #4: SLING-11158 use feature launcher assembly to launch
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #4:
URL: https://github.com/apache/sling-feature-launcher-maven-plugin/pull/4#issuecomment-1067184211
SonarCloud Quality Gate failed. 
[](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-feature-launcher-maven-plugin&pullRequest=4&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org