You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/01 03:17:57 UTC
[GitHub] [pulsar] congbobo184 opened a new pull request #9388: [Pulsar sql] Support keyValue Schema separate mode.
congbobo184 opened a new pull request #9388:
URL: https://github.com/apache/pulsar/pull/9388
## Motivation
Support keyValue Schema separate mode.
## implement
PulsarSqlSchemaInfoProvider add the type for get key or value schema.
### Verifying this change
Add the test for it
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] congbobo184 commented on pull request #9388: [Pulsar sql] Support keyValue Schema separate mode.
Posted by GitBox <gi...@apache.org>.
congbobo184 commented on pull request #9388:
URL: https://github.com/apache/pulsar/pull/9388#issuecomment-771458690
> > #8422 has solve this problem, so this PR only add the test
>
> I added `TestPulsarRecordCursor#TestKeyValueStructSchema` and `TestPulsarRecordCursor#TestKeyValuePrimitiveSchema ` in #8422 , which contains `KeyValueEncodingType.INLINE` and `KeyValueEncodingType.SEPARATED` modes unit test , but lack of integration test ?
Yes, it lack integration test. If you want to add the test, i will close this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #9388: [Pulsar sql] Support keyValue Schema add integration test.
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #9388:
URL: https://github.com/apache/pulsar/pull/9388#issuecomment-785530890
https://github.com/apache/pulsar/pull/9685 is fixing the branch-2.7
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] congbobo184 commented on pull request #9388: [Pulsar sql] Support keyValue Schema separate mode.
Posted by GitBox <gi...@apache.org>.
congbobo184 commented on pull request #9388:
URL: https://github.com/apache/pulsar/pull/9388#issuecomment-771324098
https://github.com/apache/pulsar/pull/8422 has solve this problem, so this PR only add the test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #9388: [Pulsar sql] Support keyValue Schema add integration test.
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #9388:
URL: https://github.com/apache/pulsar/pull/9388#issuecomment-782972641
@sijie Please help take a look at this PR again. @congbobo184 Could you please check the branch-2.7? I think branch-2.7 does not work. Since we can't cherry-pick #8422, could you please create a PR to fix the branch-2.7?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hnail edited a comment on pull request #9388: [Pulsar sql] Support keyValue Schema separate mode.
Posted by GitBox <gi...@apache.org>.
hnail edited a comment on pull request #9388:
URL: https://github.com/apache/pulsar/pull/9388#issuecomment-771461123
> > > #8422 has solve this problem, so this PR only add the test
> >
> >
> > I added `TestPulsarRecordCursor#TestKeyValueStructSchema` and `TestPulsarRecordCursor#TestKeyValuePrimitiveSchema ` in #8422 , which contains `KeyValueEncodingType.INLINE` and `KeyValueEncodingType.SEPARATED` modes unit test , but lack of integration test ?
>
> Yes, it lack integration test. If you want to add the test, i will close this PR.
> > > #8422 has solve this problem, so this PR only add the test
> >
> >
> > I added `TestPulsarRecordCursor#TestKeyValueStructSchema` and `TestPulsarRecordCursor#TestKeyValuePrimitiveSchema ` in #8422 , which contains `KeyValueEncodingType.INLINE` and `KeyValueEncodingType.SEPARATED` modes unit test , but lack of integration test ?
>
> Yes, it lack integration test. If you want to add the test, i will close this PR.
thanks for replay , I'm not working the integration tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] congbobo184 commented on pull request #9388: [Pulsar sql] Support keyValue Schema separate mode.
Posted by GitBox <gi...@apache.org>.
congbobo184 commented on pull request #9388:
URL: https://github.com/apache/pulsar/pull/9388#issuecomment-771324098
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] congbobo184 edited a comment on pull request #9388: [Pulsar sql] Support keyValue Schema separate mode.
Posted by GitBox <gi...@apache.org>.
congbobo184 edited a comment on pull request #9388:
URL: https://github.com/apache/pulsar/pull/9388#issuecomment-771572669
@hnail OK, i will work on this pr. thanks reply.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] congbobo184 commented on pull request #9388: [Pulsar sql] Support keyValue Schema separate mode.
Posted by GitBox <gi...@apache.org>.
congbobo184 commented on pull request #9388:
URL: https://github.com/apache/pulsar/pull/9388#issuecomment-782548881
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #9388: [Pulsar sql] Support keyValue Schema add integration test.
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #9388:
URL: https://github.com/apache/pulsar/pull/9388
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hnail commented on pull request #9388: [Pulsar sql] Support keyValue Schema separate mode.
Posted by GitBox <gi...@apache.org>.
hnail commented on pull request #9388:
URL: https://github.com/apache/pulsar/pull/9388#issuecomment-771461123
> > > #8422 has solve this problem, so this PR only add the test
> >
> >
> > I added `TestPulsarRecordCursor#TestKeyValueStructSchema` and `TestPulsarRecordCursor#TestKeyValuePrimitiveSchema ` in #8422 , which contains `KeyValueEncodingType.INLINE` and `KeyValueEncodingType.SEPARATED` modes unit test , but lack of integration test ?
>
> Yes, it lack integration test. If you want to add the test, i will close this PR.
> > > #8422 has solve this problem, so this PR only add the test
> >
> >
> > I added `TestPulsarRecordCursor#TestKeyValueStructSchema` and `TestPulsarRecordCursor#TestKeyValuePrimitiveSchema ` in #8422 , which contains `KeyValueEncodingType.INLINE` and `KeyValueEncodingType.SEPARATED` modes unit test , but lack of integration test ?
>
> Yes, it lack integration test. If you want to add the test, i will close this PR.
thanks replay , I'm not working the integration tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hnail edited a comment on pull request #9388: [Pulsar sql] Support keyValue Schema separate mode.
Posted by GitBox <gi...@apache.org>.
hnail edited a comment on pull request #9388:
URL: https://github.com/apache/pulsar/pull/9388#issuecomment-771461123
> > > #8422 has solve this problem, so this PR only add the test
> >
> >
> > I added `TestPulsarRecordCursor#TestKeyValueStructSchema` and `TestPulsarRecordCursor#TestKeyValuePrimitiveSchema ` in #8422 , which contains `KeyValueEncodingType.INLINE` and `KeyValueEncodingType.SEPARATED` modes unit test , but lack of integration test ?
>
> Yes, it lack integration test. If you want to add the test, i will close this PR.
> > > #8422 has solve this problem, so this PR only add the test
> >
> >
> > I added `TestPulsarRecordCursor#TestKeyValueStructSchema` and `TestPulsarRecordCursor#TestKeyValuePrimitiveSchema ` in #8422 , which contains `KeyValueEncodingType.INLINE` and `KeyValueEncodingType.SEPARATED` modes unit test , but lack of integration test ?
>
> Yes, it lack integration test. If you want to add the test, i will close this PR.
thanks for replay , I'm not working the integration tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] congbobo184 edited a comment on pull request #9388: [Pulsar sql] Support keyValue Schema separate mode.
Posted by GitBox <gi...@apache.org>.
congbobo184 edited a comment on pull request #9388:
URL: https://github.com/apache/pulsar/pull/9388#issuecomment-771572669
@hnail OK, i will work on this pr. thanks reply.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] congbobo184 commented on pull request #9388: [Pulsar sql] Support keyValue Schema separate mode.
Posted by GitBox <gi...@apache.org>.
congbobo184 commented on pull request #9388:
URL: https://github.com/apache/pulsar/pull/9388#issuecomment-770900021
> @congbobo184 Can you add an integration test to test KeyValue schema with both separate and inline modes?
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hnail commented on pull request #9388: [Pulsar sql] Support keyValue Schema separate mode.
Posted by GitBox <gi...@apache.org>.
hnail commented on pull request #9388:
URL: https://github.com/apache/pulsar/pull/9388#issuecomment-771412851
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] congbobo184 commented on pull request #9388: [Pulsar sql] Support keyValue Schema separate mode.
Posted by GitBox <gi...@apache.org>.
congbobo184 commented on pull request #9388:
URL: https://github.com/apache/pulsar/pull/9388#issuecomment-771572669
@hnail OK, i will work in this pr. thanks reply.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hnail commented on pull request #9388: [Pulsar sql] Support keyValue Schema separate mode.
Posted by GitBox <gi...@apache.org>.
hnail commented on pull request #9388:
URL: https://github.com/apache/pulsar/pull/9388#issuecomment-771412851
> #8422 has solve this problem, so this PR only add the test
I added `TestPulsarRecordCursor#TestKeyValueStructSchema` and `TestPulsarRecordCursor#TestKeyValuePrimitiveSchema ` in #8422 , which contains `KeyValueEncodingType.INLINE` and `KeyValueEncodingType.SEPARATED` modes unit test , but lack of integration test ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] congbobo184 commented on pull request #9388: [Pulsar sql] Support keyValue Schema separate mode.
Posted by GitBox <gi...@apache.org>.
congbobo184 commented on pull request #9388:
URL: https://github.com/apache/pulsar/pull/9388#issuecomment-781802880
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org