[jira] [Commented] (FLINK-7254) java8 module pom disables checkstyle

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16099807#comment-16099807 ] 

ASF GitHub Bot commented on FLINK-7254:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/4393

    [FLINK-7254] [java8] Properly activate checkstyle for flink-java8

    This PR modifies the java8 pom to not disable checkstyle. A few changes had to be made to make the module checkstyle compliant.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 7254

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4393.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4393
    
----
commit 2c0d1a32179fd7dfa6efbac6b55ae334f30fa74c
Author: zentol <ch...@apache.org>
Date:   2017-07-24T12:14:19Z

    [FLINK-7254] [java8] Properly activate checkstyle for flink-java8

----


> java8 module pom disables checkstyle
> ------------------------------------
>
>                 Key: FLINK-7254
>                 URL: https://issues.apache.org/jira/browse/FLINK-7254
>             Project: Flink
>          Issue Type: Bug
>          Components: Checkstyle
>    Affects Versions: 1.4.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.4.0
>
>
> The java8 pom file contains this:
> {code}
> 	<properties>
> 		<checkstyle.skip>true</checkstyle.skip>
> 	</properties>
> {code}
> Thus the checkstyle is not actually enforced.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)