You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/07/28 02:56:22 UTC
Review Request 36870: Added -> operator for Future.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36870/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Jie Yu, and Joris Van Remoortere.
Bugs: MESOS-2757
https://issues.apache.org/jira/browse/MESOS-2757
Repository: mesos
Description
-------
See MESOS-2757.
Diffs
-----
3rdparty/libprocess/Makefile.am e9c42d7ecd44eebeadcc3d1d5011e01674b3415a
3rdparty/libprocess/include/process/future.hpp db92767619ec7b6ab1a0803c240725a2633d2489
3rdparty/libprocess/src/tests/future_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/36870/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 36870: Added -> operator for Future.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36870/#review93406
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On July 28, 2015, 12:56 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36870/
> -----------------------------------------------------------
>
> (Updated July 28, 2015, 12:56 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Jie Yu, and Joris Van Remoortere.
>
>
> Bugs: MESOS-2757
> https://issues.apache.org/jira/browse/MESOS-2757
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See MESOS-2757.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am e9c42d7ecd44eebeadcc3d1d5011e01674b3415a
> 3rdparty/libprocess/include/process/future.hpp db92767619ec7b6ab1a0803c240725a2633d2489
> 3rdparty/libprocess/src/tests/future_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/36870/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 36870: Added -> operator for Future.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36870/#review93218
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36868, 36869, 36870]
All tests passed.
- Mesos ReviewBot
On July 28, 2015, 12:56 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36870/
> -----------------------------------------------------------
>
> (Updated July 28, 2015, 12:56 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Jie Yu, and Joris Van Remoortere.
>
>
> Bugs: MESOS-2757
> https://issues.apache.org/jira/browse/MESOS-2757
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See MESOS-2757.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am e9c42d7ecd44eebeadcc3d1d5011e01674b3415a
> 3rdparty/libprocess/include/process/future.hpp db92767619ec7b6ab1a0803c240725a2633d2489
> 3rdparty/libprocess/src/tests/future_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/36870/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 36870: Added -> operator for Future.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36870/#review96409
-----------------------------------------------------------
Ship it!
Adjusted the operater spacing to match updated style.
- Joris Van Remoortere
On July 28, 2015, 12:56 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36870/
> -----------------------------------------------------------
>
> (Updated July 28, 2015, 12:56 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Jie Yu, and Joris Van Remoortere.
>
>
> Bugs: MESOS-2757
> https://issues.apache.org/jira/browse/MESOS-2757
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See MESOS-2757.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am e9c42d7ecd44eebeadcc3d1d5011e01674b3415a
> 3rdparty/libprocess/include/process/future.hpp db92767619ec7b6ab1a0803c240725a2633d2489
> 3rdparty/libprocess/src/tests/future_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/36870/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>