You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/25 14:13:32 UTC
[GitHub] [spark] gengliangwang opened a new pull request, #36669: [SPARK-39234][SQL][3.3] Code clean up in SparkThrowableHelper.getMessage
gengliangwang opened a new pull request, #36669:
URL: https://github.com/apache/spark/pull/36669
### What changes were proposed in this pull request?
1. Remove the starting "\n" in `Origin.context`. The "\n" will be append in the method `SparkThrowableHelper.getMessage` instead.
2. Code clean up the method SparkThrowableHelper.getMessage to eliminate redundant code.
### Why are the changes needed?
Code clean up to eliminate redundant code.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Existing UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #36669: [SPARK-39234][SQL][3.3] Code clean up in SparkThrowableHelper.getMessage
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on PR #36669:
URL: https://github.com/apache/spark/pull/36669#issuecomment-1138246684
Merging to 3.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang closed pull request #36669: [SPARK-39234][SQL][3.3] Code clean up in SparkThrowableHelper.getMessage
Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #36669: [SPARK-39234][SQL][3.3] Code clean up in SparkThrowableHelper.getMessage
URL: https://github.com/apache/spark/pull/36669
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #36669: [SPARK-39234][SQL][3.3] Code clean up in SparkThrowableHelper.getMessage
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on PR #36669:
URL: https://github.com/apache/spark/pull/36669#issuecomment-1137306593
This is to port https://github.com/apache/spark/pull/36612 to 3.3. I would like to port https://github.com/apache/spark/pull/36651 later too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org