You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by re...@apache.org on 2026/06/08 13:52:01 UTC

(tomcat-jakartaee-migration) branch main updated: Add a comment for code review

This is an automated email from the ASF dual-hosted git repository.

rmaucher pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git


The following commit(s) were added to refs/heads/main by this push:
     new 702cf4a  Add a comment for code review
702cf4a is described below

commit 702cf4a1d233f1fb7082e82d4b5a8ba0aac36f7d
Author: remm <re...@apache.org>
AuthorDate: Mon Jun 8 15:51:50 2026 +0200

    Add a comment for code review
---
 src/main/java/org/apache/tomcat/jakartaee/Migration.java | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/main/java/org/apache/tomcat/jakartaee/Migration.java b/src/main/java/org/apache/tomcat/jakartaee/Migration.java
index 2ffdcb3..ac5ab45 100644
--- a/src/main/java/org/apache/tomcat/jakartaee/Migration.java
+++ b/src/main/java/org/apache/tomcat/jakartaee/Migration.java
@@ -403,6 +403,8 @@ public class Migration {
         // Create the destination in memory
         SeekableInMemoryByteChannel destByteChannel = new SeekableInMemoryByteChannel();
 
+        // In memory can have much simpler processing compared to the streaming version,
+        // including STORED entries processing, due to the use of a seekable channel
         try (ZipFile srcZipFile = ZipFile.builder().setSeekableByteChannel(srcByteChannel).get();
                 ZipArchiveOutputStream destZipStream = new ZipArchiveOutputStream(destByteChannel)) {
             Enumeration<ZipArchiveEntry> entries = srcZipFile.getEntries();


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org